From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Jack Zhu <jack.zhu@starfivetech.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx
Date: Thu, 13 Apr 2023 10:41:23 +0200 [thread overview]
Message-ID: <f0d82428-aaa5-3dd4-bc29-f1057fe749bc@linaro.org> (raw)
In-Reply-To: <b34a8d59-34e4-8358-9d2b-367f4707ca7c@starfivetech.com>
On 13/04/2023 04:34, Changhuang Liang wrote:
>>>>> + lane_maps:
>>>>
>>>> Why did this appear? Underscores are not allowed. It looks like you
>>>> re-implement some standard property.
>>>>
>>>
>>> Will change to lane-maps.
>>> Yes, according to Vinod advice, lane mapping table use device tree
>>> to parse makes sense.
>>
>> Hm, I have a feeling that I saw such property, so you should dig into
>> existing and in-flight bindings.
>>
>> Best regards,
>> Krzysztof
>>
>
> A standard property? Like "clocks" or "resets"?
Like lane-polarities now submitted to one MIPI.
Anyway it does not look like a property of a board. You said it is fixed
per SoC, so it should be implied from the compatible. Otherwise please
explain in description and provide some rationale.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-13 8:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 8:45 [PATCH v4 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx Changhuang Liang
2023-04-12 11:34 ` Krzysztof Kozlowski
2023-04-12 12:42 ` Changhuang Liang
2023-04-12 16:55 ` Krzysztof Kozlowski
2023-04-13 1:29 ` Changhuang Liang
2023-04-13 2:34 ` Changhuang Liang
2023-04-13 8:41 ` Krzysztof Kozlowski [this message]
2023-04-13 9:02 ` Changhuang Liang
2023-04-16 17:29 ` Krzysztof Kozlowski
2023-04-17 3:37 ` Changhuang Liang
2023-05-04 1:21 ` Changhuang Liang
2023-04-18 18:42 ` Rob Herring
2023-04-18 18:46 ` Rob Herring
2023-04-19 6:10 ` Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 2/3] phy: starfive: Add mipi dphy rx support Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 3/3] riscv: dts: starfive: Add dphy rx node Changhuang Liang
2023-05-22 13:00 ` [PATCH v4 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-05-22 13:11 ` Conor Dooley
2023-05-23 1:02 ` Changhuang Liang
2023-05-23 5:13 ` Conor Dooley
2023-05-23 5:54 ` Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0d82428-aaa5-3dd4-bc29-f1057fe749bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=changhuang.liang@starfivetech.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).