From: Krzysztof Kozlowski <krzk@kernel.org>
To: Markus Schneider-Pargmann <msp@baylibre.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: Vibhore Vardhan <vibhore@ti.com>,
Kevin Hilman <khilman@baylibre.com>, Dhruva Gole <d-gole@ti.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: ti, sci: Add property for partial-io-wakeup-sources
Date: Tue, 6 Aug 2024 08:18:01 +0200 [thread overview]
Message-ID: <f0f60af7-8561-433a-a027-811015fc5e16@kernel.org> (raw)
In-Reply-To: <20240729080101.3859701-2-msp@baylibre.com>
On 29/07/2024 10:00, Markus Schneider-Pargmann wrote:
> Partial-IO is a very low power mode in which nearly everything is
> powered off. Only pins of a few hardware units are kept sensitive and
> are capable to wakeup the SoC. The device nodes are marked as
> 'wakeup-source' but so are a lot of other device nodes as well that are
> not able to do a wakeup from Partial-IO. This creates the need to
> describe the device nodes that are capable of wakeup from Partial-IO.
>
> This patch adds a property with a list of these nodes defining which
> devices can be used as wakeup sources in Partial-IO.
>
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-06 6:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 8:00 [PATCH v2 0/6] firmware: ti_sci: Partial-IO support Markus Schneider-Pargmann
2024-07-29 8:00 ` [PATCH v2 1/6] dt-bindings: ti, sci: Add property for partial-io-wakeup-sources Markus Schneider-Pargmann
2024-08-06 6:18 ` Krzysztof Kozlowski [this message]
2024-08-06 7:11 ` Markus Schneider-Pargmann
2024-08-06 8:03 ` Krzysztof Kozlowski
2024-09-05 9:08 ` Markus Schneider-Pargmann
2024-09-05 9:15 ` Krzysztof Kozlowski
2024-09-05 9:25 ` Krzysztof Kozlowski
2024-09-05 9:49 ` Markus Schneider-Pargmann
2024-09-05 10:41 ` Krzysztof Kozlowski
2024-09-05 11:17 ` Markus Schneider-Pargmann
2024-09-05 11:41 ` Krzysztof Kozlowski
2024-09-27 9:35 ` Markus Schneider-Pargmann
2024-09-28 12:13 ` Krzysztof Kozlowski
2024-07-29 8:00 ` [PATCH v2 2/6] firmware: ti_sci: Partial-IO support Markus Schneider-Pargmann
2024-07-30 12:28 ` Nishanth Menon
2024-07-30 13:01 ` Markus Schneider-Pargmann
2024-07-30 15:07 ` Nishanth Menon
2024-07-31 12:36 ` Markus Schneider-Pargmann
2024-07-31 13:01 ` Nishanth Menon
2024-07-30 15:12 ` Andrew Davis
2024-07-30 15:22 ` Nishanth Menon
2024-08-06 6:26 ` Krzysztof Kozlowski
2024-08-06 7:19 ` Markus Schneider-Pargmann
2024-08-06 8:50 ` Krzysztof Kozlowski
2024-07-29 8:00 ` [PATCH v2 3/6] arm64: dts: ti: k3-pinctrl: Add WKUP_EN flag Markus Schneider-Pargmann
2024-07-30 12:09 ` Nishanth Menon
2024-07-30 12:32 ` Markus Schneider-Pargmann
2024-07-30 12:37 ` Nishanth Menon
2024-08-06 6:28 ` Krzysztof Kozlowski
2024-07-29 8:00 ` [PATCH v2 4/6] arm64: dts: ti: k3-am62: Add partial-io wakeup sources Markus Schneider-Pargmann
2024-07-29 8:01 ` [PATCH v2 5/6] arm64: dts: ti: k3-am62a: " Markus Schneider-Pargmann
2024-07-29 8:01 ` [PATCH v2 6/6] arm64: dts: ti: k3-am62p: " Markus Schneider-Pargmann
2024-08-06 6:18 ` [PATCH v2 0/6] firmware: ti_sci: Partial-IO support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f60af7-8561-433a-a027-811015fc5e16@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vibhore@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).