From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B15C433FE for ; Wed, 30 Nov 2022 14:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbiK3OTm (ORCPT ); Wed, 30 Nov 2022 09:19:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiK3OTl (ORCPT ); Wed, 30 Nov 2022 09:19:41 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25F8F4EC30 for ; Wed, 30 Nov 2022 06:19:40 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id z24so21035519ljn.4 for ; Wed, 30 Nov 2022 06:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AyScXnxFfxE24p36q1hJ+oZNMxvQckw7RZl7GmCoGro=; b=Q5fQyxRxJadMtMT8lfpY846f+mk3m+LAQ7EVCIu0KRuw03/rcZYEkMt6nDOg6M4vQ4 uKFQ6ajZmn4x/cdM+Cl9myEBsjvjJH/qZU/opZCPQf/ZJbqBnExsYkCjf0AEEjZt/hNP UglJZtO4VUA3Uej0ojjhTLha0NfwwC62yfE/osbIBonsES/+wqNMX8noBbMDljDH6E6Q bQeYOjuc/vHbLw8QylzlAtnkzMdyUZ6YdCJWBuf0jjak4fLRcR9STEW5PNmeyop+VWM6 9p5Rs7O9RbmwwiW3MXARlTsS94VToCzx4tcSRaOHl8OssNgzKLSJw+NE8T2LzXoPb1Bu Uw8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AyScXnxFfxE24p36q1hJ+oZNMxvQckw7RZl7GmCoGro=; b=QC7CjLxwSwbMMTKcCYWYpz+jquRkAtDngkAeJrBIYtP+DYuqOy55eQBSLZUHsb/mm2 NYX7YUjRejBy+tgFQGLw1qvoSF8k93NWbCWLoCcgJx+iYxtyLMwyrHaWsnmrt00dG/Pb rNDFw4Y+pUebYl7fKM3tLSJbjmi3+kFTV7S8/yX2SnNel6klCf16Vw+Rx5s5QzW+EV9b FFj9vPRLLvLfV6FmqaKSq3tWfY/rLxzrTImmXgjHVyRW5WIUPeaojFLl8gnT/yi7WlGM zmkEgaXWGADBGL9bD3OV+4U60T4wC5Ia+hYoLaiJHIid/nPb/JBsGtXWazoylaFFCahP sQxQ== X-Gm-Message-State: ANoB5pm5JpFiT0VNrgGotjI/AsB0F+/2cVGd2KWOFSueJ2f2rl58DCWf HlvtodYP8MUtQQc0PWqPV+CteA== X-Google-Smtp-Source: AA0mqf6IsejNi9xqYexLJpi1Obsy+wm3B/MFOlYgieClosKGVhxkQoDsC6Y4EoO5U4KwcWyGO31b6g== X-Received: by 2002:a2e:844d:0:b0:279:c1cd:5177 with SMTP id u13-20020a2e844d000000b00279c1cd5177mr1649954ljh.357.1669817978463; Wed, 30 Nov 2022 06:19:38 -0800 (PST) Received: from [192.168.1.101] (95.49.125.236.neoplus.adsl.tpnet.pl. [95.49.125.236]) by smtp.gmail.com with ESMTPSA id x34-20020a056512132200b0048afb8b8e53sm273719lfu.80.2022.11.30.06.19.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 06:19:33 -0800 (PST) Message-ID: Date: Wed, 30 Nov 2022 15:19:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [RESEND PATCH 2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Add NFC Content-Language: en-US To: Luca Weiss , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221128173744.833018-1-luca@z3ntu.xyz> <20221128173744.833018-2-luca@z3ntu.xyz> <3134585.5fSG56mABF@g550jk> From: Konrad Dybcio In-Reply-To: <3134585.5fSG56mABF@g550jk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29.11.2022 19:31, Luca Weiss wrote: > On Dienstag, 29. November 2022 14:29:36 CET Konrad Dybcio wrote: >> On 28.11.2022 18:37, Luca Weiss wrote: >>> Configure the node for the NQ310 chip found on this device, which is >>> compatible with generic nxp-nci-i2c driver. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> RESEND to fix Cc >>> >>> arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts >>> b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts index >>> 2920504461d3..fde93cbcd180 100644 >>> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts >>> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts >>> @@ -63,6 +63,21 @@ touchscreen@48 { >>> >>> }; >>> >>> }; >>> >>> +&i2c_5 { >>> + status = "okay"; >>> + >>> + nfc@28 { >>> + compatible = "nxp,nq310", "nxp,nxp-nci-i2c"; >> >> Unless there was some binding change (that was not emailed to me with >> this email, I only got 2/2), only "nxp,nxp-nci-i2c" and >> "nxp,pn547", "nxp,nxp-nci-i2c" are allowed. > > Yes, I've added the double compatible to the yaml. > https://lore.kernel.org/lkml/20221128173744.833018-1-luca@z3ntu.xyz/ Ok, this looks good then. Reviewed-by: Konrad Dybcio > > I'll try to work on my Cc-script setup, currently it adds the output of > get_maintainers.pl for each patch (and adds all for the cover letter), which > is based on some script I found a while ago online. > > Is there like a recommended way to put all people in Cc for a series, I'm not > aware of anything at least... > > Perhaps I'll look into b4 for sending patches, that seems to have some goodies > there. Check out this reply from Rob Herring here https://lore.kernel.org/lkml/CAL_JsqLubWBr2W3xZPsuPLOGav7CFgBdH=aCfT22F_m0_cx3cQ@mail.gmail.com/ Konrad > > Regards > Luca > >> >> The node looks good though. >> >> Konrad >> >>> + reg = <0x28>; >>> + >>> + interrupt-parent = <&tlmm>; >>> + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>; >>> + >>> + enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>; >>> + firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>; >>> + }; >>> +}; >>> + >>> >>> &pm8953_resin { >>> >>> status = "okay"; >>> linux,code = ; > > > >