From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, thunder.leizhen@huawei.com,
festevam@gmail.com
Subject: Re: [PATCH v3] dt-bindings: leds: Document commonly used LED triggers
Date: Thu, 24 Nov 2022 12:05:19 +0100 [thread overview]
Message-ID: <f13be4fb-da09-cd99-6bf4-03da3da4a64b@linaro.org> (raw)
In-Reply-To: <20221123081112.97150-1-manivannan.sadhasivam@linaro.org>
On 23/11/2022 09:11, Manivannan Sadhasivam wrote:
> This commit documents the LED triggers used commonly in the SoCs. Not
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> all triggers are documented as some of them are very application specific.
> Most of the triggers documented here are currently used in devicetrees
> of many SoCs.
>
> While at it, let's also sort the triggers in ascending order.
>
> Tested-by: Zhen Lei <thunder.leizhen@huawei.com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>
> Changes in v3:
>
> * Rebased on top of v6.1-rc1
> * Added WLAN Rx trigger
> * Added tested tag from Zhen Lei
>
> Changes in v2:
>
> * Added more triggers, fixed the regex
> * Sorted triggers in ascending order
>
> .../devicetree/bindings/leds/common.yaml | 79 ++++++++++++++-----
> 1 file changed, 59 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 3c14a98430e1..0ffed6bcbefd 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -80,26 +80,65 @@ properties:
> $ref: /schemas/types.yaml#/definitions/string
>
> oneOf:
> - - enum:
> - # LED will act as a back-light, controlled by the framebuffer system
> - - backlight
> - # LED will turn on (but for leds-gpio see "default-state" property in
> - # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> - - default-on
> - # LED "double" flashes at a load average based rate
> - - heartbeat
> - # LED indicates disk activity
> - - disk-activity
> - # LED indicates IDE disk activity (deprecated), in new implementations
> - # use "disk-activity"
> - - ide-disk
> - # LED flashes at a fixed, configurable rate
> - - timer
> - # LED alters the brightness for the specified duration with one software
> - # timer (requires "led-pattern" property)
> - - pattern
> - # LED is triggered by SD/MMC activity
> - - pattern: "^mmc[0-9]+$"
> + - items:
Why items appeared everywhere? It's not explained in commit msg and you
do not have multiple items.
> + - enum:
> + # LED indicates mic mute state
> + - audio-micmute
> + # LED indicates audio mute state
> + - audio-mute
> + # LED will act as a back-light, controlled by the framebuffer system
> + - backlight
> + # LED indicates bluetooth power state
> + - bluetooth-power
> + # LED indicates activity of all CPUs
> + - cpu
> + # LED will turn on (but for leds-gpio see "default-state" property in
> + # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> + - default-on
> + # LED indicates disk activity
> + - disk-activity
> + # LED indicates disk read activity
> + - disk-read
> + # LED indicates disk write activity
> + - disk-write
> + # LED indicates camera flash state
> + - flash
> + # LED "double" flashes at a load average based rate
> + - heartbeat
> + # LED indicates IDE disk activity (deprecated), in new implementations
> + # use "disk-activity"
> + - ide-disk
> + # LED indicates MTD memory activity
> + - mtd
> + # LED indicates NAND memory activity (deprecated),
> + # in new implementations use "mtd"
> + - nand-disk
> + # No trigger assigned to the LED. This is the default mode
> + # if trigger is absent
> + - none
> + # LED alters the brightness for the specified duration with one software
> + # timer (requires "led-pattern" property)
> + - pattern
> + # LED flashes at a fixed, configurable rate
> + - timer
> + # LED indicates camera torch state
> + - torch
> + # LED indicates USB gadget activity
> + - usb-gadget
> + # LED indicates USB host activity
> + - usb-host
Split sorting from adding new patterns - it's not possible to judge what
was here and what is new.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-24 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 8:11 [PATCH v3] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
2022-11-24 11:05 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13be4fb-da09-cd99-6bf4-03da3da4a64b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=festevam@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).