From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F4DCC4321E for ; Thu, 24 Nov 2022 11:05:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbiKXLFY (ORCPT ); Thu, 24 Nov 2022 06:05:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229885AbiKXLFX (ORCPT ); Thu, 24 Nov 2022 06:05:23 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F74B5C0D4 for ; Thu, 24 Nov 2022 03:05:22 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id q7so1584848ljp.9 for ; Thu, 24 Nov 2022 03:05:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rn8gRLitU2bG8xUrjjRIZNkoRWyZ8WxzPo3QWmnRYPU=; b=u8Yf2nhT5P01RksVG/fGGyze9h2f2xrgksiQwhkf3Ah2IaTC02jmSu5JmhHIRz4rGu gFz0/Nawz5pSTpdaCFkfN+t7IK3wES1itdY+MXklXKvNJJAV3qhf/gVM1vkZPc6P0/pv Qh3ybrOhg+fW2idYfu81USNxr90HGPDmVfUGJROV/dlUHQFq4azr3giM9sn6CBHEvv0f t7mxrZuL9uvqPe9yzy2Eoh1tzqPSswtQQ9GdZdWI8Nzf4HqxTiodbrb0Datp3WMl64zT IL/xBtaHUDRfyGcofxtbPkBR1VR0zZ+M5mzfcrN3V8zEHPYlYA+UUMLMq7LYnExsww/T E/rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rn8gRLitU2bG8xUrjjRIZNkoRWyZ8WxzPo3QWmnRYPU=; b=4ClsG6IaFeMVas65U8d0MEDXEvoktJfdDRUoiLiO//Avo9x9kg+RKyDebSJMj+yJp6 aXANbduAjGJBNN9/mX8bxillrfXp0mTXo41syASbCBsLy9NHyBJBGkla//WeJ/7jja/L MN3JkUVOFS5qkBvthHsXYrudWgKdgOBnv9vXVTbVBuiqP3zLcfO7kMULpQnvYhtDqraE k5yTzNuyyBy7YePEkGW+sW2n97hN966PDZBjqAYwhfo5eJOtRZdVX2x4CKOtuObmivDV MeIALALjWFTh3poYW1i+nYO6T5kXSO49bpdI9guggjv4SdjqLkG58VMpzRt3M5sVdPF5 fI7g== X-Gm-Message-State: ANoB5pnpQDddTvkX/JODLqvN1TKJo92j8Gj9mI7RkJtde3O7PuUuKUfw aZYU3rIfst38mQ4OGDgPTNDKQg== X-Google-Smtp-Source: AA0mqf6KCtKkTcJv0a7dnVOBWz4yFZ7Dni3PjZVdF2bhA4Fvpn7bpSDWU7lOxYyMprZ4p7eDtkrl6A== X-Received: by 2002:a05:651c:50b:b0:26c:5db6:cd84 with SMTP id o11-20020a05651c050b00b0026c5db6cd84mr4791835ljp.114.1669287920605; Thu, 24 Nov 2022 03:05:20 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id g7-20020a0565123b8700b00494978b0caesm84019lfv.276.2022.11.24.03.05.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Nov 2022 03:05:20 -0800 (PST) Message-ID: Date: Thu, 24 Nov 2022 12:05:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3] dt-bindings: leds: Document commonly used LED triggers Content-Language: en-US To: Manivannan Sadhasivam , jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, thunder.leizhen@huawei.com, festevam@gmail.com References: <20221123081112.97150-1-manivannan.sadhasivam@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221123081112.97150-1-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/11/2022 09:11, Manivannan Sadhasivam wrote: > This commit documents the LED triggers used commonly in the SoCs. Not Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > all triggers are documented as some of them are very application specific. > Most of the triggers documented here are currently used in devicetrees > of many SoCs. > > While at it, let's also sort the triggers in ascending order. > > Tested-by: Zhen Lei > Signed-off-by: Manivannan Sadhasivam > --- > > Changes in v3: > > * Rebased on top of v6.1-rc1 > * Added WLAN Rx trigger > * Added tested tag from Zhen Lei > > Changes in v2: > > * Added more triggers, fixed the regex > * Sorted triggers in ascending order > > .../devicetree/bindings/leds/common.yaml | 79 ++++++++++++++----- > 1 file changed, 59 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > index 3c14a98430e1..0ffed6bcbefd 100644 > --- a/Documentation/devicetree/bindings/leds/common.yaml > +++ b/Documentation/devicetree/bindings/leds/common.yaml > @@ -80,26 +80,65 @@ properties: > $ref: /schemas/types.yaml#/definitions/string > > oneOf: > - - enum: > - # LED will act as a back-light, controlled by the framebuffer system > - - backlight > - # LED will turn on (but for leds-gpio see "default-state" property in > - # Documentation/devicetree/bindings/leds/leds-gpio.yaml) > - - default-on > - # LED "double" flashes at a load average based rate > - - heartbeat > - # LED indicates disk activity > - - disk-activity > - # LED indicates IDE disk activity (deprecated), in new implementations > - # use "disk-activity" > - - ide-disk > - # LED flashes at a fixed, configurable rate > - - timer > - # LED alters the brightness for the specified duration with one software > - # timer (requires "led-pattern" property) > - - pattern > - # LED is triggered by SD/MMC activity > - - pattern: "^mmc[0-9]+$" > + - items: Why items appeared everywhere? It's not explained in commit msg and you do not have multiple items. > + - enum: > + # LED indicates mic mute state > + - audio-micmute > + # LED indicates audio mute state > + - audio-mute > + # LED will act as a back-light, controlled by the framebuffer system > + - backlight > + # LED indicates bluetooth power state > + - bluetooth-power > + # LED indicates activity of all CPUs > + - cpu > + # LED will turn on (but for leds-gpio see "default-state" property in > + # Documentation/devicetree/bindings/leds/leds-gpio.yaml) > + - default-on > + # LED indicates disk activity > + - disk-activity > + # LED indicates disk read activity > + - disk-read > + # LED indicates disk write activity > + - disk-write > + # LED indicates camera flash state > + - flash > + # LED "double" flashes at a load average based rate > + - heartbeat > + # LED indicates IDE disk activity (deprecated), in new implementations > + # use "disk-activity" > + - ide-disk > + # LED indicates MTD memory activity > + - mtd > + # LED indicates NAND memory activity (deprecated), > + # in new implementations use "mtd" > + - nand-disk > + # No trigger assigned to the LED. This is the default mode > + # if trigger is absent > + - none > + # LED alters the brightness for the specified duration with one software > + # timer (requires "led-pattern" property) > + - pattern > + # LED flashes at a fixed, configurable rate > + - timer > + # LED indicates camera torch state > + - torch > + # LED indicates USB gadget activity > + - usb-gadget > + # LED indicates USB host activity > + - usb-host Split sorting from adding new patterns - it's not possible to judge what was here and what is new. Best regards, Krzysztof