public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger
Date: Mon, 3 Mar 2025 09:24:53 +0100	[thread overview]
Message-ID: <f15fe8bf-1114-416c-8a3a-a0addcb0d5a7@kernel.org> (raw)
In-Reply-To: <CAPVz0n2+=m93MXNV-0Lvu5OQzquNSyV2EBRQPDEnpSw-AZFo+g@mail.gmail.com>

On 03/03/2025 09:20, Svyatoslav Ryhel wrote:
> пн, 3 бер. 2025 р. о 10:18 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>
>> On 03/03/2025 09:11, Svyatoslav Ryhel wrote:
>>> пн, 3 бер. 2025 р. о 09:54 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>>>
>>>> On 27/02/2025 11:55, Svyatoslav Ryhel wrote:
>>>>>>> +
>>>>
>>>> Please kindly trim the replies from unnecessary context. It makes it
>>>> much easier to find new content.
>>>>
>>>>>>> +  maxim,usb-in-current-limit-microamp:
>>>>>>> +    description:
>>>>>>> +      USB Input current limit
>>>>>>> +    minimum: 100000
>>>>>>> +    default: 500000
>>>>>>> +    maximum: 1500000
>>>>>>> +
>>>>>>> +  maxim,ac-in-current-limit-microamp:
>>>>>>> +    description:
>>>>>>> +      AC Input current limit
>>>>>>> +    minimum: 100000
>>>>>>> +    default: 500000
>>>>>>> +    maximum: 1500000
>>>>>>
>>>>>> Half of these properties as well are not suitable and duplicate existing
>>>>>> sysfs interface.
>>>>>>
>>>>>
>>>>> All these properties allow configure the charger to suit the device on
>>>>> which it is used. None of them are required but are a nice addition.
>>>>> Why you are denying me an ability to fully utilize hardware I have and
>>>>> tune it to the device? All those values represent hardware registers
>>>>> which can be customized for the device, not for the end user to mess
>>>>> with.
>>>>
>>>> Because you put user-space choice or OS policy into the DT and DT is not
>>>> for that.
>>>>
>>>
>>> Those are NOT user-space choice or OS policy those are vendor
>>> configuration for a specific device and are NOT and NEVER were exposed
>>
>> Then look at existing devices. We had these discussions in the past and
>> these are usually exposed to user-space.
>>
> 
> Provide an example, where there is same or similar configuration.

If you tried even a bit, you would easily find them by grep for
timer/hours/minutes.

You do not even try but put this work on maintainer.

Do the homework and try a bit harder instead of pushing this on me.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger
Date: Mon, 3 Mar 2025 09:24:53 +0100	[thread overview]
Message-ID: <f15fe8bf-1114-416c-8a3a-a0addcb0d5a7@kernel.org> (raw)
Message-ID: <20250303082453.Nu6yyVJbQhxeXFkm3eerxnxOSbUsFDcez-6CDqi5T28@z> (raw)
In-Reply-To: <CAPVz0n2+=m93MXNV-0Lvu5OQzquNSyV2EBRQPDEnpSw-AZFo+g@mail.gmail.com>

On 03/03/2025 09:20, Svyatoslav Ryhel wrote:
> пн, 3 бер. 2025 р. о 10:18 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>
>> On 03/03/2025 09:11, Svyatoslav Ryhel wrote:
>>> пн, 3 бер. 2025 р. о 09:54 Krzysztof Kozlowski <krzk@kernel.org> пише:
>>>>
>>>> On 27/02/2025 11:55, Svyatoslav Ryhel wrote:
>>>>>>> +
>>>>
>>>> Please kindly trim the replies from unnecessary context. It makes it
>>>> much easier to find new content.
>>>>
>>>>>>> +  maxim,usb-in-current-limit-microamp:
>>>>>>> +    description:
>>>>>>> +      USB Input current limit
>>>>>>> +    minimum: 100000
>>>>>>> +    default: 500000
>>>>>>> +    maximum: 1500000
>>>>>>> +
>>>>>>> +  maxim,ac-in-current-limit-microamp:
>>>>>>> +    description:
>>>>>>> +      AC Input current limit
>>>>>>> +    minimum: 100000
>>>>>>> +    default: 500000
>>>>>>> +    maximum: 1500000
>>>>>>
>>>>>> Half of these properties as well are not suitable and duplicate existing
>>>>>> sysfs interface.
>>>>>>
>>>>>
>>>>> All these properties allow configure the charger to suit the device on
>>>>> which it is used. None of them are required but are a nice addition

  reply	other threads:[~2025-03-03  8:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26  9:36 [PATCH v2 0/2] power: supply: Add support for Maxim MAX8971 charger Svyatoslav Ryhel
2025-02-26  9:36 ` [PATCH v2 1/2] dt-bindings: power: supply: Document " Svyatoslav Ryhel
2025-02-27 10:45   ` Krzysztof Kozlowski
2025-02-27 10:55     ` Svyatoslav Ryhel
2025-03-03  7:54       ` Krzysztof Kozlowski
2025-03-03  8:11         ` Svyatoslav Ryhel
2025-03-03  8:18           ` Krzysztof Kozlowski
2025-03-03  8:20             ` Svyatoslav Ryhel
2025-03-03  8:24               ` Krzysztof Kozlowski [this message]
2025-03-03  8:24                 ` Krzysztof Kozlowski
2025-02-27 11:03     ` Svyatoslav Ryhel
2025-03-03  7:52       ` Krzysztof Kozlowski
2025-03-03  8:13         ` Svyatoslav Ryhel
2025-03-03  8:23           ` Krzysztof Kozlowski
2025-02-26  9:37 ` [PATCH v2 2/2] power: supply: Add support for " Svyatoslav Ryhel
2025-02-27 14:18   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f15fe8bf-1114-416c-8a3a-a0addcb0d5a7@kernel.org \
    --to=krzk@kernel.org \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox