From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF47DC54EAA for ; Mon, 30 Jan 2023 10:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235351AbjA3KlU (ORCPT ); Mon, 30 Jan 2023 05:41:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235524AbjA3KlS (ORCPT ); Mon, 30 Jan 2023 05:41:18 -0500 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C630031E09 for ; Mon, 30 Jan 2023 02:41:16 -0800 (PST) Received: by mail-ej1-x62a.google.com with SMTP id ml19so6857582ejb.0 for ; Mon, 30 Jan 2023 02:41:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=97/znp2230QJNhFIapyUFDHAE778/+RAJ0xxz1nk3/E=; b=GjYICRrne9CSOAg6uWRCmWyly6EbzYEqX4ldhGUQKU0osjgMim1E5WJ483fuvzOu6F s6Z5edpSdFy/NjdFzO5SAp6s22pVwv3RFqODmDDfH/8R43lTBms9PHUnmAF5I5GfwHh3 VCDXI/7EvNW3cYs3gpXypkqirWAPOk2gIAeDzYOXi/yIp5DgKCideyDn2lT1iAC2tPhO QOC1HvzynFgSs86RfexQWZUTKn9/J6bM3nXfY9yTnRDTYdwFafrNBpbc82pqPzJiYsJg 8AWE4Totx+ehOM/x4ibysnsOTFHycGjMLmpMiWq94N/0eCka0rk50y0fbcWtpCRW4mC6 qFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=97/znp2230QJNhFIapyUFDHAE778/+RAJ0xxz1nk3/E=; b=JXxtA3oiiH0BFI97achqdZYj9FyMb6wmO6J/NN3nQ3rCXf0S0IuCQza+iJh9CBkziR CML+thXlZbpuEY10kwPTX6RA9zQw0gkOnYdtvMytSq2gjhkhrTrTyAFnQcRlUCBNjUPa ItUR5Wxzikh2CqTGv1D9MROca+S7Gd/vnhoypWOWuvho27tqEI9S22U6G6pT8jC8KScm 9u0xw4wJm7WoE4XBCl8LngVHkgP5cXTWTqiBiecHmtB/ZYtiSU3+pwBdzoVSi7JDhPF3 bLMU5V0x4lXdUyY5FuMXKM/Pp8dDacD97Ctct/MlpdTxqvPovNMcHTftWjxKUi3f7T4K oHzQ== X-Gm-Message-State: AO0yUKWOEdz9rOcD2VMCmVJ7fvzx3TdoNaTAzAfQRrsnEFXyzWNVpKcv Lt+q8oCsO8rkNmoy9SHE9Y3Ywg== X-Google-Smtp-Source: AK7set9JxzzkgOcPgM3MNIcB9kqa35FeLk0/0bFeqnLVmtL4mvZ093dlX4S9Eu+v5FgZuWA0wAXiBQ== X-Received: by 2002:a17:906:5ace:b0:88a:7408:384c with SMTP id x14-20020a1709065ace00b0088a7408384cmr929296ejs.47.1675075275384; Mon, 30 Jan 2023 02:41:15 -0800 (PST) Received: from [192.168.1.101] (abyl20.neoplus.adsl.tpnet.pl. [83.9.31.20]) by smtp.gmail.com with ESMTPSA id i4-20020a170906264400b0084d35ffbc20sm6670053ejc.68.2023.01.30.02.41.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 02:41:15 -0800 (PST) Message-ID: Date: Mon, 30 Jan 2023 11:41:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 6/7] arm64: dts: qcom: sm8550-mtp: add pmic glink node Content-Language: en-US To: Neil Armstrong , Heikki Krogerus , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-6-0b0acfad301e@linaro.org> From: Konrad Dybcio In-Reply-To: <20230130-topic-sm8450-upstream-pmic-glink-v1-6-0b0acfad301e@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30.01.2023 10:54, Neil Armstrong wrote: > Add the pmic glink node linked with the DWC3 USB controller > switched to OTG mode and tagged with usb-role-switch. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 34 ++++++++++++++++++++++++++++++++- > 1 file changed, 33 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 725d3bc3ee72..f054c11fe1f6 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -27,6 +27,31 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + pmic-glink { > + compatible = "qcom,sm8450-pmic-glink", 8550? Otherwise same comments as for the previous patch Konrad "qcom,pmic-glink"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + power-role = "dual"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + pmic_glink_dwc3_in: endpoint { > + remote-endpoint = <&usb_1_dwc3_out>; > + }; > + }; > + }; > + }; > + }; > + > vph_pwr: vph-pwr-regulator { > compatible = "regulator-fixed"; > regulator-name = "vph_pwr"; > @@ -546,7 +571,14 @@ &usb_1 { > }; > > &usb_1_dwc3 { > - dr_mode = "peripheral"; > + dr_mode = "otg"; > + usb-role-switch; > + > + port { > + usb_1_dwc3_out: endpoint { > + remote-endpoint = <&pmic_glink_dwc3_in>; > + }; > + }; > }; > > &usb_1_hsphy { >