From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v3 2/2] ARM: dts: tegra20: Add video decoder node Date: Thu, 12 Oct 2017 09:49:04 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko , Thierry Reding , Greg Kroah-Hartman , Rob Herring , Mauro Carvalho Chehab , Stephen Warren Cc: Dan Carpenter , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 11/10/17 21:08, Dmitry Osipenko wrote: > Add a device node for the video decoder engine found on Tegra20. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra20.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > index 7c85f97f72ea..1b5d54b6c0cb 100644 > --- a/arch/arm/boot/dts/tegra20.dtsi > +++ b/arch/arm/boot/dts/tegra20.dtsi > @@ -249,6 +249,23 @@ > */ > }; > > + vde@6001a000 { > + compatible = "nvidia,tegra20-vde"; > + reg = <0x6001a000 0x3D00 /* VDE registers */ > + 0x40000400 0x3FC00>; /* IRAM region */ > + reg-names = "regs", "iram"; > + interrupts = , /* UCQ error interrupt */ > + , /* Sync token interrupt */ > + , /* BSE-V interrupt */ > + , /* BSE-A interrupt */ > + ; /* SXE interrupt */ > + interrupt-names = "ucq-error", "sync-token", "bsev", "bsea", "sxe"; > + clocks = <&tegra_car TEGRA20_CLK_VDE>; > + clock-names = "vde"; > + resets = <&tegra_car 61>; > + reset-names = "vde"; > + }; > + I don't see any binding documentation for this node. We need to make sure we add this. Jon -- nvpublic