From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03BEFC4332F for ; Wed, 2 Nov 2022 16:50:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232133AbiKBQuC (ORCPT ); Wed, 2 Nov 2022 12:50:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbiKBQtq (ORCPT ); Wed, 2 Nov 2022 12:49:46 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F0AB6253 for ; Wed, 2 Nov 2022 09:48:57 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id l9so12104056qkk.11 for ; Wed, 02 Nov 2022 09:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uD30lAoArCayIjKDZVlL5ocMenNCJJq05otGcDZLCH8=; b=zV8hhjYdbwHNiuh7M2h2tIRAFiosB9FrHDQ8qgjUuOpSzPQbfe4YhTNLXOps33072i vPr6OGhsDK6pjD2bmauzBU3N1bf3DKQ4krKgAghhcQChr/j/TEBm+cNcYPQplEZmtsgS MjtLD+wuijOdHRRalmyiqf3BBOV/cmxj6YXGyDUUrPAAZ2acn+eP4E2RwlhpVhoZzL0f DI9E5YnUtPK3ddkozWRaj8YerG0Edb7IQD6EJVGmUHRBo/gzfQOHVt8saSUaFSuuD8rk D/O3cFI4il8BU+lVZsMf+Dp5Ne3CzR3FcV7GYP2qv5NaRrJuX9t0dPTDQLxw38Dt84yl hmZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uD30lAoArCayIjKDZVlL5ocMenNCJJq05otGcDZLCH8=; b=v4jtvyp/bNOKqkQTkk6fMGmlc7qxJX7BgCS8CtcpWLMoExQ3dMvUo6S5DVQbQhwdeR Bg+oOyUZkJ62r7PFYzGRoQ35V5nEujAWtNS5BvDd3BcUt5NEcGI7oeCeHqTQ/bbD6uLM OiCJ56X0idx6H+anWyyIB1B0U9qyAt4kISyUepFe1U2px2oEKAS6WNZaXgQq34j8lH9h dj0pMLcdr9PwlclBBcS0HujvWhKFZLYf0GiZ5+ZxQC/D1cDznR5yFDE+rrwjFx18TbPt mLXGNXFRaplIiUVA5aXn7ZxYhxKjBnpR8FM4FsOOpZDA5GlWcaZbQmzsLqR51yh7hzUW nSLg== X-Gm-Message-State: ACrzQf1wtnvJdi5K+yHEXJ0zN+dhp5FkDxUSiU5fRNgbIx6gvTt9Pjii D6XVM+zzh6F0zsLDjJEbDAF9NCi2Yk5NEw== X-Google-Smtp-Source: AMsMyM7PzDCe2M/7OY5FK0VrVkM/8arnKOiYqHWjZB9+WRh5VmLBtqEycnm+UfJPynJ7cCkD4hsFOw== X-Received: by 2002:a05:620a:986:b0:6fa:3c74:e97f with SMTP id x6-20020a05620a098600b006fa3c74e97fmr9687890qkx.246.1667407736476; Wed, 02 Nov 2022 09:48:56 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:28d9:4790:bc16:cc93? ([2601:586:5000:570:28d9:4790:bc16:cc93]) by smtp.gmail.com with ESMTPSA id x18-20020a05620a259200b006bc192d277csm8942567qko.10.2022.11.02.09.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 09:48:55 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 12:48:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 4/4] arm64: dts: uniphier: Add NX1 SoC and boards support Content-Language: en-US To: Kunihiko Hayashi , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Olof Johansson , Masami Hiramatsu Cc: soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221027045157.23325-1-hayashi.kunihiko@socionext.com> <20221027045157.23325-5-hayashi.kunihiko@socionext.com> <54206dca-0583-88c0-9924-a80dfaf0ba94@socionext.com> From: Krzysztof Kozlowski In-Reply-To: <54206dca-0583-88c0-9924-a80dfaf0ba94@socionext.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/11/2022 05:02, Kunihiko Hayashi wrote: > Hi Krzysztof, > >>> + compatible = "socionext,uniphier-nx1-clock"; >>> + #clock-cells = <1>; >>> + }; >>> + >>> + sys_rst: reset { >> >> reset-controller >> >>> + compatible = "socionext,uniphier-nx1-reset"; >>> + #reset-cells = <1>; >>> + }; >>> + >>> + watchdog { >>> + compatible = "socionext,uniphier-wdt"; >>> + }; >>> + >>> + pvtctl: thermal-sensor { >>> + compatible = "socionext,uniphier-nx1-thermal"; >>> + interrupts = ; >>> + #thermal-sensor-cells = <0>; >>> + socionext,tmod-calibration = <0x0f22 0x68ee>; >>> + }; >>> + }; >>> + >>> + spi0: spi@14006000 { >>> + compatible = "socionext,uniphier-scssi"; >>> + status = "disabled"; >>> + reg = <0x14006000 0x100>; >> >> Reg is second property. Status goes last. The same in other nodes. > > Hmm, I've put "status" here according to the existing (uniphier's) DT policy > and this should rewrite the policy. Is there documentation somewhere that > recommends the order? Or, should I refer to previous comments? Hm, your decision (as arch maintainer) is then preferred, not mine. Although it is quite unusual to find status, not reg, as the second property. compatible followed by reg is not documented anywhere, it's just the most used style. And actually most sensible as it answers to questions from highest importance to lowest: 1. What is this device? compatible 2. Where is it? Does it match unit address? reg 3. all other properties 4. Is it off or on? status as optional property Best regards, Krzysztof