From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB37C6379F for ; Thu, 23 Feb 2023 07:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233324AbjBWH7I (ORCPT ); Thu, 23 Feb 2023 02:59:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230356AbjBWH7I (ORCPT ); Thu, 23 Feb 2023 02:59:08 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3210F1A4A6; Wed, 22 Feb 2023 23:59:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DBC6EB818F2; Thu, 23 Feb 2023 07:59:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51339C4339B; Thu, 23 Feb 2023 07:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677139142; bh=hhUhD+GQIDGu4qZjQp3HxpY6cANDAYNuHS1oWM0ZPlM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OPAwjxfVt3BWAo8pRpkfdmFfsBnQ+4B4vRmL95IgBBE+Jwxz66RsUbpLkDv1ZmAu/ N9CiOGsyStMaLBXrAb3eQQsJjM5lsfW102cwA3Xxw9WoA0KNI+F5TLzTaeIwZvbWqy 1+ENEmNZ1DZczh5owKalrU6nXVMMOU/T90Obomn5vEsKN3PpmvFEctKOdyrMPOcmTF YUu/lXD7MQg7kH0mo7weC1UYthJqBAZM+rmQEEHkKtcCA+g6JpvOYBRtPeMNNUeZb1 j0s63k7dRIFwJUWhX/qf1To9iNPFnYb2L0yhOlxzbU3LAnm1hAZZmaTXwd23vKRgNm KpMaDBSGv+kmA== Message-ID: Date: Thu, 23 Feb 2023 08:58:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] Mips: ls2k1000: dts: add the display controller device node To: Sui jingfeng , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230222165514.684729-1-suijingfeng@loongson.cn> <32a56a81-e9b5-138b-4dff-35c2525cc0b6@loongson.cn> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <32a56a81-e9b5-138b-4dff-35c2525cc0b6@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/02/2023 04:19, Sui jingfeng wrote: > Hi, > > On 2023/2/23 02:32, Krzysztof Kozlowski wrote: >> On 22/02/2023 17:55, suijingfeng wrote: >>> The display controller is a pci device, it's pci vendor id is >>> 0x0014, it's pci device id is 0x7a06. >>> >>> Signed-off-by: suijingfeng >>> --- >>> .../boot/dts/loongson/loongson64-2k1000.dtsi | 21 +++++++++++++++++++ >>> 1 file changed, 21 insertions(+) >>> >>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>> index 8143a61111e3..a528af3977d9 100644 >>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi >>> @@ -31,6 +31,18 @@ memory@200000 { >>> <0x00000001 0x10000000 0x00000001 0xb0000000>; /* 6912 MB at 4352MB */ >>> }; >>> >>> + reserved-memory { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + ranges; >>> + >>> + display_reserved: framebuffer@30000000 { >>> + compatible = "shared-dma-pool"; >>> + reg = <0x0 0x30000000 0x0 0x04000000>; /* 64M */ >>> + linux,cma-default; >>> + }; >>> + }; >>> + >>> cpu_clk: cpu_clk { >>> #clock-cells = <0>; >>> compatible = "fixed-clock"; >>> @@ -198,6 +210,15 @@ sata@8,0 { >>> interrupt-parent = <&liointc0>; >>> }; >>> >>> + display-controller@6,0 { >>> + compatible = "loongson,ls2k1000-dc"; >>> + >>> + reg = <0x3000 0x0 0x0 0x0 0x0>; >>> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; >>> + interrupt-parent = <&liointc0>; >>> + memory-region = <&display_reserved>; >> NAK. > Err :(,  please give me a chance to explain >> Test your code against the bindings you send. > > I can guarantee to you that I test may code more than twice. The code > used to testing is listed at link [1]. I wrote - test against the bindings. I don't believe that it was tested. Please paste the output of the testing (dtbs_check). > > This patchset  mainly used to illustrate how  we made the driver in [1] > usable on our SoC platform. > >> It's the same >> patchset. You basically send something which the same moment is incorrect. > > Loongson display controller IP has been integrated in both Loongson > North Bridge chipset(ls7a1000 and ls7a2000) and Loongson SoCs(ls2k1000 > and ls2k2000 etc), it even has been included in Loongson BMC(ls2k0500 bmc) > products. I don't understand how your reply here is relevant to incorrect bindings or incorrect DTS according to bindings. Best regards, Krzysztof