From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Crispin Subject: Re: [PATCH 1/2] NET: PHY: Add PHY LED control binding. Date: Thu, 9 Jun 2016 08:12:08 +0200 Message-ID: References: <1465163150-21429-1-git-send-email-hauke@hauke-m.de> <1465163150-21429-2-git-send-email-hauke@hauke-m.de> <20160608193008.GA20738@rob-hp-laptop> <3869397.kzojzy3Xzu@ws-stein> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3869397.kzojzy3Xzu@ws-stein> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Stein , Rob Herring Cc: Hauke Mehrtens , f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, openwrt-zg6vgJgm1sizQB+pC5nmwQ@public.gmane.org, hauke.mehrtens-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, daniel.schwierzeck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, eckert.florian-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, thomas.langer-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org On 09/06/2016 08:06, Alexander Stein wrote: > On Wednesday 08 June 2016 14:30:08, Rob Herring wrote: >>> diff --git a/Documentation/devicetree/bindings/phy/phy-leds.txt >>> b/Documentation/devicetree/bindings/phy/phy-leds.txt new file mode 100644 >>> index 0000000..1a35e3d >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/phy-leds.txt >>> @@ -0,0 +1,52 @@ >>> +LED configuration for Ethernet phys >>> + >>> +All these properties are optional, not all properties are supported by >>> +all PHYs. When more then one property name is define for one LED the >>> +order they get applied is device depended. >>> +Property names: >>> + led-const-on: conditions the LED should be constant on >>> + led-pulse: condition the LED should be pulsed on >>> + led-blink-slow: condition the LED should slowly blink >> >> How slow is slow? > > This depends on the MMD.INTERNAL.LEDCH.SBF setting which is 2 Hz by default. > >>> + led-blink-fast: condition the LED should fast blink >> >> How fast is fast? > > This depends on the MMD.INTERNAL.LEDCH.FBF setting which is 16 Hz by default. > > Both can be set independently to 2, 4, 8 or 16 Hz. > and both are intel/lantiq implementation specific and hence should not be part of a generic led-phy binding. imho these leds should be exposed via a led driver and the configurtion should be exposed via a led driver specific trigger, in the same manner in which wireless macs do it. John -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html