Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 05/12/2023 19:47, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> i.MX23 has two LCDIF interrupts instead of a single one like other
> i.MX devices.
> 
> Take this into account for properly describing the i.MX23 LCDIF
> interrupts.
> 
> This fixes the following dt-schema warning:
> 
> imx23-olinuxino.dtb: lcdif@80030000: interrupts: [[46], [45]] is too long
> 	from schema $id: http://devicetree.org/schemas/display/fsl,lcdif.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - Fix typo in commit log (i.MX23 has two LCDIF interrupts).
> 
>  .../devicetree/bindings/display/fsl,lcdif.yaml   | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index fc11ab5fc465..c4228b893766 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -51,7 +51,10 @@ properties:
>      minItems: 1
>  
>    interrupts:
> -    maxItems: 1
> +    items:
> +      - description: LCDIF DMA interrupt
> +      - description: LCDIF Error interrupt
> +    minItems: 1
>  
>    power-domains:
>      maxItems: 1
> @@ -131,6 +134,17 @@ allOf:
>      then:
>        required:
>          - power-domains
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx23-lcdif
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 2
> +          maxItems: 2

Either missing else: or update of other variants to limit interrupts to 1.

Best regards,
Krzysztof