From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Peter Meerwald-Stadler
<pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] DT/bindings: Add bindings for TI ADS7950 A/DC chips
Date: Sat, 14 Jan 2017 12:53:35 +0000 [thread overview]
Message-ID: <f1e845c4-7db0-c6fe-fbd2-420902110be9@kernel.org> (raw)
In-Reply-To: <1484157171-15571-2-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
On 11/01/17 17:52, David Lechner wrote:
> This adds device tree bindings for the TI ADS7950 family of A/DC chips.
>
> Signed-off-by: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
This is in of itself good, but we may need to have some deprecated
elements to continue supporting what was implicitly happening with
the missnaming so as to avoid accidentally breaking someone's device
tree.
Jonathan
> ---
> .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
> new file mode 100644
> index 0000000..e77a6f7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
> @@ -0,0 +1,23 @@
> +* Texas Instruments ADS7950 family of A/DC chips
> +
> +Required properties:
> + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952",
> + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957",
> + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961"
> + - reg: SPI chip select number for the device
> + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt
> + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V
> + reference voltage
> +
> +Recommended properties:
> + - spi-max-frequency: Definition as per
> + Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +adc@0 {
> + compatible = "ti,ads7957";
> + reg = <0>;
> + #io-channel-cells = <1>;
> + vref-supply = <&refin_supply>;
> + spi-max-frequency = <10000000>;
> +};
>
next prev parent reply other threads:[~2017-01-14 12:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 17:52 [PATCH 0/3] ti,ads7950 device tree bindings David Lechner
2017-01-11 17:52 ` [PATCH 1/3] DT/bindings: Add bindings for TI ADS7950 A/DC chips David Lechner
[not found] ` <1484157171-15571-2-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-01-14 12:53 ` Jonathan Cameron [this message]
[not found] ` <f1e845c4-7db0-c6fe-fbd2-420902110be9-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-01-14 18:00 ` David Lechner
2017-01-15 13:52 ` Jonathan Cameron
2017-01-18 19:54 ` Rob Herring
2017-01-11 17:52 ` [PATCH 2/3] iio: adc: ti-ads7950: Drop "ti-" prefix from module name David Lechner
[not found] ` <1484157171-15571-3-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-01-14 12:49 ` Jonathan Cameron
2017-01-14 18:07 ` David Lechner
2017-01-15 13:54 ` Jonathan Cameron
2017-01-11 17:52 ` [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" David Lechner
[not found] ` <1484157171-15571-4-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-01-14 12:52 ` Jonathan Cameron
[not found] ` <47d15fe8-85c5-6e1c-cd89-71398ad79def-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-01-14 18:09 ` David Lechner
2017-01-15 13:55 ` Jonathan Cameron
[not found] ` <1484157171-15571-1-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-01-15 13:58 ` [PATCH 0/3] ti,ads7950 device tree bindings Jonathan Cameron
[not found] ` <c4c59921-d0dc-0858-8d66-c56fa38d3b50-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-01-15 23:44 ` David Lechner
[not found] ` <b60edc70-1d0f-fbfc-6ae9-1e6e5e3525d1-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-01-21 15:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e845c4-7db0-c6fe-fbd2-420902110be9@kernel.org \
--to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).