From: Devi Priya <quic_devipriy@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <lee@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <thierry.reding@gmail.com>,
<ndesaulniers@google.com>, <trix@redhat.com>, <baruch@tkos.co.il>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>
Subject: Re: [PATCH V13 4/4] arm64: dts: ipq6018: add pwm node
Date: Wed, 4 Oct 2023 15:15:16 +0530 [thread overview]
Message-ID: <f1e9f12d-5b40-0e08-3b67-94cfb0130bc5@quicinc.com> (raw)
In-Reply-To: <bcc7ba00-8a45-4ba6-8691-6420782054ff@linaro.org>
On 10/4/2023 3:13 PM, Krzysztof Kozlowski wrote:
> On 04/10/2023 11:04, Devi Priya wrote:
>> Describe the PWM block on IPQ6018.
>>
>> The PWM is in the TCSR area. Make &tcsr "simple-mfd" compatible, and add
>> &pwm as child of &tcsr.
>>
>
> ...
>
>> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring)
>>
>> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> index e59b9df96c7e..429ad7cb681c 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
>> @@ -390,8 +390,21 @@ tcsr_mutex: hwlock@1905000 {
>> };
>>
>> tcsr: syscon@1937000 {
>> - compatible = "qcom,tcsr-ipq6018", "syscon";
>> + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd";
>> reg = <0x0 0x01937000 0x0 0x21000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x0 0x01937000 0x21000>;
>
> Please put ranges just after reg.
Sure, okay
>
> With that:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thank you!
Regards,
Devi Priya
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2023-10-04 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 9:04 [PATCH V13 0/4] Add PWM support for IPQ chipsets Devi Priya
2023-10-04 9:04 ` [PATCH V13 1/4] pwm: driver for qualcomm ipq6018 pwm block Devi Priya
2023-10-04 9:04 ` [PATCH V13 2/4] dt-bindings: pwm: add IPQ6018 binding Devi Priya
2023-10-04 9:13 ` Krzysztof Kozlowski
2023-10-04 9:04 ` [PATCH V13 3/4] dt-bindings: mfd: qcom,tcsr: Add simple-mfd support for IPQ6018 Devi Priya
2023-10-04 9:20 ` Krzysztof Kozlowski
2023-10-04 9:23 ` Devi Priya
2023-10-04 9:04 ` [PATCH V13 4/4] arm64: dts: ipq6018: add pwm node Devi Priya
2023-10-04 9:43 ` Krzysztof Kozlowski
2023-10-04 9:45 ` Devi Priya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e9f12d-5b40-0e08-3b67-94cfb0130bc5@quicinc.com \
--to=quic_devipriy@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=baruch@tkos.co.il \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ndesaulniers@google.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).