From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BEECC83F2F for ; Thu, 31 Aug 2023 16:41:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231937AbjHaQlC (ORCPT ); Thu, 31 Aug 2023 12:41:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344381AbjHaQlC (ORCPT ); Thu, 31 Aug 2023 12:41:02 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 008521BF for ; Thu, 31 Aug 2023 09:40:57 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b962535808so19337171fa.0 for ; Thu, 31 Aug 2023 09:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693500055; x=1694104855; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=32VO4iE+9AUaoXKhjN8FGYng4VNGJNxRjuAGulwkX3A=; b=D0/zGLLGmuydeo7/WdPm0BrabT8Evt0zrPhVdb41Jy2q6lUV3r5C66Zhuc4xnOfef9 sgDpb1PjOhmj2mZa8b9Wd3vK5WfYeyFCAbWT62ePCL4AikXNOnFD5lX1COE0RH50OR9D 8omciMzj2qtJ7dKvAh+SPAncTvaJ9VCcHvp6eJDI5GNb+niHEXVKHVMNw3Y9VzHhc+vc LuqG3IrpYEbd9Vfu9bpXwcU4qd4slSU4K6BH9hEW92P8yYiCNBRSJUHFWvfmdzEYVQjt BK5YIRUZdbnRkO7d1jxXzJ5J1+uexcFL/vIEl7BH6dM7KiH6oe+ol8I+VJCpTBlaTtgk VShQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693500055; x=1694104855; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=32VO4iE+9AUaoXKhjN8FGYng4VNGJNxRjuAGulwkX3A=; b=FmPHtsW9CBbKT+h1Z7mkGWrTtt6ajL+ClfWHOtw6AbEMs03BX7cA7caiG8FTtVTG57 CrfAQVJUeM+Oc/O5mKl4a8N8KVltFo1aVzg41jClLDcSlS6f70BIwIULWgNjfXWPw+Io BxkMASwc7Eqagd0S5RJ0rWy/6VRU1kfS0yrWQ7JjU5dZfvwQmdBvV5tsyev//4inhyoG RgwAN7KAl56txSzbvfG8wmzyNIVcNntAeTUIpwm1J2j5CZLjgtb8fBZTON+MpB70gAIm i2ssWKveDcCZ6VwswHpSuVjQ9QGq9fJC2uoWg+zvU1nXUCV9ZhzW4NhjMjZVvHSvDIak q0sA== X-Gm-Message-State: AOJu0YzwKXI5z8QDCFHkQf4dglBFbiBwMYT02ZmTYXne1IVOh6VC8t/k MNT1MmvfCYmcU6fM6wF7r0ol6w== X-Google-Smtp-Source: AGHT+IHEKkqBMsrhr42Vv9weNDnAD6WdXqK5Onb+9zx4IfnsLu7lPJA5n4KeZI7uo9A9Og4Aq9qTcw== X-Received: by 2002:a2e:8e89:0:b0:2bc:fdb9:5bf4 with SMTP id z9-20020a2e8e89000000b002bcfdb95bf4mr4375910ljk.11.1693500055525; Thu, 31 Aug 2023 09:40:55 -0700 (PDT) Received: from [192.168.1.101] (abyk13.neoplus.adsl.tpnet.pl. [83.9.30.13]) by smtp.gmail.com with ESMTPSA id c1-20020a2e9d81000000b002b9b9fd0f92sm378214ljj.105.2023.08.31.09.40.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Aug 2023 09:40:55 -0700 (PDT) Message-ID: Date: Thu, 31 Aug 2023 18:40:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 3/9] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3 driver Content-Language: en-US To: Rob Herring , Ulf Hansson Cc: Krzysztof Kozlowski , AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Viresh Kumar , Nishanth Menon , Stephen Boyd , Niklas Cassel , Liam Girdwood , Mark Brown , Conor Dooley , "Rafael J. Wysocki" , Viresh Kumar , Robert Marko , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Jeffrey Hugo , Marijn Suijten , AngeloGioacchino Del Regno References: <20230217-topic-cpr3h-v14-0-9fd23241493d@linaro.org> <20230217-topic-cpr3h-v14-3-9fd23241493d@linaro.org> <20230831162835.GA2390385-robh@kernel.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20230831162835.GA2390385-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31.08.2023 18:28, Rob Herring wrote: > On Tue, Aug 29, 2023 at 01:01:44PM +0200, Ulf Hansson wrote: >> On Mon, 28 Aug 2023 at 13:42, Konrad Dybcio wrote: >>> >>> From: AngeloGioacchino Del Regno >>> >>> Add the bindings for the CPR3 driver to the documentation. >>> >>> Signed-off-by: AngeloGioacchino Del Regno >>> [Konrad: Make binding check pass; update AGdR's email] >>> Tested-by: Jeffrey Hugo >>> Signed-off-by: Konrad Dybcio >>> --- >>> .../devicetree/bindings/soc/qcom/qcom,cpr3.yaml | 286 +++++++++++++++++++++ >>> 1 file changed, 286 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml >>> new file mode 100644 >>> index 000000000000..acf2e294866b >> >> [...] >> >>> + >>> +examples: >>> + - | >>> + #include >>> + #include >>> + >>> + cpus { >>> + #address-cells = <2>; >>> + #size-cells = <0>; >>> + >>> + cpu@0 { >>> + compatible = "qcom,kryo280"; >>> + device_type = "cpu"; >>> + reg = <0x0 0x0>; >>> + operating-points-v2 = <&cpu0_opp_table>; >>> + power-domains = <&apc_cprh 0>; >>> + power-domain-names = "cprh"; >> >> Rather than using a Qcom specific power-domain-name, perhaps a common >> power-domain-name for cpus, that can be used for "the performance >> domain" would be a good idea here? >> >> I have suggested using "perf" for the SCMI performance domain [1], >> perhaps that description should be extended to cover this and other >> performance domains too? > > Better yet, nothing. There's no value to -names when there is only 1 > entry. As of today, it's required for devm_pm_opp_attach_genpd() Ulf, is there a better way to do this that doesn't require names? Konrad