From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marc Olberding <molberding@nvidia.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: aspeed: Add device tree includes for the cx8 switchboard
Date: Sat, 16 Aug 2025 10:16:06 +0200 [thread overview]
Message-ID: <f1f7d028-0c8c-44b3-9f3b-0830e5571890@kernel.org> (raw)
In-Reply-To: <20250815-mgx4u_devicetree-v1-2-66db6fa5a7e4@nvidia.com>
On 15/08/2025 21:45, Marc Olberding wrote:
> The mgx cx8 switchboard is used to network mgx GPUs
>
> Signed-off-by: Marc Olberding <molberding@nvidia.com>
> ---
> .../dts/aspeed/nvidia-mgx-cx8-switch-north.dtsi | 80 ++++++++++++++++++++++
> .../dts/aspeed/nvidia-mgx-cx8-switch-south.dtsi | 80 ++++++++++++++++++++++
> 2 files changed, 160 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/nvidia-mgx-cx8-switch-north.dtsi b/arch/arm/boot/dts/aspeed/nvidia-mgx-cx8-switch-north.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..051c8cf0b7d12b1fa4c84db896ca480b21627e23
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/nvidia-mgx-cx8-switch-north.dtsi
> @@ -0,0 +1,80 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
Odd license. Since when GPL-3.0 is okay?
> +
> +eeprom@56 {
> + compatible = "atmel,24c128";
> + reg = <0x56>;
> +};
> +
This is some completely misplaced DTSI style. Don't do this...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-16 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 19:45 [PATCH 0/3] Adding device tree and binding for Nvidia mgx cx8 switchboard Marc Olberding
2025-08-15 19:45 ` [PATCH 1/3] dt-bindings: arm: aspeed: Add Nvidia's mgx4u BMC Marc Olberding
2025-08-16 8:15 ` Krzysztof Kozlowski
2025-08-15 19:45 ` [PATCH 2/3] ARM: dts: aspeed: Add device tree includes for the cx8 switchboard Marc Olberding
2025-08-16 8:16 ` Krzysztof Kozlowski [this message]
2025-08-19 19:09 ` Marc Olberding
2025-08-19 19:19 ` Krzysztof Kozlowski
2025-08-15 19:45 ` [PATCH 3/3] ARM: dts: aspeed: Add device tree for mgx4u BMC Marc Olberding
2025-08-16 1:02 ` Andrew Lunn
2025-08-16 8:17 ` Krzysztof Kozlowski
2025-08-15 23:38 ` [PATCH 0/3] Adding device tree and binding for Nvidia mgx cx8 switchboard Rob Herring (Arm)
2025-08-18 13:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1f7d028-0c8c-44b3-9f3b-0830e5571890@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=molberding@nvidia.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).