From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDF7C433EF for ; Thu, 7 Apr 2022 22:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232167AbiDGWkv (ORCPT ); Thu, 7 Apr 2022 18:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232300AbiDGWkq (ORCPT ); Thu, 7 Apr 2022 18:40:46 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10E3514F127 for ; Thu, 7 Apr 2022 15:38:34 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id t207so2063671qke.2 for ; Thu, 07 Apr 2022 15:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uqhxauvR8mCQfoS6i8uwjBu35yp97nhbeSWZ8vnrwZY=; b=bV88Cr4N/znjGzgB7rGsAMSx7HMUtAsLuyAIexD78fMOdCSuQ4MWuJ6OWLMzjvmh27 B6cXdE4QcijqPh4lAqbIFQ/biCEolBwl/UxDmX9z5aUx0c0ovN49h0qKtiOm/SmUy5Z5 IEpDqqhlkjAtOwgomHhNLK4qkn5julTyvpYtfEIWo6dsgQ5ivqU4W4ufglNIlUTwYGpB LvVjmvxW1ov4qozfnpoxVU8VcObOqTF+yubspktLowPr5W+rm1f+o06nEbTryAi0JGoO KfsMn8WLSmCtqFxHdzrjnRtrQBJrclEILUxOTHtjeC5LTx8obNvyFuRJEbMhgG55vpe0 tmxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uqhxauvR8mCQfoS6i8uwjBu35yp97nhbeSWZ8vnrwZY=; b=4/CTvSC21WnL09/ez7dtjuozH959i/y+SnJq9GYxOFZHkyyCkHigMF6gvJg8P/08A+ u0yWwsb1IZSgNei6uJw3BjdSn/YC5dfU+FkYikuKPxb075AfGZDIaVrBo7PsbuJxTV16 L1TYo03PckN+uIZsD/hKWBZGR0lfF/yLK/wpC238h7LrwDMyZnGAS6KarB2It6LjAe+N 9OdGUCEEDHGwozZebZGn9a+fd5Fh+zVL5PITacJuwaneDjihVuCM7qoAQmoXUsjzylIe tdoPciIUI2pFxSO/C7yZPbX9rKB2pTFYPRb9DoxrRf1adEAJswfnuS/572ipPgOmt2ks I1FQ== X-Gm-Message-State: AOAM530gL/bTLiAsUczrlmA8rMT0Jh1RkGTErgUtIKFpZkO4Up1tLA94 zclaGZn+Vv6OT6xZcwcE2XIhcw== X-Google-Smtp-Source: ABdhPJxoGTF+jmO49F17rm1r53RiWDqavHKmNkl6FMddkvgVQv8x1rO57QH8eX2rdEH2xyqRsdrSKw== X-Received: by 2002:a05:620a:290d:b0:67d:b5f5:302a with SMTP id m13-20020a05620a290d00b0067db5f5302amr10625916qkp.399.1649371113127; Thu, 07 Apr 2022 15:38:33 -0700 (PDT) Received: from [192.168.0.189] (modemcable134.222-177-173.mc.videotron.ca. [173.177.222.134]) by smtp.gmail.com with ESMTPSA id h6-20020ac85e06000000b002e1e8a98abbsm17018685qtx.41.2022.04.07.15.38.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 15:38:32 -0700 (PDT) Subject: Re: [PATCH] arm64: dts: qcom: sm8450: delete incorrect ufs interconnect fields To: Krzysztof Kozlowski , Vladimir Zapolskiy Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Vinod Koul , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , linux-arm-msm@vger.kernel.org References: <20220407172145.31903-1-jonathan@marek.ca> <865ff6bc-95a2-8b39-5cf2-bb2d3f592c5a@linaro.org> From: Jonathan Marek Message-ID: Date: Thu, 7 Apr 2022 18:38:34 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <865ff6bc-95a2-8b39-5cf2-bb2d3f592c5a@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/7/22 5:16 PM, Krzysztof Kozlowski wrote: > On 07/04/2022 21:40, Vladimir Zapolskiy wrote: >> On 4/7/22 20:21, Jonathan Marek wrote: >>> Upstream sm8450.dtsi has #interconnect-cells = <2>; so these are wrong. >>> Ignored and undocumented with upstream UFS driver so delete for now. > > This is the upstream and they are documented here, although as pointed > by Vladimir this was rather a reverse-documentation. The documentation > might be incorrect, but then the bindings should be corrected instead of > only modifying the DTS. > >> >> Basically the description was added by a commit 462c5c0aa798 ("dt-bindings: ufs: >> qcom,ufs: convert to dtschema"). >> >> It's questionable, if an example in the new yaml file is totally correct >> in connection to the discussed issue. > > To be honest - the example probably is not correct, because it was based > on existing DTS without your patch. :) > > Another question is whether the interconnect properties are here correct > at all. I assumed that DTS is correct because it should describe the > hardware, even if driver does not use it. However maybe that was a false > assumption... > writing-bindings.rst says it is OK to document even if it isn't used by the driver (seems wrong to me, at least for interconnects which are a firmware abstraction and not hardware). 462c5c0aa798 wasn't in my 5.17+ tree pulled after dts changes were merged (I guess doc changes come later), so my commit message is incorrect, but I think it makes more sense to have the documentation reflect the driver. Its also not an important issue, so I'll let others sort it out. > > Best regards, > Krzysztof >