public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: eliza: Disable UFS MCQ mode
Date: Sun, 22 Mar 2026 20:43:01 +0100	[thread overview]
Message-ID: <f213a0ac-e978-4d4a-8f1f-d8dba1522b80@kernel.org> (raw)
In-Reply-To: <20260322-eliza-base-dt-fixes-v1-3-c633a6064a24@oss.qualcomm.com>

On 22/03/2026 17:08, Abel Vesa wrote:
> The UFS MCQ mode is currently not functional in the driver. Eliza is
> the first platform enabling it, which results in UFS failures at runtime
> with errors such as:
> 
>   ufshcd-qcom 1d84000.ufshc: ufshcd_abort: Device abort task at tag 4
>   ufs_device_wlun 0:0:0:49488: tag#4 CDB: opcode=0x1b 1b 00 00 00 10 00
> 
> The failures occur when accessing the UFS device, while the controller
> and PHY initialize correctly.
> 
> Disable MCQ mode by removing the corresponding register range. This can
> be reverted once MCQ support is fixed in the driver.
> 
> Fixes: db7fe6963466 ("arm64: dts: qcom: Introduce Eliza Soc base dtsi")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/eliza.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

MCQ should be disabled in the driver, not via DTS. You have specific
eliza compatible for exactly this purpose.

Best regards,
Krzysztof

  reply	other threads:[~2026-03-22 19:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-22 16:08 [PATCH 0/3] arm64: dts: qcom: eliza: Left-over review fixes Abel Vesa
2026-03-22 16:08 ` [PATCH 1/3] arm64: dts: qcom: eliza: Coding style clean-ups Abel Vesa
2026-03-22 17:47   ` Dmitry Baryshkov
2026-03-23 10:50   ` Konrad Dybcio
2026-03-22 16:08 ` [PATCH 2/3] arm64: dts: qcom: eliza: Add CX power domain to GCC Abel Vesa
2026-03-22 17:51   ` Dmitry Baryshkov
2026-03-23 10:50     ` Konrad Dybcio
2026-03-23 11:20       ` Abel Vesa
2026-03-22 18:39   ` Dmitry Baryshkov
2026-03-23 10:50   ` Konrad Dybcio
2026-03-24  2:15   ` Bjorn Andersson
2026-03-24 13:45     ` Abel Vesa
2026-03-24 15:14       ` Konrad Dybcio
2026-03-24 16:17         ` Abel Vesa
2026-03-22 16:08 ` [PATCH 3/3] arm64: dts: qcom: eliza: Disable UFS MCQ mode Abel Vesa
2026-03-22 19:43   ` Krzysztof Kozlowski [this message]
2026-03-23 18:30     ` Abel Vesa
2026-03-23 10:51   ` Konrad Dybcio
2026-03-23 18:03   ` Abel Vesa
2026-03-23 18:16     ` Nitin Rawat
2026-03-23 18:28       ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f213a0ac-e978-4d4a-8f1f-d8dba1522b80@kernel.org \
    --to=krzk@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox