From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dlan@gentoo.org,
inochiama@outlook.com
Subject: Re: [PATCH v1 2/3] dt-bindings: power: sophgo: add Power-On-Reset/POR for Sophgo CV1800 series SoC.
Date: Thu, 4 Jan 2024 11:45:00 +0100 [thread overview]
Message-ID: <f216b869-6a62-49bc-a32b-8ae7852d2274@linaro.org> (raw)
In-Reply-To: <CAJRtX8TOXjiDfcq+GOqo-nnVtTYtbRRdhpzin4izJW-PtUuBHw@mail.gmail.com>
On 04/01/2024 11:39, Jingbao Qiu wrote:
> On Thu, Jan 4, 2024 at 4:37 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 29/12/2023 10:06, Jingbao Qiu wrote:
>>> Add devicetree binding to describe the Power-On-Reset/POR for Sophgo CV1800 SoC.
>>
>> Please wrap commit message according to Linux coding style / submission
>> process (neither too early nor over the limit):
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>>
>> Subject: Make it concise. It's way over the limit. Also, unnecessary
>> full stop.
>>
>> This all applies to all your patches.
>>
>
> I will do that.
>
>>>
>>
>>> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
>>> ---
>>
>> What changed here? Where is the changelog? Did you just ignore entire
>> feedback from v3?
>
> Actually, I separated the previous patches because there were issues
> in various places.
> I want to solve it bit by bit. Should I continue with the current
> patch changes or return to
> the previous patch?
You need to keep consistent versioning and changelogs.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-04 10:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 9:06 [PATCH v1 0/3] dt-bindings: riscv: sophgo: add mfd RTC and power for CV1800 Jingbao Qiu
2023-12-29 9:06 ` [PATCH v1 1/3] dt-bindings: rtc: sophgo: add RTC for Sophgo CV1800 series SoC Jingbao Qiu
2024-01-04 8:32 ` Krzysztof Kozlowski
2024-01-04 10:34 ` Jingbao Qiu
2024-01-04 10:44 ` Krzysztof Kozlowski
2024-01-04 10:49 ` Jingbao Qiu
2023-12-29 9:06 ` [PATCH v1 2/3] dt-bindings: power: sophgo: add Power-On-Reset/POR " Jingbao Qiu
2024-01-04 8:37 ` Krzysztof Kozlowski
2024-01-04 10:39 ` Jingbao Qiu
2024-01-04 10:45 ` Krzysztof Kozlowski [this message]
2023-12-29 9:06 ` [PATCH v1 3/3] dt-bindings: mfd: sophgo: add misc MFD " Jingbao Qiu
2024-01-04 8:35 ` Krzysztof Kozlowski
2024-01-04 11:05 ` Jingbao Qiu
2024-01-04 11:16 ` Krzysztof Kozlowski
2024-01-04 11:42 ` Jingbao Qiu
2024-01-04 12:03 ` Krzysztof Kozlowski
2024-01-05 9:54 ` Jingbao Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f216b869-6a62-49bc-a32b-8ae7852d2274@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@outlook.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=qiujingbao.dlmu@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).