From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org
Cc: marijn.suijten@somainline.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8250: Touch up audio hw nodes
Date: Sat, 31 Dec 2022 00:45:04 +0100 [thread overview]
Message-ID: <f21704f2-b835-012f-c018-690d954e90d5@linaro.org> (raw)
In-Reply-To: <4d847dbf-c417-eb82-9ae7-53c52844270d@linaro.org>
On 30.12.2022 17:08, Krzysztof Kozlowski wrote:
> On 30/12/2022 14:50, Konrad Dybcio wrote:
>> - Expand long clock-names into vertical lists
>> - Shuffle properties around:
>> - Make sure compatible goes first and status goes last
>> - Make property order consistent between similar nodes
>> - Fix up indentation
>> - Remove stray newlines
>> - Remove a redundant comment about swr2 being associated with TX macro
>> (it's obvious by looking at the label property 10 lines below)
>> - Change unnecessary interrupts-extended to interrupts
>> - Disable SWR0 and WSA macro by default and enable them on SM8250 MTP and
>> RB5, which were the only users
>> - Remove stray #address/size-cells from txmacro, as it's not even
>> supposed to have children
>
> You duplicate here some work:
> https://lore.kernel.org/all/20221225115844.55126-4-krzysztof.kozlowski@linaro.org/
>
> and maybe:
> https://lore.kernel.org/all/167233461775.1099840.3444272939352778399.b4-ty@kernel.org/
>
> If you wish to avoid trivial cleanup conflicts, feel free to poke to my
> pending branch:
> https://github.com/krzk/linux/commits/pending/dt-bindings-qcom-new-and-fixes-for-warnings-linux-next
>
> Also, this is a mixture of non-functional changes (re-ordering,
> whitespace) with something close to functional (interrupts-extended ->
> interrupts, disabling nodes in DTSI). These should be split.
Thanks for pointing this out, I'll resubmit these soon!
Konrad
>
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-12-30 23:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 13:50 [PATCH 1/3] arm64: dts: qcom: sm8250: Pad addresses to 8 hex digits Konrad Dybcio
2022-12-30 13:50 ` [PATCH 2/3] arm64: dts: qcom: sm8250: Touch up audio hw nodes Konrad Dybcio
2022-12-30 16:08 ` Krzysztof Kozlowski
2022-12-30 23:45 ` Konrad Dybcio [this message]
2022-12-30 13:50 ` [PATCH 3/3] arm64: dts: qcom: sm8250: Sort " Konrad Dybcio
2022-12-30 16:10 ` Krzysztof Kozlowski
2023-01-11 5:09 ` (subset) [PATCH 1/3] arm64: dts: qcom: sm8250: Pad addresses to 8 hex digits Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f21704f2-b835-012f-c018-690d954e90d5@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).