From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970D3C4332F for ; Tue, 22 Nov 2022 13:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233239AbiKVNWJ (ORCPT ); Tue, 22 Nov 2022 08:22:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233410AbiKVNWJ (ORCPT ); Tue, 22 Nov 2022 08:22:09 -0500 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7688764545; Tue, 22 Nov 2022 05:22:06 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id D43AC24E1BB; Tue, 22 Nov 2022 21:22:04 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 22 Nov 2022 21:22:05 +0800 Received: from [192.168.125.96] (113.72.144.23) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 22 Nov 2022 21:22:03 +0800 Message-ID: Date: Tue, 22 Nov 2022 21:22:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 2/4] dt-bindings: power: Add starfive,jh71xx-power bindings Content-Language: en-US To: Krzysztof Kozlowski , , , CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J . Wysocki" , References: <20221118133216.17037-1-walker.chen@starfivetech.com> <20221118133216.17037-3-walker.chen@starfivetech.com> <99302e53-c0c9-cfe8-4e6a-c70e8428d9c3@linaro.org> From: Walker Chen In-Reply-To: <99302e53-c0c9-cfe8-4e6a-c70e8428d9c3@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.23] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022/11/21 18:13, Krzysztof Kozlowski wrote: > On 18/11/2022 14:32, Walker Chen wrote: >> Add bindings for the power domain controller on the StarFive JH71XX SoC. >> > > Subject: drop second, redundant "bindings". Will fix. > >> Signed-off-by: Walker Chen >> --- >> .../bindings/power/starfive,jh71xx-power.yaml | 46 +++++++++++++++++++ > > 1st patch should be squashed here. Headers are part of bindings file. Will be done in the next version of patch. > >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml >> new file mode 100644 >> index 000000000000..2537303b4829 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml > > Filename like compatible. As mentioned in the previous email, the compatible in the driver should be changed to "starfive,jh7110-power". > >> @@ -0,0 +1,46 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/starfive,jh71xx-power.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH71xx Power Domains Controller >> + >> +maintainers: >> + - Walker Chen >> + >> +description: | >> + StarFive JH71xx SoCs include support for multiple power domains which can be >> + powered on/off by software based on different application scenes to save power. >> + >> +properties: >> + compatible: >> + items: > > No items. You have just one item, Yes, this issue will be fixed. Thank you for your advice. Best Regards, Walker Chen