From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Johan Hovold <johan@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: gnss: Add two more chips
Date: Sat, 12 Mar 2022 12:44:29 +0100 [thread overview]
Message-ID: <f21f4914-0d70-f176-717d-daefc0305d3a@kernel.org> (raw)
In-Reply-To: <20220311235119.523374-4-linus.walleij@linaro.org>
On 12/03/2022 00:51, Linus Walleij wrote:
> The CSR GSD4t is a CSR product using the SiRFstarIV core, and
> the CSR CSRG05TA03-ICJE-R is a CSR product using the SiRFstarV
> core.
>
> These chips have a SRESETN line that can be pulled low to hard
> reset the chip and in some designs this is connected to a GPIO,
> so add this as an optional property.
>
> Update the example with a reset line so users see that it need
> to be tagged as active low.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Documentation/devicetree/bindings/gnss/sirfstar.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gnss/sirfstar.yaml b/Documentation/devicetree/bindings/gnss/sirfstar.yaml
> index 91874241d0f3..e2ad1f01f9f3 100644
> --- a/Documentation/devicetree/bindings/gnss/sirfstar.yaml
> +++ b/Documentation/devicetree/bindings/gnss/sirfstar.yaml
> @@ -25,6 +25,8 @@ description:
> properties:
> compatible:
> enum:
> + - csr,gsd4t
> + - csr,csrg05ta03-icje-r
> - fastrax,uc430
> - linx,r4
> - wi2wi,w2sg0004
> @@ -39,6 +41,10 @@ properties:
> description:
> Main voltage regulator, pin names such as 3V3_IN, VCC, VDD.
>
> + reset-gpios:
> + description: An optional active low reset line, should be flagged with
> + GPIO_ACTIVE_LOW.
> +
maxItems
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-12 11:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 23:51 [PATCH 1/4] dt-bindings: gnss: Rewrite common bindings in YAML Linus Walleij
2022-03-11 23:51 ` [PATCH 2/4] dt-bindings: gnss: Modify u-blox to use common bindings Linus Walleij
2022-03-12 11:41 ` Krzysztof Kozlowski
2022-03-11 23:51 ` [PATCH 3/4] dt-bindings: gnss: Rewrite sirfstar binding in YAML Linus Walleij
2022-03-12 3:41 ` Rob Herring
2022-03-11 23:51 ` [PATCH 4/4] dt-bindings: gnss: Add two more chips Linus Walleij
2022-03-12 11:44 ` Krzysztof Kozlowski [this message]
2022-03-12 11:39 ` [PATCH 1/4] dt-bindings: gnss: Rewrite common bindings in YAML Krzysztof Kozlowski
2022-03-17 17:54 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f21f4914-0d70-f176-717d-daefc0305d3a@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).