From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC888828; Fri, 2 May 2025 08:16:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746173797; cv=none; b=tEuDJa98WuofyliHdIQao0eLgEJTTZi9GFlFPA+EFsm1eF22fKRQ9quKiKboZL7lUCWJpCCxxi/5BSpP8JagPO4+EuqsPNDkkbdXfVugYmoYKfzh7/qLkCAMZ4IrAMNEA1OAVPM4DCceOdaJiBnUNSdD2i+MeOX748HuqHlomOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746173797; c=relaxed/simple; bh=7PEGRbjPoq0ejywDcjXSYcreCPbFzSRzZrGohIJB5UI=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=ZcGcHOdJ2ccAKPQIre/VwK/79HcywVVBxWuJDunn3Bv9VKAde0WZJfyXUe9hO8h31gGuraTDyDcxkWqWV7xnTPDyEaJeRZqsIOls8VBalUmQu2HT+o9WUFAmU+HWfmbswkRtU4voe7dJXa0PP9iUacHDCg9zAqrtuaTUv+/4JEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=g4hn8mdP; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="g4hn8mdP" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 5428Frxg196471 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 2 May 2025 03:15:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1746173753; bh=byzia56fERYQkK0LYd0FkTzh/NXmDn2U2tbEdsvg97A=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=g4hn8mdPZWg14BlNDN48oJAVTlb/PdlH5jzwTq4uJni7UWSNS7vFYudQIHPV16Pdg b+M6iWMEXTbB7oqydodsbXNOMNk4/gfhNfliyi2G62t4hNEXf8mMFV5ekyQS/pug/J xjbGjLSLVMLiSpxWynYj6E8bTGNqVJLH/GNIOU00= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 5428Fr6V063765 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 2 May 2025 03:15:53 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 2 May 2025 03:15:52 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 2 May 2025 03:15:52 -0500 Received: from [172.24.227.193] (devarsh-precision-tower-3620.dhcp.ti.com [172.24.227.193]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 5428FlR2117383; Fri, 2 May 2025 03:15:48 -0500 Message-ID: Date: Fri, 2 May 2025 13:45:47 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Linux) Subject: Re: [PATCH v1 2/4] arm64: dts: ti: k3-am62x: Add required voltage supplies for IMX219 To: Rishikesh Donadkar , , CC: , , , , , , , , , , , , References: <20250429154133.3377962-1-r-donadkar@ti.com> <20250429154133.3377962-3-r-donadkar@ti.com> Content-Language: en-US From: Devarsh Thakkar In-Reply-To: <20250429154133.3377962-3-r-donadkar@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 29/04/25 21:11, Rishikesh Donadkar wrote: > The device tree overlay for the IMX219 sensor requires three voltage > supplies to be defined: VANA (analog), VDIG (digital core), and VDDL > (digital I/O). > > Add the corresponding voltage supply definitions to avoid dtbs_check > warnings. > On a side-note device-tree overlay requiring these voltages is an implied reason, it's mainly because the schematics mention that and bindings want to capture same topography in device-tree too. So maybe good to mention that and share schematic link too in commit message : https://datasheets.raspberrypi.com/camera/camera-module-2-schematics.pdf With these changes, feel free to add, Reviewed-by: Devarsh Thakkar Regards Devarsh > Signed-off-by: Rishikesh Donadkar > --- > .../boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 31 +++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso > index dd090813a32d6..149c59c071823 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso > +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso > @@ -15,6 +15,33 @@ clk_imx219_fixed: imx219-xclk { > #clock-cells = <0>; > clock-frequency = <24000000>; > }; > + > + reg_2p8v: regulator-2p8v { > + compatible = "regulator-fixed"; > + regulator-name = "2P8V"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + vin-supply = <&vcc_3v3_sys>; > + regulator-always-on; > + }; > + > + reg_1p8v: regulator-1p8v { > + compatible = "regulator-fixed"; > + regulator-name = "1P8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc_3v3_sys>; > + regulator-always-on; > + }; > + > + reg_1p2v: regulator-1p2v { > + compatible = "regulator-fixed"; > + regulator-name = "1P2V"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + vin-supply = <&vcc_3v3_sys>; > + regulator-always-on; > + }; > }; > > &main_i2c2 { > @@ -40,6 +67,10 @@ ov5640: camera@10 { > > clocks = <&clk_imx219_fixed>; > > + VANA-supply = <®_2p8v>; > + VDIG-supply = <®_1p8v>; > + VDDL-supply = <®_1p2v>; > + > reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>; > > port {