From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B033C433EF for ; Mon, 28 Feb 2022 14:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237202AbiB1OhH (ORCPT ); Mon, 28 Feb 2022 09:37:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237201AbiB1OhE (ORCPT ); Mon, 28 Feb 2022 09:37:04 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6BB137ED9C; Mon, 28 Feb 2022 06:36:25 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30E99D6E; Mon, 28 Feb 2022 06:36:25 -0800 (PST) Received: from [10.57.39.47] (unknown [10.57.39.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC8653F73D; Mon, 28 Feb 2022 06:36:23 -0800 (PST) Message-ID: Date: Mon, 28 Feb 2022 14:36:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/3] dt-bindings: spi: Add spiclk to clock-names property in pl022 Content-Language: en-GB To: Kuldeep Singh , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Linus Walleij References: <20220228124345.99474-1-singh.kuldeep87k@gmail.com> <20220228124345.99474-4-singh.kuldeep87k@gmail.com> From: Robin Murphy In-Reply-To: <20220228124345.99474-4-singh.kuldeep87k@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-02-28 12:43, Kuldeep Singh wrote: > Fix below dtc warning by making necessary addition of "spiclk" in > clock-names property. > > arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000: > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000: > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml As before, what makes the binding at fault rather than that DT? The PL022's actual input is named SSPCLK, not SPICLK, so why should a driver which wants to look up that clock by name expect to look for "spiclk"? Robin. > Signed-off-by: Kuldeep Singh > --- > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 5f6926a58b15..fb3075a0c7fd 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -45,6 +45,7 @@ properties: > - enum: > - sspclk > - SSPCLK > + - spiclk > - const: apb_pclk > > pl022,autosuspend-delay: