From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D0CA3672A5 for ; Tue, 1 Sep 2026 11:36:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788262581; cv=none; b=bk9Bs98V+g6Z35T8pAgDwdZtOvrB0h8tk8u/sehU59iqXbY/Qf/qI012HS0aG98Tesa4vo6qUa/LlqP4JKm5Llj9lxuSDTpNBhQvJjRbn5etzic2jmTT0W5RLCYHt9QsuXfZyzJVSGwrFYQPdBAMOqttQC5+h7ZlPl53YcvkjZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788262581; c=relaxed/simple; bh=IRfoPRQyx4mDV1KY7zF8pbQdd1HlpYooqi9V56M7h8o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f4boT3Zsg20Ok+WFsziMmW23IFj5WzjhLvLa6l3LBsNmYd2ppaAuI2prprvjZ5AIwbWZT0QwXBtGCI/97hE2F2fx7c2lAc1S1pbsiXtt2ZZYblauOGR9CxKgt+o0/lJJEXk5AeoefOTA9aKHAFSsV8suAfAgIYtp8Rrkh2PaqVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pZUJGFAm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c1y9+Q29; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pZUJGFAm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c1y9+Q29" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 681AJeS11767385 for ; Tue, 1 Sep 2026 11:36:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= STS6AjEPxzj5uH0XV1tv1hJBJqfHjLpFSlGx5GMKpwk=; b=pZUJGFAm7VygXV7U Jt2iv/ugWVxWHblyI4wMvS9p9nYc4BehIyLSYvKZjmMb2U6J8p152vxUw8dSSw+8 RyFl9rPgjpaZIADPKtsLYNNNu5lROnlep7U35grrABJ7xaZV+uWJfFSSr2/lTzgB CxBpRlCGkrStVuOwZPFKLeriZH6fJ8l7IjdKWBw6q+ZSnIs+nTob331Lpsr5MjtR C7D+1KcqtDA2BnJODGJGZOHU4AqH4vVl5FvDI90mfUdK9d1lg6q5rP4wfjJghqa7 J/qCtqaxLMtcLZ4dujo8+tFclzJmpXyywOm4F7AKXOT7k2ttlocspGlUnxBGK0PR r9U6PA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gdjtx2yf5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 01 Sep 2026 11:36:19 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93494b1e35cso83054785a.0 for ; Tue, 01 Sep 2026 04:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788262578; x=1788867378; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=STS6AjEPxzj5uH0XV1tv1hJBJqfHjLpFSlGx5GMKpwk=; b=c1y9+Q29G4K0oZ1KNOGmi4aytW8aDt377+KQU1Zbqk59g/1scwRrwgxi44CZh504i/ 6MyL+E8IFTv6U5usyvQatXgivFgfT4HJhnN441IJvooq4GHUPvC8ccYgRCgYOuJrEGJ7 A6o3sYPOZro8J9jTO3dLVyl0Z7K1zPXJS5Wum2d6h9j81hNb3dKyO4iTFMK4z4r8gkMe mtJhKsWJwNHUqR1/I/w9e60KwP+BsVieqkXltQ/TWWwsL3aAMOczDWcfLnqF9CGXMxVU G/jmrvBN15LCnxRZqUNpjvDMcysLFUFPoa5JCloansRfANGXGysKQB/IdXwWaqG1G8Jg oYBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788262578; x=1788867378; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=STS6AjEPxzj5uH0XV1tv1hJBJqfHjLpFSlGx5GMKpwk=; b=Ypao4md90S4WOp0tTQ+4nZR9N5s8QdavI6v5TZJXp5GNQ5ScGBVhpT/Hq+pkV9u5Vj NRTda4TDgsSjzdU4+9U5irHExLmATwjnzOTy2YUyRGJgHFR6VoXo4ebiBBbxx3VcILEr 7VIFltpV1gg2a6hIbZ/oCWqSXiGFCoPn8Z/gAd+7I+St/UG8ZICLgbP4Nv0cNqEQ2qOS LInaVJ0p8yLiIU7OFNhfF0JK73+whcF6cut55xNvZVC9Qe70BvSPOi2R2pqglpeKwelc f/m6+M6NcReQYOY5UFo5+Lfb2+3nENqCuqJP6bHW7WYyqKNymxRWrGp88lxOoRs33WOQ jaGQ== X-Forwarded-Encrypted: i=1; AHgh+RqFVGKsp3AcYERnwZ6nVbNDhVyC12OPMm8hYaSbxf0B/yRs/pAY4a/mxmwnx9ckrh0NfMIyvRZcYfzj@vger.kernel.org X-Gm-Message-State: AFuF++noh+RHC0eX3JmZ6UCK2zi2Yrl8JYweO0Sivg7y/iPN4GNvIrnA 4y7fWJm4vuAULvZEojt0wjGIujS094ALYly9wRale+KVOkKF99CHF6tYFXtWXx+nER3DbNCVSYU 8faCPgoQcyCbIKYOvT3tlYx1XranPHqM733CD+E8Bb3tMQfFUQV7KYDtp+a3gBDxK X-Gm-Gg: AR+sD13um0NFxtLmuRmC44GbYsjZMDXF/q3dn8tqjosVHi4VwqQHChSd5uIi+RHvZYw 9waLA1hMdC3vYBSJ7P+C8TrI8sHayoMHK2ntDf631S5DFw2eLw/AIwzFYV5gtwnmJYuBTwGW9ZW IcJ3J/aKUqovevxXJKzl0eMO3Tqba8jgHI69WCIq2ZHqePxcoUP4VIIaCn4hbRcTGj5/yJFJ/MU CzrjQM41CCQtICXng4SL3ftW01wi3cHXQeezJ/iq0dnqWQ5ZG7mTojMQa6hmvKaUGKzWq4/O3r2 VEHyJoFWUJCGYf8CfxL0KnWlfUR2s9pqkpJWlwtZDcGQn6G/P2oRdsEdP3uB0524kJad9Suu2+D TZ9duwtlC5ggneS6KRcYwGA== X-Received: by 2002:a05:620a:8018:b0:92e:9cb3:3f67 with SMTP id af79cd13be357-9392875e6b1mr1452515585a.2.1788262578455; Tue, 01 Sep 2026 04:36:18 -0700 (PDT) X-Received: by 2002:a05:620a:8018:b0:92e:9cb3:3f67 with SMTP id af79cd13be357-9392875e6b1mr1452509185a.2.1788262577784; Tue, 01 Sep 2026 04:36:17 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c255f25177bsm579310766b.57.2026.09.01.04.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 04:36:16 -0700 (PDT) Message-ID: Date: Tue, 1 Sep 2026 13:36:14 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/8] usb: misc: qcom_eud: add role-based EUD control To: Elson Serrao , Bjorn Andersson , Conor Dooley , Dmitry Baryshkov , Greg Kroah-Hartman , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Chen References: <20260831030147.1500616-1-elson.serrao@oss.qualcomm.com> <20260831030147.1500616-7-elson.serrao@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260831030147.1500616-7-elson.serrao@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=K78S2SWI c=1 sm=1 tr=0 ts=6a96b8b3 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=X7E0pNrBJpJ0GBZA2WEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAxMDEwMyBTYWx0ZWRfX40ZEScfa0lqt S0yYNBkPkgf0H37zREvyOeK7NIudvx3pIUSopeQVwbs77hf5aSQhzcVdW6lnjlct+N5YJa5HjzX p8+zpBkvmC9Yyel2OPJn9dzCxRMhAcs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAxMDEwMyBTYWx0ZWRfX7LWDtSbT+zVH ZSKmaOyheYleHiuQgNLOYkwmInLIcQVVyVAHZ+StgMKVHWtmIRcUNY8WKPGjkduv2xJfwMX6jP0 nWTMKOITNzlwRHMWkIawnnOjTIF2iieL1lVdE/m1VFce83g7+cCCpXi8Pdzbe4OMlthvtHmhDWE 0AEwvBnv9ZVlFjNQM7JzAgkJHR/d87+KWnwScbXf8L0Q4md8fKrgFWPUa0G3TBw9olYXl0/Rst0 DN1qBR2zobleaJ9732rzTzCryYkB2s0mZch8wtbnSr3cyeUt53Ym5Itwy36RuxjEgtJ3/IXqN2W ygO0w+Azzk9BHr9TniTA1ZGvoWQ7PrCvhPQPkjVY2GDln/+NNv+nWDrDxiz8AZMTT6wepVcIFvO swmIR3kViMeBqQzw+G6x5nqTnneGCllw0rttnmRFqQ3Me3trJ4XSVJiPxSiLhua+T0MF0APRM5Z tjeDL3j+1jvpC+jgPpQ== X-Proofpoint-GUID: lZxWAFVHOyVWZhXigZkmwLMdtY6N4Zvj X-Proofpoint-ORIG-GUID: lZxWAFVHOyVWZhXigZkmwLMdtY6N4Zvj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-01_03,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609010103 On 8/31/26 5:01 AM, Elson Serrao wrote: > EUD functions by presenting itself as a USB device to the host PC and is > therefore only applicable when the port operates in device role. Keeping > EUD enabled in other roles provides no benefit and unnecessarily keeps > the associated PHY resources enabled. Furthermore, enabling EUD in host > role can cause the USB controller to misbehave because the EUD hub > supports only a single upstream-facing port. [...] > struct eud_chip *chip = dev_get_drvdata(dev); > + struct eud_path *path; > bool enable; > int ret; > > if (kstrtobool(buf, &enable)) > return -EINVAL; > > + guard(mutex)(&chip->state_lock); GPT suggests port_store() should also take this lock.. I think that's a valid concern Konrad