[PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

This fixes typo and resolves following validation error:
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm-fan: pwms: [[54, 0, 10000], [0]] is too long
        from schema $id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#

Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to BPI-R3 dts")
Cc: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
index af4a4309bda4..ba65e3e72bf6 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
@@ -43,7 +43,7 @@ fan: pwm-fan {
 		#cooling-cells = <2>;
 		/* cooling level (0, 1, 2) - pwm inverted */
 		cooling-levels = <255 96 0>;
-		pwms = <&pwm 0 10000 0>;
+		pwms = <&pwm 0 10000>;
 		status = "okay";
 	};
 
-- 
2.35.3

Re: [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[Rafał Miłecki]

Hi guys,

On 16.11.2023 14:08, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This fixes typo and resolves following validation error:
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm-fan: pwms: [[54, 0, 10000], [0]] is too long
>          from schema $id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
> 
> Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to BPI-R3 dts")
> Cc: Daniel Golle <daniel@makrotopia.org>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

I sent those few trivial fixes weeks ago:
[PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node
[PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
[PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename
[PATCH] arm64: dts: mediatek: mt7986: drop crypto's unneeded/invalid clock name

Could someone pick them up, please?


P.S.
FWIW there is also my Acelink EW-7886CAX work but I can understand if
that needs to sit for another week or so.

> ---
>   arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> index af4a4309bda4..ba65e3e72bf6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> @@ -43,7 +43,7 @@ fan: pwm-fan {
>   		#cooling-cells = <2>;
>   		/* cooling level (0, 1, 2) - pwm inverted */
>   		cooling-levels = <255 96 0>;
> -		pwms = <&pwm 0 10000 0>;
> +		pwms = <&pwm 0 10000>;
>   		status = "okay";
>   	};
>   

Re: [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[Rafał Miłecki]

Hi,

On 14.12.2023 07:43, Rafał Miłecki wrote:
> On 16.11.2023 14:08, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This fixes typo and resolves following validation error:
>> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm-fan: pwms: [[54, 0, 10000], [0]] is too long
>>          from schema $id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
>>
>> Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to BPI-R3 dts")
>> Cc: Daniel Golle <daniel@makrotopia.org>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> I sent those few trivial fixes weeks ago:
> [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node
> [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
> [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename
> [PATCH] arm64: dts: mediatek: mt7986: drop crypto's unneeded/invalid clock name
> 
> Could someone pick them up, please?

Anyone, please?

I did quick research and it seems Linus pulls mediatek DTS changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc (from Arnd)


Arnd seems to pull mediatek changes from either:

1. https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux
(Most pulls so far from Matthias)

2. git://git.kernel.org/pub/scm/linux/kernel/git/mediatek/linux
(The most recent pull from AngeloGioacchino)


AngeloGioacchino, Matthias: can you pick up my patches, please?

-- 
Rafał Miłecki

Re: [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[Krzysztof Kozlowski]

On 28/12/2023 08:03, Rafał Miłecki wrote:
> Hi,
> 
> On 14.12.2023 07:43, Rafał Miłecki wrote:
>> On 16.11.2023 14:08, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> This fixes typo and resolves following validation error:
>>> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm-fan: pwms: [[54, 0, 10000], [0]] is too long
>>>          from schema $id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
>>>
>>> Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to BPI-R3 dts")
>>> Cc: Daniel Golle <daniel@makrotopia.org>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> I sent those few trivial fixes weeks ago:
>> [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node
>> [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
>> [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename
>> [PATCH] arm64: dts: mediatek: mt7986: drop crypto's unneeded/invalid clock name
>>
>> Could someone pick them up, please?

This should happen some time ago but...

> 
> Anyone, please?

... exactly now, this cannot happen. We are way past applying patches
for the next cycle. Please ping or resend after the merge window.

> 
> I did quick research and it seems Linus pulls mediatek DTS changes from:
> git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc (from Arnd)
> 
> 
> Arnd seems to pull mediatek changes from either:
> 
> 1. https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux
> (Most pulls so far from Matthias)
> 
> 2. git://git.kernel.org/pub/scm/linux/kernel/git/mediatek/linux
> (The most recent pull from AngeloGioacchino)
> 
> 
> AngeloGioacchino, Matthias: can you pick up my patches, please?

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[Arnd Bergmann]

On Thu, Dec 28, 2023, at 08:14, Krzysztof Kozlowski wrote:
> On 28/12/2023 08:03, Rafał Miłecki wrote:
>> On 14.12.2023 07:43, Rafał Miłecki wrote:
>>> On 16.11.2023 14:08, Rafał Miłecki wrote:
>>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> I sent those few trivial fixes weeks ago:
>>> [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node
>>> [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
>>> [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename
>>> [PATCH] arm64: dts: mediatek: mt7986: drop crypto's unneeded/invalid clock name
>>>
>>> Could someone pick them up, please?
>
> This should happen some time ago but...
>> 
>> Anyone, please?
>
> ... exactly now, this cannot happen. We are way past applying patches
> for the next cycle. Please ping or resend after the merge window.

If these are bugfixes, I still take them, only new functionality
should wait. I still need a reply from the maintainers of course.

      Arnd

Re: [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[AngeloGioacchino Del Regno]

Il 16/11/23 14:08, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This fixes typo and resolves following validation error:
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm-fan: pwms: [[54, 0, 10000], [0]] is too long
>          from schema $id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
> 
> Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to BPI-R3 dts")
> Cc: Daniel Golle <daniel@makrotopia.org>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[AngeloGioacchino Del Regno]

Il 02/01/24 12:45, Arnd Bergmann ha scritto:
> On Thu, Dec 28, 2023, at 08:14, Krzysztof Kozlowski wrote:
>> On 28/12/2023 08:03, Rafał Miłecki wrote:
>>> On 14.12.2023 07:43, Rafał Miłecki wrote:
>>>> On 16.11.2023 14:08, Rafał Miłecki wrote:
>>>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>>
>>>> I sent those few trivial fixes weeks ago:
>>>> [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node
>>>> [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
>>>> [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename
>>>> [PATCH] arm64: dts: mediatek: mt7986: drop crypto's unneeded/invalid clock name
>>>>
>>>> Could someone pick them up, please?
>>
>> This should happen some time ago but...
>>>
>>> Anyone, please?
>>
>> ... exactly now, this cannot happen. We are way past applying patches
>> for the next cycle. Please ping or resend after the merge window.
> 
> If these are bugfixes, I still take them, only new functionality
> should wait. I still need a reply from the maintainers of course.
> 
>        Arnd

I didn't notice those patches, sorry; just added my R-b's to all four.

Arnd, if you can - please pick.

Thanks,
Angelo

Re: [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[Matthias Brugger]

On 16/11/2023 14:08, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This fixes typo and resolves following validation error:
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm-fan: pwms: [[54, 0, 10000], [0]] is too long
>          from schema $id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
> 
> Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to BPI-R3 dts")
> Cc: Daniel Golle <daniel@makrotopia.org>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied this one to our fixes tree now.

Regards,
Matthias

> ---
>   arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> index af4a4309bda4..ba65e3e72bf6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> @@ -43,7 +43,7 @@ fan: pwm-fan {
>   		#cooling-cells = <2>;
>   		/* cooling level (0, 1, 2) - pwm inverted */
>   		cooling-levels = <255 96 0>;
> -		pwms = <&pwm 0 10000 0>;
> +		pwms = <&pwm 0 10000>;
>   		status = "okay";
>   	};
>   

Re: [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node

[Matthias Brugger]

On 28/12/2023 08:03, Rafał Miłecki wrote:
> Hi,
> 
> On 14.12.2023 07:43, Rafał Miłecki wrote:
>> On 16.11.2023 14:08, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> This fixes typo and resolves following validation error:
>>> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: pwm-fan: pwms: 
>>> [[54, 0, 10000], [0]] is too long
>>>          from schema $id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml#
>>>
>>> Fixes: c26f779a2295 ("arm64: dts: mt7986: add pwm-fan and cooling-maps to 
>>> BPI-R3 dts")
>>> Cc: Daniel Golle <daniel@makrotopia.org>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> I sent those few trivial fixes weeks ago:
>> [PATCH] arm64: dts: mediatek: mt7986: fix reference to PWM in fan node
>> [PATCH 1/2] arm64: dts: mediatek: mt7986: fix SPI bus width properties
>> [PATCH 2/2] arm64: dts: mediatek: mt7986: fix SPI nodename
>> [PATCH] arm64: dts: mediatek: mt7986: drop crypto's unneeded/invalid clock name
>>
>> Could someone pick them up, please?
> 
> Anyone, please?
> 
> I did quick research and it seems Linus pulls mediatek DTS changes from:
> git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc (from Arnd)
> 
> 
> Arnd seems to pull mediatek changes from either:
> 
> 1. https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux
> (Most pulls so far from Matthias)

That's the old tree, we don't use this anymore for mediatek.

> 
> 2. git://git.kernel.org/pub/scm/linux/kernel/git/mediatek/linux
> (The most recent pull from AngeloGioacchino)

That's the new tree you should watch out to see your patches showing up.

Regards,
Matthias

> 
> 
> AngeloGioacchino, Matthias: can you pick up my patches, please?
>