Re: [PATCH v1 5/5] ASoC: qcom: sc8280xp: Add shikra-iqs-lt9611uxd-evk compatible support

[Karthik S <karthik.s@oss.qualcomm.com>]

On 10/22/2026 9:37 PM, Ajay Kumar Nandam wrote:
>> +static const struct qcom_snd_soc_common 
>> shikra_iqs_lt9611uxd_priv_data = {
>> +    .driver_name = "shikra",
>> +    .dapm_widgets = sc8280xp_dapm_widgets,
>> +    .num_dapm_widgets = ARRAY_SIZE(sc8280xp_dapm_widgets),
>> +    .codec_dai_fmt = SND_SOC_DAIFMT_BC_FC |
>> +             SND_SOC_DAIFMT_NB_NF |
>> +             SND_SOC_DAIFMT_I2S,
>> +};
> 
> Since the codec is configured as mi2s_bclk_enable, shouldn't we also 
> set .mi2s_bclk_enable = true here?
> 
not necessary in our case, use case is working fine.

for example in case of qcs8275 using max98091 mi2s_bclk_enable is set
but mi2s_bclk_enable is not set to true.

>> +
>>   static const struct qcom_snd_soc_common sm8450_priv_data = {
>>       .driver_name = "sm8450",
>>       .dapm_widgets = sc8280xp_dapm_widgets,
>> @@ -608,6 +617,8 @@ static const struct of_device_id 
>> snd_sc8280xp_dt_match[] = {
>>       { .compatible = "qcom,qcs9100-sndcard", .data = 
>> &qcs9100_priv_data },
>>       { .compatible = "qcom,sc8280xp-sndcard", .data = 
>> &sc8280xp_priv_data },
>>       { .compatible = "qcom,shikra-iqs-sndcard", .data = 
>> &shikra_iqs_priv_data },
>> +    { .compatible = "qcom,shikra-iqs-lt9611uxd-sndcard",
>> +      .data = &shikra_iqs_lt9611uxd_priv_data },
>>       { .compatible = "qcom,sm8450-sndcard", .data = &sm8450_priv_data },
> 
> Nit: please keep the compatible list sorted alphabetically.

sure thanks will update in V2

thanks and regards,
Karthik S