From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403FDC2D0B1 for ; Fri, 7 Feb 2020 06:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16EFA20726 for ; Fri, 7 Feb 2020 06:10:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="XnW4hdba" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726417AbgBGGKz (ORCPT ); Fri, 7 Feb 2020 01:10:55 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:61071 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbgBGGKy (ORCPT ); Fri, 7 Feb 2020 01:10:54 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581055854; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=9dWo6uK9jKsDwewb71Iojt0lLBywexIt8UvMHWOd8gc=; b=XnW4hdba3zk5PVObVx1j7XUEbanIUE+lJ75O/y7BbjeQUkNXK49ryd0TPDna37VzXmyqvVYu jRHw4MulyOjV1q0iXS9PzOkKcU7/ryOEXUKJagKIvqjYu7hLI4FaKVIGTTQaUk+3dq6fidxk 4w2B/Dyh3LHxpiZQthkjgEj9Ojk= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e3cff6a.7f53327aeb58-smtp-out-n03; Fri, 07 Feb 2020 06:10:50 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 24B6BC4479C; Fri, 7 Feb 2020 06:10:50 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id A6F35C43383; Fri, 7 Feb 2020 06:10:49 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Feb 2020 11:40:49 +0530 From: Sai Prakash Ranjan To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Guenter Roeck , devicetree@vger.kernel.org, Douglas Anderson , Stephen Boyd , Matthias Kaehlcke , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree-owner@vger.kernel.org Subject: Re: [PATCHv2 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 In-Reply-To: <20200206183808.GA5019@bogus> References: <20200206183808.GA5019@bogus> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On 2020-02-07 00:08, Rob Herring wrote: > On Sat, Feb 01, 2020 at 08:59:49PM +0530, Sai Prakash Ranjan wrote: >> Add missing compatible for watchdog timer on QCS404, >> SC7180, SDM845 and SM8150 SoCs. > > That's not what the commit does. You are changing what's valid. > > One string was valid, now 2 are required. > Does this look good? diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml index 46d6aad5786a..3378244b67cd 100644 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -14,19 +14,22 @@ allOf: properties: compatible: - items: + oneOf: - enum: - qcom,apss-wdt-qcs404 - qcom,apss-wdt-sc7180 - qcom,apss-wdt-sdm845 - qcom,apss-wdt-sm8150 - - qcom,kpss-timer - - qcom,kpss-wdt - qcom,kpss-wdt-apq8064 - qcom,kpss-wdt-ipq4019 - qcom,kpss-wdt-ipq8064 - qcom,kpss-wdt-msm8960 + - qcom,kpss-timer + - qcom,kpss-wdt - qcom,scss-timer + - const: qcom,kpss-timer + - const: qcom,kpss-wdt + - const: qcom,scss-timer reg: maxItems: 1 Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation