From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address Date: Fri, 30 Sep 2016 14:13:16 +0530 Message-ID: References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-2-mugunthanvnm@ti.com> <20160927194045.GK21388@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160927194045.GK21388@dell> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lee Jones Cc: Mark Rutland , devicetree@vger.kernel.org, Lars-Peter Clausen , Vignesh R , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Sekhar Nori , Russell King , "Andrew F . Davis" , Tony Lindgren , Rob Herring , linux-arm-kernel@lists.infradead.org, Peter Meerwald-Stadler , Hartmut Knaack , linux-omap@vger.kernel.org, Jonathan Cameron List-Id: devicetree@vger.kernel.org On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote: > On Wed, 21 Sep 2016, Mugunthan V N wrote: > >> store the physical address of the device in its priv to use it >> for DMA addressing in the client drivers. >> >> Signed-off-by: Mugunthan V N >> --- >> drivers/mfd/ti_am335x_tscadc.c | 1 + >> include/linux/mfd/ti_am335x_tscadc.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c >> index c8f027b..0f3fab4 100644 >> --- a/drivers/mfd/ti_am335x_tscadc.c >> +++ b/drivers/mfd/ti_am335x_tscadc.c >> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) >> tscadc->irq = err; >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + tscadc->tscadc_phys_base = res->start; > > This is unusual. Can't you use a virt_to_phys() variant instead? > I tried using virt_to_phys(), but its not working for me. Also saw many drivers uses like this to get physical address ("git grep -n " res->start;" drivers/*"). Regards Mugunthan V N