From: Moteen Shah <m-shah@ti.com>
To: Judith Mendez <jm@ti.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] arm64: dts: ti: k3-am6*: Remove disable-wp for eMMC
Date: Tue, 22 Apr 2025 11:38:28 +0530 [thread overview]
Message-ID: <f28134bc-9994-441b-b901-b65632d7ca6b@ti.com> (raw)
In-Reply-To: <20250417233040.3658761-6-jm@ti.com>
On 18/04/25 05:00, Judith Mendez wrote:
> Remove disable-wp flag for eMMC nodes since this flag is
> only applicable to SD according to the binding doc
> (mmc/mmc-controller-common.yaml).
>
> For eMMC, this flag should be ignored but lets remove
> anyways to cleanup sdhci nodes.
>
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 1 -
> arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 1 -
> arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 1 -
> arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 1 -
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am69-sk.dts | 1 -
> 10 files changed, 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> index 55ed418c023bc..e5be92aa12189 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> @@ -381,7 +381,6 @@ serial_flash: flash@0 {
> &sdhci0 {
> pinctrl-names = "default";
> pinctrl-0 = <&main_mmc0_pins_default>;
> - disable-wp;
> non-removable;
> bootph-all;
> status = "okay";
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> index 1c8b4d13fb491..72b09f9c69d8c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> @@ -835,7 +835,6 @@ &sdhci0 {
> non-removable;
> pinctrl-names = "default";
> pinctrl-0 = <&emmc_pins_default>;
> - disable-wp;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
> index 147d56b879843..0d4115590b9c3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
> @@ -338,7 +338,6 @@ serial_flash: flash@0 {
> &sdhci0 {
> pinctrl-names = "default";
> pinctrl-0 = <&main_mmc0_pins_default>;
> - disable-wp;
> non-removable;
> bootph-all;
> status = "okay";
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 7de4a9f139ad4..625ce8f8958b7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -615,7 +615,6 @@ &sdhci0 {
> non-removable;
> pinctrl-names = "default";
> pinctrl-0 = <&main_mmc0_pins_default>;
> - disable-wp;
> bootph-all;
> };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> index 43fcb57b34ebf..1025062c77d57 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> @@ -456,7 +456,6 @@ &sdhci0 {
> status = "okay";
> non-removable;
> ti,driver-strength-ohm = <50>;
> - disable-wp;
> bootph-all;
> };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> index 561916c6e151c..9d933e837dd4b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> @@ -437,7 +437,6 @@ &sdhci0 {
> non-removable;
> pinctrl-names = "default";
> pinctrl-0 = <&main_mmc0_pins_default>;
> - disable-wp;
> };
>
> &sdhci1 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index f8ec40523254b..5c6197ba842e4 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -597,7 +597,6 @@ &sdhci0 {
> status = "okay";
> non-removable;
> ti,driver-strength-ohm = <50>;
> - disable-wp;
> bootph-all;
> };
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index aa7139cc8a92b..c30425960398e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -456,7 +456,6 @@ &sdhci0 {
> bus-width = <8>;
> non-removable;
> ti,driver-strength-ohm = <50>;
> - disable-wp;
> };
>
> /*
> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi
> index ae842b85b70de..12af6cb7f65cf 100644
> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi
> @@ -50,5 +50,4 @@ &sdhci0 {
> bus-width = <8>;
> non-removable;
> ti,driver-strength-ohm = <50>;
> - disable-wp;
> };
> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> index b85227052f97e..f28375629739c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> @@ -940,7 +940,6 @@ &main_sdhci0 {
> status = "okay";
> non-removable;
> ti,driver-strength-ohm = <50>;
> - disable-wp;
> };
Reviewed-by: Moteen Shah <m-shah@ti.com>
Regards,
Moteen Shah
>
> &main_sdhci1 {
prev parent reply other threads:[~2025-04-22 6:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 23:30 [PATCH v2 0/5] Misc MMC updates Judith Mendez
2025-04-17 23:30 ` [PATCH v2 1/5] arm64: dts: ti: k3-am6*: Set eMMC clock parents to default Judith Mendez
2025-04-19 15:00 ` Kumar, Udit
2025-04-21 14:36 ` Judith Mendez
2025-04-22 4:08 ` Kumar, Udit
2025-04-22 12:37 ` Nishanth Menon
2025-04-22 14:08 ` Kumar, Udit
2025-04-22 17:17 ` Judith Mendez
2025-04-22 17:21 ` Kumar, Udit
2025-04-25 22:01 ` Judith Mendez
2025-04-17 23:30 ` [PATCH v2 2/5] arm64: dts: ti: k3-am6*: Add boot phase flag to support MMC boot Judith Mendez
2025-04-22 5:45 ` Moteen Shah
2025-04-17 23:30 ` [PATCH v2 3/5] arm64: dts: ti: k3-am65-main: Add missing taps to sdhci0 Judith Mendez
2025-04-22 5:00 ` Moteen Shah
2025-04-17 23:30 ` [PATCH v2 4/5] arm64: dts: ti: k3-am62*: Add non-removable flag for eMMC Judith Mendez
2025-04-19 14:47 ` Kumar, Udit
2025-04-17 23:30 ` [PATCH v2 5/5] arm64: dts: ti: k3-am6*: Remove disable-wp " Judith Mendez
2025-04-22 6:08 ` Moteen Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f28134bc-9994-441b-b901-b65632d7ca6b@ti.com \
--to=m-shah@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox