From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mehdi Djait <mehdi.djait@bootlin.com>, Rob Herring <robh@kernel.org>
Cc: mchehab@kernel.org, heiko@sntech.de,
ezequiel@vanguardiasur.com.ar, hverkuil-cisco@xs4all.nl,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
paul.kocialkowski@bootlin.com, miquel.raynal@bootlin.com,
maxime.chevallier@bootlin.com, luca.ceresoli@bootlin.com,
thomas.petazzoni@bootlin.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 1/3] media: dt-bindings: media: add rockchip-vip
Date: Tue, 3 Oct 2023 11:17:37 +0200 [thread overview]
Message-ID: <f2863562-33dc-443c-950d-2024c07943a1@linaro.org> (raw)
In-Reply-To: <ZRvTdm5cTMT1tHlM@pc-86.home>
On 03/10/2023 10:40, Mehdi Djait wrote:
>>> +maintainers:
>>> + - Mehdi Djait <mehdi.djait@bootlin.com>
>>> +
>>> +description: |-
>>
>> Don't need '|-'.
>>
>>> + Rockchip Video Input Processor present on PX30, RK1808, RK3128 and RK3288
>>
>> Write complete sentences.
>>
>>
>>
>>> +
>>> +properties:
>>> + compatible:
>>> + const: rockchip,px30-vip
>>
>> I see 4 SoCs listed, but only 1 compatible.
>>
>
> PX30 is the only SoC I have used to test the driver. What is the best
> way to proceed here ? Change the description ?
>
The best is to have bindings complete for all of the four SoCs, even if
you did not test the driver on them. The "complete" means
hardware-complete, so what the datasheet/spec is saying.
If anything is missing, could be added later.
You can change the description and drop other SoCs as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-03 9:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 10:07 [PATCH v6 0/3] media: rockchip: Add a driver for Rockchip's camera interface Mehdi Djait
2023-09-29 10:08 ` [PATCH v6 1/3] media: dt-bindings: media: add rockchip-vip Mehdi Djait
2023-10-02 17:18 ` Rob Herring
2023-10-03 8:40 ` Mehdi Djait
2023-10-03 9:17 ` Krzysztof Kozlowski [this message]
2023-09-29 10:08 ` [PATCH v6 2/3] media: rockchip: Add a driver for Rockhip's camera interface Mehdi Djait
2023-09-30 15:04 ` Krzysztof Kozlowski
2023-09-29 10:08 ` [PATCH v6 3/3] arm64: dts: rockchip: Add the " Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2863562-33dc-443c-950d-2024c07943a1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).