From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot03.ext.ti.com (fllvem-ot03.ext.ti.com [198.47.19.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA5951C84CB; Tue, 5 Aug 2025 14:06:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.245 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754402771; cv=none; b=AUqoRRuszdD9Sk/10DdIaJf8Trh/N4yzp03Mfe82ugXmrdHQ489JxU3rEkxII0L48W/RKAcM67GSmtdr/B9xTUdNi74uDiRJye6roH9ag5lQv1LkUQz94ZOAF8bn5K/N9ZlMqUXtSa4FcQwEi4Y5Yg7FXRrv6tISXTARsdx/BV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754402771; c=relaxed/simple; bh=MNG+a38PQofKHypXt1CPqMvHNjsLHe2AAEsrZBTBd84=; h=Message-ID:Date:MIME-Version:Subject:From:To:CC:References: In-Reply-To:Content-Type; b=FcAnrw8Jk2By0h224IQ2pqCNs0Akh2sE2jV1DYrVOoH9AafibpNJzVh5V44ylzDT4ZQqnpoc6lKVTncSfselahw5TQGWvIfmSYjxUBOPcToSt9L/xvcR0H9b+PF0BoFCofMoiK2DZizIKoF8zMKUzaRAfXkZmkSXQ/UJ6RjlGIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=timMHIc8; arc=none smtp.client-ip=198.47.19.245 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="timMHIc8" Received: from fllvem-sh04.itg.ti.com ([10.64.41.54]) by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTP id 575E5wPf4055648; Tue, 5 Aug 2025 09:05:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1754402758; bh=5pqwMScuPTwzx0lyuc5MF37k0uqjqh5/S7oN85LSRqI=; h=Date:Subject:From:To:CC:References:In-Reply-To; b=timMHIc8NKwRvpd+gXcAFdjLUIPylpbG6DYc1V3fi+tmzewXaCGClsKpRHs2v0Tef Fw+UetwtQBW5POwb2L+5/jjdA6rvCpfL+vssv0gn5GPdB4umxQTfxZSyWNRhLNJvpI YdEpgnZzBvzEdqIuZhxkAdAWKU3+B+S4r1+rIqsY= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllvem-sh04.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 575E5wjF3496847 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Tue, 5 Aug 2025 09:05:58 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Tue, 5 Aug 2025 09:05:57 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Tue, 5 Aug 2025 09:05:57 -0500 Received: from [10.249.34.164] ([10.249.34.164]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 575E5uk02223144; Tue, 5 Aug 2025 09:05:56 -0500 Message-ID: Date: Tue, 5 Aug 2025 09:05:56 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: ti: k3-j722s-main: Add E5010 JPEG Encoder From: Brandon Brnich To: Krzysztof Kozlowski , CC: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , Devarsh Thakkar , Udit Kumar , Darren Etheridge References: <20250804180106.2393256-1-b-brnich@ti.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Hello, On 8/5/2025 8:34 AM, Brandon Brnich wrote: > Hi Krzysztof, > > Thanks for the review. > > On 8/5/2025 1:02 AM, Krzysztof Kozlowski wrote: >> On 04/08/2025 20:01, Brandon Brnich wrote: >>> This adds node for E5010 JPEG Encoder which is a stateful JPEG Encoder >>> present in J722s SoC, supporting baseline encoding of semiplanar based >>> YUV420 and YUV422 raw video formats to JPEG encoding, with resolutions >>> supported from 64x64 to 8kx8k. >>> >>> Signed-off-by: Brandon Brnich >>> --- >>> >>> Changes in v2: >>>    - remove invalid clock-names attribute >>> >>>   arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 10 ++++++++++ >>>   1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/ >>> boot/dts/ti/k3-j722s-main.dtsi >>> index 5cfa7bf36641..fb24c14614b4 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi >>> @@ -385,6 +385,16 @@ c7x_1: dsp@7e200000 { >>>           ti,sci-proc-ids = <0x31 0xff>; >>>           status = "disabled"; >>>       }; >>> + >>> +    e5010: e5010@fd20000 { >> >> Node names should be generic. See also an explanation and list of >> examples (not exhaustive) in DT specification: >> https://devicetree-specification.readthedocs.io/en/latest/chapter2- >> devicetree-basics.html#generic-names-recommendation > > I got this name from the already present node in the am62a device > tree[0]. Should I replace both of these with more generic name such as > jpegenc? Please ignore above comment, I was thinking about the label and not the node name. I understand node name needs to be jpeg-encoder. Should label also be more generic? I see a few examples where the label is jpegenc or something more generic than the specific part name. But I don't see any specific rules in the devicetree specs on labels. > >> >> >>> +        compatible = "img,e5010-jpeg-enc"; >> >> Wrong compatible. This is TI, not IMG. > > Devarsh has pointed out the same, I will update compatible that matches > TI version in v3. > > Best, > Brandon > > [0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ > tree/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi#n1149 > >> >> >> Best regards, >> Krzysztof >