From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sai Prakash Ranjan Subject: Re: [PATCHv8 3/5] arm64: dts: qcom: msm8996: Add Coresight support Date: Thu, 18 Jul 2019 11:17:01 +0530 Message-ID: References: <2fa725fbc09306f1a95befc62715a708b4c0fad0.1562940244.git.saiprakash.ranjan@codeaurora.org> <20190717170050.GB4271@xps15> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190717170050.GB4271@xps15> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Mathieu Poirier Cc: Greg Kroah-Hartman , Suzuki K Poulose , Leo Yan , Alexander Shishkin , Mike Leach , Rob Herring , Bjorn Andersson , devicetree@vger.kernel.org, David Brown , Mark Rutland , Rajendra Nayak , Vivek Gautam , Sibi Sankar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Marc Gonzalez List-Id: devicetree@vger.kernel.org Hi Mathieu, On 7/17/2019 10:30 PM, Mathieu Poirier wrote: > On Fri, Jul 12, 2019 at 07:46:25PM +0530, Sai Prakash Ranjan wrote: >> From: Vivek Gautam >> >> Enable coresight support by adding device nodes for the >> available source, sinks and channel blocks on msm8996. >> >> This also adds coresight cpu debug nodes. >> >> Signed-off-by: Vivek Gautam >> Signed-off-by: Sai Prakash Ranjan >> Reviewed-by: Mathieu Poirier >> Acked-By: Suzuki K Poulose >> --- >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 434 ++++++++++++++++++++++++++ >> 1 file changed, 434 insertions(+) >> > > We've gone trhough 8 iteration of this set and I'm still finding checkpatch > problems, and I'm not referring to lines over 80 characters. > I only get below 2 checkpatch warnings: If you are talking about the below one, then it was not added manually. It was taken automatically when I pulled in the v7. Should I be resending this patch for this? $ ./scripts/checkpatch.pl -g 2fa725fbc09306f1a95befc62715a708b4c0fad0 WARNING: 'Acked-by:' is the preferred signature form #14: Acked-By: Suzuki K Poulose WARNING: line over 80 characters #154: FILE: arch/arm64/boot/dts/qcom/msm8996.dtsi:763: + compatible = "arm,coresight-dynamic-replicator", "arm,primecell"; total: 0 errors, 2 warnings, 440 lines checked -Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation