* [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false
@ 2023-07-28 17:11 Krzysztof Kozlowski
2023-07-28 17:13 ` Conor Dooley
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 17:11 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matti Vaittinen, linux-leds, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
select:false makes the schema basically ignored (not selected for given
compatible), unless some other binding references it. It's not really
useful nor needed for device bindings, even if they are part of other
binding (like MFD).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
index 58f0d94c6d71..b7a3ef76cbf4 100644
--- a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
+++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
@@ -18,8 +18,6 @@ description: |
The device has two LED outputs referred as GRNLED and AMBLED in data-sheet.
-select: false
-
properties:
compatible:
const: rohm,bd71828-leds
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false
2023-07-28 17:11 [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false Krzysztof Kozlowski
@ 2023-07-28 17:13 ` Conor Dooley
2023-08-02 6:53 ` Matti Vaittinen
2023-08-17 10:29 ` (subset) " Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2023-07-28 17:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matti Vaittinen, linux-leds, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Fri, Jul 28, 2023 at 07:11:23PM +0200, Krzysztof Kozlowski wrote:
> select:false makes the schema basically ignored (not selected for given
> compatible), unless some other binding references it. It's not really
> useful nor needed for device bindings, even if they are part of other
> binding (like MFD).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false
2023-07-28 17:11 [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false Krzysztof Kozlowski
2023-07-28 17:13 ` Conor Dooley
@ 2023-08-02 6:53 ` Matti Vaittinen
2023-08-17 10:29 ` (subset) " Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Matti Vaittinen @ 2023-08-02 6:53 UTC (permalink / raw)
To: Krzysztof Kozlowski, Pavel Machek, Lee Jones, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-leds, devicetree,
linux-kernel
On 7/28/23 20:11, Krzysztof Kozlowski wrote:
> select:false makes the schema basically ignored (not selected for given
> compatible), unless some other binding references it. It's not really
> useful nor needed for device bindings, even if they are part of other
> binding (like MFD).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Yours,
Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: (subset) [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false
2023-07-28 17:11 [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false Krzysztof Kozlowski
2023-07-28 17:13 ` Conor Dooley
2023-08-02 6:53 ` Matti Vaittinen
@ 2023-08-17 10:29 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-08-17 10:29 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matti Vaittinen, linux-leds, devicetree,
linux-kernel, Krzysztof Kozlowski
On Fri, 28 Jul 2023 19:11:23 +0200, Krzysztof Kozlowski wrote:
> select:false makes the schema basically ignored (not selected for given
> compatible), unless some other binding references it. It's not really
> useful nor needed for device bindings, even if they are part of other
> binding (like MFD).
>
>
Applied, thanks!
[1/1] dt-bindings: leds: rohm,bd71828: Drop select:false
commit: f044ae6b5a215df5420705dbaa287c59d8d5ef6b
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-17 10:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 17:11 [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false Krzysztof Kozlowski
2023-07-28 17:13 ` Conor Dooley
2023-08-02 6:53 ` Matti Vaittinen
2023-08-17 10:29 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).