devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Jianfeng Liu <liujianfeng1994@gmail.com>, detlev.casanova@collabora.com
Cc: alchark@gmail.com, andy.yan@rock-chips.com, conor+dt@kernel.org,
	 cristian.ciocaltea@collabora.com, devicetree@vger.kernel.org,
	 didi.debian@cknow.org, dsimic@manjaro.org,
	gregkh@linuxfoundation.org,  heiko@sntech.de, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	 linux-rockchip@lists.infradead.org,
	linux-staging@lists.linux.dev,  mchehab@kernel.org,
	robh@kernel.org, sebastian.reichel@collabora.com
Subject: Re: [PATCH 1/3] media: rockchip: Introduce the rkvdec2 driver
Date: Mon, 17 Jun 2024 10:04:59 -0400	[thread overview]
Message-ID: <f295f41ef1c9ee920ac3ac8e70ccf672ba7c9648.camel@ndufresne.ca> (raw)
In-Reply-To: <20240617094735.27928-1-liujianfeng1994@gmail.com>

Hi,

Le lundi 17 juin 2024 à 17:47 +0800, Jianfeng Liu a écrit :
> Hi Detlev,
> 
> Thanks a lot for your work! I try to use rkvdec2 with chromium but it
> can't play h264 video. Here is the log of chromium:
> 
> [5799:5873:0617/171224.850061:VERBOSE2:video_decoder_pipeline.cc(473)] Initialize(): config: codec: h264, profile: h264 high, level: not available, alpha_mode: is_opaque, coded size: [1920,1080], visible rect: [0,0,1920,1080], natural size: [1920,1080], has extra data: true, encryption scheme: Unencrypted, rotation: 0°, flipped: 0, color space: {primaries:BT709, transfer:BT709, matrix:BT709, range:LIMITED}
> [5799:5886:0617/171224.850915:VERBOSE2:v4l2_video_decoder.cc(182)] V4L2VideoDecoder():
> [5799:5886:0617/171224.851218:VERBOSE1:v4l2_device.cc(128)] Open(): No devices supporting H264 for type: 0
> [5799:5886:0617/171224.851346:VERBOSE4:v4l2_queue.cc(1069)] This queue does  support requests.: No such file or directory (2)

This one indicates that V4L2_BUF_CAP_SUPPORTS_REQUESTS might be missing in the
REQBUFS implementation. I suspect GStreamer simply assumes this today for driver
exposing stateless formats (which is fair, its not a compliance test, and we
don't have a codec compliance yet).

I'd suggest to check and fix this one, and retry, might only be noise, might be
the main cause, we cannot tell.

> [5799:5886:0617/171224.851426:VERBOSE1:v4l2_video_decoder.cc(476)] InitializeBackend(): Using a stateless API for profile: h264 high and fourcc: S264
> [5799:5886:0617/171224.851687:VERBOSE1:v4l2_video_decoder.cc(598)] SetupInputFormat(): Input (OUTPUT queue) Fourcc: S264
> [5799:5886:0617/171224.851797:VERBOSE1:v4l2_video_decoder.cc(636)] AllocateInputBuffers(): Requesting: 17 OUTPUT buffers of type V4L2_MEMORY_MMAP
> [5799:5886:0617/171224.867687:VERBOSE1:v4l2_queue.cc(1511)] Streamon(): (OUTPUT_MPLANE) VIDIOC_STREAMON failed: Invalid argument (22)
> [5799:5886:0617/171224.867902:VERBOSE1:v4l2_video_decoder.cc(937)] StartStreamV4L2Queue(): Failed to streamon V4L2 queue.
> [5799:5886:0617/171224.868009:VERBOSE1:v4l2_video_decoder.cc(1377)] SetState(): Error occurred, stopping queues.
> [5799:5886:0617/171224.868105:ERROR:v4l2_video_decoder.cc(120)] StartStreamV4L2Queue failed at Decode@media/gpu/v4l2/v4l2_video_decoder.cc:915
> [5799:5886:0617/171224.871898:WARNING:v4l2_video_decoder_backend_stateless.cc(126)] There is/are 0 pending CAPTURE queue buffers pending dequeuing. This might be fine or a problem depending on the destruction semantics (of theclient code.
> 
> Here is the chromium code failed when calling VIDIOC_STREAMON:
> https://github.com/chromium/chromium/blob/125.0.6422.60/media/gpu/v4l2/v4l2_queue.cc#L1508
> 
> I'm running chromium v125.0.6422.60 and I can decode 1080p h264 with
> hantro g1 decoder on rk3588.

Are you using minigbm ? Because if you do, we don't have minigbm code for this
driver (and have no plan to do so, since we don't aim for ChromeOS support).

Nicolas

> 
> Best regards,
> Jianfeng
> 


  reply	other threads:[~2024-06-17 14:05 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-15  1:56 [PATCH 0/3] media: rockchip: Add rkvdec2 driver Detlev Casanova
2024-06-15  1:56 ` [PATCH 1/3] media: rockchip: Introduce the " Detlev Casanova
2024-06-15  8:51   ` Diederik de Haas
2024-06-15 19:44     ` Detlev Casanova
2024-06-16  8:40       ` Diederik de Haas
2024-06-17 13:52         ` Nicolas Dufresne
2025-01-29 14:48       ` Piotr Oniszczuk
2025-01-29 16:20         ` Nicolas Dufresne
2025-01-30 10:22           ` Piotr Oniszczuk
2025-01-29 16:50         ` Detlev Casanova
2025-01-30 10:46           ` Piotr Oniszczuk
2025-01-30 14:54             ` Piotr Oniszczuk
2024-06-15 13:55   ` kernel test robot
2024-06-15 17:21   ` kernel test robot
2024-06-15 22:24   ` Dmitry Osipenko
2024-06-15 22:32   ` Dmitry Osipenko
2024-06-16  6:58   ` Andy Yan
2024-06-17 13:40     ` [PATCH " Detlev Casanova
2024-06-17 13:59     ` Nicolas Dufresne
2024-06-16 21:40   ` Jonas Karlman
2024-06-17 13:56     ` Detlev Casanova
2024-06-17  4:49   ` Alex Bee
2024-06-17 14:17     ` Detlev Casanova
2024-06-17 15:10     ` Nicolas Dufresne
2024-06-17  9:47   ` Jianfeng Liu
2024-06-17 14:04     ` Nicolas Dufresne [this message]
2024-06-17 14:20       ` Detlev Casanova
2024-06-17 15:22         ` Nicolas Dufresne
2024-06-18 12:13         ` Jianfeng Liu
2024-06-18 12:39           ` Detlev Casanova
2024-06-18 16:34             ` Nicolas Dufresne
2024-06-19  7:41               ` Jianfeng Liu
2024-06-17 15:21       ` Jianfeng Liu
2024-06-17 12:02   ` Dan Carpenter
2024-06-17 14:23     ` Detlev Casanova
2024-06-15  1:56 ` [PATCH 2/3] media: dt-bindings: rockchip: Document RK3588 Video Decoder 2 bindings Detlev Casanova
2024-06-15  3:15   ` Rob Herring (Arm)
2024-06-15  8:11   ` Jonas Karlman
2024-06-15 19:49     ` Detlev Casanova
2024-06-15 22:58       ` Heiko Stuebner
2024-06-15  1:56 ` [PATCH 3/3] arm64: dts: rockchip: Add rkvdec2 Video Decoder on rk3588(s) Detlev Casanova
2024-06-15  8:25   ` Jonas Karlman
2024-06-15 19:55     ` Detlev Casanova
2024-06-16  7:28       ` Heiko Stuebner
2024-06-17 14:31         ` Detlev Casanova
2024-06-16  9:17       ` Jonas Karlman
2024-06-16 11:55         ` Dragan Simic
2024-06-17 14:36         ` Detlev Casanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f295f41ef1c9ee920ac3ac8e70ccf672ba7c9648.camel@ndufresne.ca \
    --to=nicolas@ndufresne.ca \
    --cc=alchark@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=dsimic@manjaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=liujianfeng1994@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).