* [PATCH 1/2] arm64: dts: imx93: Add audio device nodes
@ 2023-09-27 2:33 Chancel Liu
2023-09-27 2:33 ` [PATCH 2/2] arm64: dts: imx93: Configure clock rate for audio PLL Chancel Liu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chancel Liu @ 2023-09-27 2:33 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, linux-imx, devicetree, linux-arm-kernel,
linux-kernel
Cc: Chancel Liu
Add audio devices nodes including SAI, MICFIL, XCVR and MQS.
Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 87 ++++++++++++++++++++++++
1 file changed, 87 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index f20dd18e0b65..6ed7b156c633 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -366,6 +366,25 @@ flexcan1: can@443a0000 {
status = "disabled";
};
+ sai1: sai@443b0000 {
+ compatible = "fsl,imx93-sai";
+ reg = <0x443b0000 0x10000>;
+ interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_SAI1_IPG>, <&clk IMX93_CLK_DUMMY>,
+ <&clk IMX93_CLK_SAI1_GATE>, <&clk IMX93_CLK_DUMMY>,
+ <&clk IMX93_CLK_DUMMY>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma1 22 0 1>, <&edma1 21 0 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
+ mqs1: mqs {
+ compatible = "fsl,imx93-mqs";
+ gpr = <&anomix_ns_gpr>;
+ status = "disabled";
+ };
+
iomuxc: pinctrl@443c0000 {
compatible = "fsl,imx93-iomuxc";
reg = <0x443c0000 0x10000>;
@@ -446,6 +465,23 @@ tmu: tmu@44482000 {
#thermal-sensor-cells = <1>;
};
+ micfil: micfil@44520000 {
+ compatible = "fsl,imx93-micfil";
+ reg = <0x44520000 0x10000>;
+ interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_PDM_IPG>,
+ <&clk IMX93_CLK_PDM_GATE>,
+ <&clk IMX93_CLK_AUDIO_PLL>,
+ <&clk IMX93_CLK_DUMMY>;
+ clock-names = "ipg_clk", "ipg_clk_app",
+ "pll8k", "clkext3";
+ dmas = <&edma1 29 0 5>;
+ dma-names = "rx";
+ status = "disabled";
+ };
adc1: adc@44530000 {
compatible = "nxp,imx93-adc";
@@ -736,6 +772,57 @@ flexspi1: spi@425e0000 {
status = "disabled";
};
+ sai2: sai@42650000 {
+ compatible = "fsl,imx93-sai";
+ reg = <0x42650000 0x10000>;
+ interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_SAI2_IPG>, <&clk IMX93_CLK_DUMMY>,
+ <&clk IMX93_CLK_SAI2_GATE>, <&clk IMX93_CLK_DUMMY>,
+ <&clk IMX93_CLK_DUMMY>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma2 59 0 1>, <&edma2 58 0 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
+ sai3: sai@42660000 {
+ compatible = "fsl,imx93-sai";
+ reg = <0x42660000 0x10000>;
+ interrupts = <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_SAI3_IPG>, <&clk IMX93_CLK_DUMMY>,
+ <&clk IMX93_CLK_SAI3_GATE>, <&clk IMX93_CLK_DUMMY>,
+ <&clk IMX93_CLK_DUMMY>;
+ clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
+ dmas = <&edma2 61 0 1>, <&edma2 60 0 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
+ mqs2: mqs {
+ compatible = "fsl,imx93-mqs";
+ gpr = <&wakeupmix_gpr>;
+ status = "disabled";
+ };
+
+ xcvr: xcvr@42680000 {
+ compatible = "fsl,imx93-xcvr";
+ reg = <0x42680000 0x800>,
+ <0x42680800 0x400>,
+ <0x42680c00 0x080>,
+ <0x42680e00 0x080>;
+ reg-names = "ram", "regs", "rxfifo", "txfifo";
+ interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 204 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_BUS_WAKEUP>,
+ <&clk IMX93_CLK_SPDIF_GATE>,
+ <&clk IMX93_CLK_DUMMY>,
+ <&clk IMX93_CLK_AUD_XCVR_GATE>;
+ clock-names = "ipg", "phy", "spba", "pll_ipg";
+ dmas = <&edma2 65 0 1>, <&edma2 66 0 0>;
+ dma-names = "rx", "tx";
+ status = "disabled";
+ };
+
lpuart7: serial@42690000 {
compatible = "fsl,imx93-lpuart", "fsl,imx8ulp-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x42690000 0x1000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: dts: imx93: Configure clock rate for audio PLL
2023-09-27 2:33 [PATCH 1/2] arm64: dts: imx93: Add audio device nodes Chancel Liu
@ 2023-09-27 2:33 ` Chancel Liu
2023-09-27 2:45 ` [PATCH 1/2] arm64: dts: imx93: Add audio device nodes Fabio Estevam
2023-09-27 7:52 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Chancel Liu @ 2023-09-27 2:33 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, linux-imx, devicetree, linux-arm-kernel,
linux-kernel
Cc: Chancel Liu
Configure clock rate for audio PLL. There's one audio PLL on i.MX93. It
is used as parent clock for clocks that are multiple of 8kHz.
Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 6ed7b156c633..0a0bfb7bccd6 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -413,6 +413,8 @@ clk: clock-controller@44450000 {
#clock-cells = <1>;
clocks = <&osc_32k>, <&osc_24m>, <&clk_ext1>;
clock-names = "osc_32k", "osc_24m", "clk_ext1";
+ assigned-clocks = <&clk IMX93_CLK_AUDIO_PLL>;
+ assigned-clock-rates = <393216000>;
status = "okay";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx93: Add audio device nodes
2023-09-27 2:33 [PATCH 1/2] arm64: dts: imx93: Add audio device nodes Chancel Liu
2023-09-27 2:33 ` [PATCH 2/2] arm64: dts: imx93: Configure clock rate for audio PLL Chancel Liu
@ 2023-09-27 2:45 ` Fabio Estevam
2023-09-27 7:52 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-09-27 2:45 UTC (permalink / raw)
To: Chancel Liu
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, linux-imx, devicetree, linux-arm-kernel, linux-kernel
On Tue, Sep 26, 2023 at 11:33 PM Chancel Liu <chancel.liu@nxp.com> wrote:
> + mqs1: mqs {
> + compatible = "fsl,imx93-mqs";
> + gpr = <&anomix_ns_gpr>;
> + status = "disabled";
No clocks here?
Please convert Documentation/devicetree/bindings/sound/fsl,mqs.txt to yaml.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx93: Add audio device nodes
2023-09-27 2:33 [PATCH 1/2] arm64: dts: imx93: Add audio device nodes Chancel Liu
2023-09-27 2:33 ` [PATCH 2/2] arm64: dts: imx93: Configure clock rate for audio PLL Chancel Liu
2023-09-27 2:45 ` [PATCH 1/2] arm64: dts: imx93: Add audio device nodes Fabio Estevam
@ 2023-09-27 7:52 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-27 7:52 UTC (permalink / raw)
To: Chancel Liu, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo,
s.hauer, kernel, festevam, linux-imx, devicetree,
linux-arm-kernel, linux-kernel
On 27/09/2023 04:33, Chancel Liu wrote:
> Add audio devices nodes including SAI, MICFIL, XCVR and MQS.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 87 ++++++++++++++++++++++++
> 1 file changed, 87 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index f20dd18e0b65..6ed7b156c633 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -366,6 +366,25 @@ flexcan1: can@443a0000 {
> status = "disabled";
> };
>
> + sai1: sai@443b0000 {
> + compatible = "fsl,imx93-sai";
> + reg = <0x443b0000 0x10000>;
> + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk IMX93_CLK_SAI1_IPG>, <&clk IMX93_CLK_DUMMY>,
> + <&clk IMX93_CLK_SAI1_GATE>, <&clk IMX93_CLK_DUMMY>,
> + <&clk IMX93_CLK_DUMMY>;
> + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> + dmas = <&edma1 22 0 1>, <&edma1 21 0 0>;
> + dma-names = "rx", "tx";
> + status = "disabled";
> + };
> +
> + mqs1: mqs {
Why do you have non-MMIO nodes in soc@? You introduce new warnings.
Please test your code (dtbs_check W=1)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-27 7:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 2:33 [PATCH 1/2] arm64: dts: imx93: Add audio device nodes Chancel Liu
2023-09-27 2:33 ` [PATCH 2/2] arm64: dts: imx93: Configure clock rate for audio PLL Chancel Liu
2023-09-27 2:45 ` [PATCH 1/2] arm64: dts: imx93: Add audio device nodes Fabio Estevam
2023-09-27 7:52 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).