[PATCH 0/5] arm64: dts: Add device tree source for the Au-Zone Maivin AI Vision Starter Kit

[PATCH 0/5] arm64: dts: Add device tree source for the Au-Zone Maivin AI Vision Starter Kit

[Laurent Pinchart]

Hello,

This patch series adds device tree sources for the Maivin AI Vision
Starter Kit developed by Au-Zone Technologies in collaboration with
Toradex and Vision Components ([1]).

The first two patches add a new compatible string for the DAC081C081
present on the board to the dac5571 DT bindings and driver. Patch 3/5
then adds a new vendor prefix for Au-Zone, and patch 4/5 adds the board
to the arm/fsl.yaml DT bindings. Finally, patch 5/5 adds support for the
board.

[1] https://www.toradex.com/maivin-modular-full-stack-ai-vision-system

Laurent Pinchart (5):
  dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support
  iio: dac: ti-dac5571: Add DAC081C081 support
  dt-bindings: vendor-prefix: Add prefix for Au-Zone Technologies
  dt-bindings: arm: Add Au-Zone Maivin AI Vision Starter Kit
  arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

 .../devicetree/bindings/arm/fsl.yaml          |   7 +
 .../bindings/iio/dac/ti,dac5571.yaml          |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../boot/dts/freescale/imx8mp-maivin.dts      | 236 ++++++++++++++++++
 drivers/iio/dac/ti-dac5571.c                  |   3 +
 6 files changed, 250 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-maivin.dts


base-commit: 4cece764965020c22cff7665b18a012006359095
-- 
Regards,

Laurent Pinchart

[PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Laurent Pinchart]

The DAC081C081 is a TI DAC whose software interface is compatible with
the DAC5571. It is the 8-bit version of the DAC121C081, already
supported by the DAC5571 bindings. Extends the bindings to support this
chip.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
index 79da0323c327..e59db861e2eb 100644
--- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
@@ -21,6 +21,7 @@ properties:
       - ti,dac5573
       - ti,dac6573
       - ti,dac7573
+      - ti,dac081c081
       - ti,dac121c081
 
   reg:
-- 
Regards,

Laurent Pinchart

[PATCH 2/5] iio: dac: ti-dac5571: Add DAC081C081 support

[Laurent Pinchart]

The DAC081C081 is a TI DAC whose software interface is compatible with
the DAC5571. It is the 8-bit version of the DAC121C081, already
supported by the DAC5571 driver. Extends the driver to support this
chip.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/iio/dac/ti-dac5571.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
index efb1269a77c1..c5162b72951a 100644
--- a/drivers/iio/dac/ti-dac5571.c
+++ b/drivers/iio/dac/ti-dac5571.c
@@ -13,6 +13,7 @@
  * https://www.ti.com/lit/ds/symlink/dac5573.pdf
  * https://www.ti.com/lit/ds/symlink/dac6573.pdf
  * https://www.ti.com/lit/ds/symlink/dac7573.pdf
+ * https://www.ti.com/lit/ds/symlink/dac081c081.pdf
  * https://www.ti.com/lit/ds/symlink/dac121c081.pdf
  */
 
@@ -386,6 +387,7 @@ static void dac5571_remove(struct i2c_client *i2c)
 }
 
 static const struct of_device_id dac5571_of_id[] = {
+	{.compatible = "ti,dac081c081", .data = &dac5571_spec[single_8bit] },
 	{.compatible = "ti,dac121c081", .data = &dac5571_spec[single_12bit] },
 	{.compatible = "ti,dac5571", .data = &dac5571_spec[single_8bit] },
 	{.compatible = "ti,dac6571", .data = &dac5571_spec[single_10bit] },
@@ -401,6 +403,7 @@ static const struct of_device_id dac5571_of_id[] = {
 MODULE_DEVICE_TABLE(of, dac5571_of_id);
 
 static const struct i2c_device_id dac5571_id[] = {
+	{"dac081c081", (kernel_ulong_t)&dac5571_spec[single_8bit] },
 	{"dac121c081", (kernel_ulong_t)&dac5571_spec[single_12bit] },
 	{"dac5571", (kernel_ulong_t)&dac5571_spec[single_8bit] },
 	{"dac6571", (kernel_ulong_t)&dac5571_spec[single_10bit] },
-- 
Regards,

Laurent Pinchart

[PATCH 3/5] dt-bindings: vendor-prefix: Add prefix for Au-Zone Technologies

[Laurent Pinchart]

Au-Zone Technologies is a company that designs and manufactures products
for AI vision applications. Add a DT vendor prefix for it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index b97d298b3eb6..fce3d80c3d34 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -180,6 +180,8 @@ patternProperties:
     description: AU Optronics Corporation
   "^auvidea,.*":
     description: Auvidea GmbH
+  "^au-zone,.*":
+    description: Au-Zone Technologies
   "^avago,.*":
     description: Avago Technologies
   "^avia,.*":
-- 
Regards,

Laurent Pinchart

[PATCH 4/5] dt-bindings: arm: Add Au-Zone Maivin AI Vision Starter Kit

[Laurent Pinchart]

The Maivin board is an AI vision starter kit sold by Au-Zone
Technologies, developed in collaboration with Toradex and Vision
Components. It is based on a Toradex Verdin i.MX8MP SoM.

Add a corresponding compatible string.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 0027201e19f8..d892c4f9fda3 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1064,6 +1064,13 @@ properties:
               - toradex,verdin-imx8mp-wifi  # Verdin iMX8M Plus Wi-Fi / BT Modules
           - const: fsl,imx8mp
 
+      - description: Au-Zone Technologies i.MX8MP-based boards
+        items:
+          - const: au-zone,maivin-starter-kit        # Au-Zone Maivin AI Vision Starter Kit
+          - const: toradex,verdin-imx8mp-nonwifi     # Verdin iMX8M Plus Module without Wi-Fi / BT
+          - const: toradex,verdin-imx8mp             # Verdin iMX8M Plus Module
+          - const: fsl,imx8mp
+
       - description: Avnet (MSC Branded) Boards with SM2S i.MX8M Plus Modules
         items:
           - const: avnet,sm2s-imx8mp-14N0600E-ep1 # SM2S-IMX8PLUS-14N0600E on SM2-MB-EP1 Carrier Board
-- 
Regards,

Laurent Pinchart

[PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

[Laurent Pinchart]

The Maivin board is an AI vision starter kit sold by Au-Zone
Technologies, developed in collaboration with Toradex and Vision
Components. It is based on a Toradex Verdin i.MX8MP SoM.

Add a device tree that covers the base set the peripherals found on the
board:

- Ethernet
- USB
- SD card slot
- CAN and serial ports (RS232 and RS485)
- DACs, EEPROMs, temperature sensor
- PCI M.2 and CSI regulators

An additional pinctrl group is included for the M.2 modem, but hasn't
been tested due to lack of compatible hardware.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../boot/dts/freescale/imx8mp-maivin.dts      | 236 ++++++++++++++++++
 2 files changed, 237 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-maivin.dts

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 045250d0a040..03af8c242649 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -165,6 +165,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mp-maivin.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
new file mode 100644
index 000000000000..2d1c8e782465
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
@@ -0,0 +1,236 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+/*
+ * Copyright 2021 Au-Zone Technologies
+ * Copyright 2024 Ideas on Board
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/linux-event-codes.h>
+#include <dt-bindings/leds/common.h>
+
+#include "imx8mp-verdin.dtsi"
+#include "imx8mp-verdin-nonwifi.dtsi"
+
+/ {
+	model = "Au-Zone Maivin AI Vision Starter Kit";
+	compatible = "au-zone,maivin-starter-kit",
+		     "toradex,verdin-imx8mp-nonwifi",
+		     "toradex,verdin-imx8mp",
+		     "fsl,imx8mp";
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-0 = <&pinctrl_sw1>;
+
+		button-0 {
+			label = "SW1";
+			linux,code = <BTN_MISC>;
+			interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>;
+		};
+	};
+
+	leds {
+		compatible = "gpio-leds";
+		pinctrl-0 = <&pinctrl_led>;
+
+		led-0 {
+			color = <LED_COLOR_ID_BLUE>;
+			function = LED_FUNCTION_STATUS;
+			linux,default-trigger = "heartbeat";
+			gpios = <&gpio3 14 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
+	csi_3v3: regulator-csi-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "CSI_3V3";
+		pinctrl-0 = <&pinctrl_csi_3v3>;
+		gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		startup-delay-us = <50000>;	/* TODO: Determine the right value */
+	};
+
+	m2_3v3: regulator-m2-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "M2_3V3";
+		regulator-max-microvolt = <3300000>;
+		regulator-min-microvolt = <3300000>;
+		pinctrl-0 = <&pinctrl_m2_3v3>;
+		gpio = <&gpio3 1 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	/* Carrier Board Supply 3V3_SW */
+	reg_3v3: regulator-3v3-sw {
+		compatible = "regulator-fixed";
+		regulator-max-microvolt = <3300000>;
+		regulator-min-microvolt = <3300000>;
+		regulator-name = "3V3_SW";
+	};
+};
+
+&eqos {
+	status = "okay";
+};
+
+/* Verdin CAN_1 */
+&flexcan1 {
+	status = "okay";
+};
+
+/* Verdin CAN_2 */
+&flexcan2 {
+	status = "okay";
+};
+
+/* Verdin I2C_2_DSI */
+&i2c2 {
+	status = "okay";
+
+	clock-frequency = <400000>;
+	scl-gpios = <&gpio5 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+	sda-gpios = <&gpio5 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+
+	dac@d {
+		compatible = "ti,dac081c081";
+		reg = <0x0d>;
+		vref-supply = <&csi_3v3>;
+	};
+};
+
+/* Verdin I2C_4_CSI */
+&i2c3 {
+	status = "okay";
+
+	dac@d {
+		compatible = "ti,dac081c081";
+		reg = <0x0d>;
+		vref-supply = <&csi_3v3>;
+	};
+};
+
+/* Verdin I2C_1 */
+&i2c4 {
+	status = "okay";
+
+	temp-sensor@4b {
+		compatible = "ti,tmp102";
+		reg = <0x4b>;
+	};
+
+	/* EEPROM on the rear connector interface */
+	eeprom@54 {
+		compatible = "st,24c02", "atmel,24c02";
+		pagesize = <16>;
+		reg = <0x54>;
+	};
+};
+
+/* EEPROM on the carrier board */
+&eeprom_carrier_board {
+	status = "okay";
+};
+
+&iomuxc {
+	pinctrl_csi_3v3: csi-3v3-grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_DATA01__GPIO3_IO07		0x184	/* SODIMM 58 */
+		>;
+	};
+
+	gpio7grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI1_RXD1__GPIO4_IO03		0x82	/* SODIMM 220 */
+		>;
+	};
+
+	gpio8grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI1_RXC__GPIO4_IO01		0x82	/* SODIMM 222 */
+		>;
+	};
+
+	pinctrl_led: ledgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_DQS__GPIO3_IO14		0x82	/* SODIMM 66 */
+		>;
+	};
+
+	/* M.2 power off and reset */
+	pinctrl_m2: m2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_DATA00__GPIO3_IO06		0x82	/* SODIMM 56 */
+			MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09		0x82	/* SODIMM 62 */
+		>;
+	};
+
+	pinctrl_m2_3v3: m2-3v3-grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_NAND_CE0_B__GPIO3_IO01		0x82	/* SODIMM 54 */
+		>;
+	};
+
+	pinctrl_sw1: sw1grp {
+		fsl,pins = <
+			/*
+			 * SW1 shortens the pin to ground when pressed, enable
+			 * the internal pull-up.
+			 */
+			MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16		0x1c0	/* SODIMM 64 */
+		>;
+	};
+};
+
+&reg_usdhc2_vmmc {
+	vin-supply = <&reg_3v3>;
+};
+
+/* Verdin UART_1 */
+/* Enabling RS-485 operation */
+&uart1 {
+	fsl,uart-has-rtscts;
+	linux,rs485-enabled-at-boot-time;
+};
+
+/* Verdin UART_2, for M.2 card slot */
+&uart2 {
+	status = "okay";
+};
+
+/* Verdin UART_3, used as the Linux Console */
+&uart3 {
+	status = "okay";
+};
+
+/* Verdin USB_1, USB recovery */
+&usb3_phy0 {
+	status = "okay";
+};
+
+&usb3_0 {
+	status = "okay";
+};
+
+&usb_dwc3_0 {
+	status = "okay";
+};
+
+/* Verdin USB_2, for M.2 card slot */
+&usb3_phy1 {
+	status = "okay";
+};
+
+&usb3_1 {
+	status = "okay";
+};
+
+&usb_dwc3_1 {
+	status = "okay";
+};
+
+/* Verdin SD_1, for SD card slot */
+&usdhc2 {
+	status = "okay";
+};
-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Jonathan Cameron]

On Mon, 25 Mar 2024 22:32:41 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> The DAC081C081 is a TI DAC whose software interface is compatible with
> the DAC5571. It is the 8-bit version of the DAC121C081, already
> supported by the DAC5571 bindings. Extends the bindings to support this
> chip.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Hi Laurent,

Given it's a part number where no one is going to guess it is compatible
with the DAC5571 and that we don't have a history of fallback compatibles
I'm fine with this change, but just wanted to ask is a fallback compatible
useful to you to run with older kernels?

I should have noticed when Peter added the dac121c081. If we add a fallback
should do that one as well.

Jonathan
> ---
>  Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> index 79da0323c327..e59db861e2eb 100644
> --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> @@ -21,6 +21,7 @@ properties:
>        - ti,dac5573
>        - ti,dac6573
>        - ti,dac7573
> +      - ti,dac081c081
>        - ti,dac121c081
>  
>    reg:

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Laurent Pinchart]

Hi Jonathan,

On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote:
> On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote:
> 
> > The DAC081C081 is a TI DAC whose software interface is compatible with
> > the DAC5571. It is the 8-bit version of the DAC121C081, already
> > supported by the DAC5571 bindings. Extends the bindings to support this
> > chip.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Hi Laurent,
> 
> Given it's a part number where no one is going to guess it is compatible
> with the DAC5571 and that we don't have a history of fallback compatibles
> I'm fine with this change, but just wanted to ask is a fallback compatible
> useful to you to run with older kernels?
> 
> I should have noticed when Peter added the dac121c081. If we add a fallback
> should do that one as well.

I've indeed noticed that there should have been a fallback for
dac121c081, but didn't stop to ponder why that wasn't the case, and just
went along with the flow :-) I agree a fallback could be useful, which
would then allow dropping patch 2/5 from this series (*). I can do so if
you prefer.

* This is not entirely true. While the DAC1081C081 is largely compatible
with the DAC5573, they have different values for one of the power-down
resistors (2.5kΩ instead of 1kΩ if I recall correctly). To be completely
accurate, the driver should report that. We could still use the fallback
compatible, reporting the wrong power-down resistor value.

> > ---
> >  Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > index 79da0323c327..e59db861e2eb 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > @@ -21,6 +21,7 @@ properties:
> >        - ti,dac5573
> >        - ti,dac6573
> >        - ti,dac7573
> > +      - ti,dac081c081
> >        - ti,dac121c081
> >  
> >    reg:

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Laurent Pinchart]

On Mon, Mar 25, 2024 at 10:56:44PM +0200, Laurent Pinchart wrote:
> On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote:
> > On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote:
> > 
> > > The DAC081C081 is a TI DAC whose software interface is compatible with
> > > the DAC5571. It is the 8-bit version of the DAC121C081, already
> > > supported by the DAC5571 bindings. Extends the bindings to support this
> > > chip.
> > > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > Hi Laurent,
> > 
> > Given it's a part number where no one is going to guess it is compatible
> > with the DAC5571 and that we don't have a history of fallback compatibles
> > I'm fine with this change, but just wanted to ask is a fallback compatible
> > useful to you to run with older kernels?
> > 
> > I should have noticed when Peter added the dac121c081. If we add a fallback
> > should do that one as well.
> 
> I've indeed noticed that there should have been a fallback for
> dac121c081, but didn't stop to ponder why that wasn't the case, and just
> went along with the flow :-) I agree a fallback could be useful, which
> would then allow dropping patch 2/5 from this series (*). I can do so if
> you prefer.

And in that case, should I first introduce support in the bindings for
"ti,dac121c081", "ti,dac7571" and deprecate usage of "ti,dac121c081"
alone ?

> * This is not entirely true. While the DAC1081C081 is largely compatible
> with the DAC5573, they have different values for one of the power-down
> resistors (2.5kΩ instead of 1kΩ if I recall correctly). To be completely
> accurate, the driver should report that. We could still use the fallback
> compatible, reporting the wrong power-down resistor value.
> 
> > > ---
> > >  Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > index 79da0323c327..e59db861e2eb 100644
> > > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > @@ -21,6 +21,7 @@ properties:
> > >        - ti,dac5573
> > >        - ti,dac6573
> > >        - ti,dac7573
> > > +      - ti,dac081c081
> > >        - ti,dac121c081
> > >  
> > >    reg:

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Jonathan Cameron]

On 25 March 2024 22:23:08 GMT, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>On Mon, Mar 25, 2024 at 10:56:44PM +0200, Laurent Pinchart wrote:
>> On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote:
>> > On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote:
>> > 
>> > > The DAC081C081 is a TI DAC whose software interface is compatible with
>> > > the DAC5571. It is the 8-bit version of the DAC121C081, already
>> > > supported by the DAC5571 bindings. Extends the bindings to support this
>> > > chip.
>> > > 
>> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> > 
>> > Hi Laurent,
>> > 
>> > Given it's a part number where no one is going to guess it is compatible
>> > with the DAC5571 and that we don't have a history of fallback compatibles
>> > I'm fine with this change, but just wanted to ask is a fallback compatible
>> > useful to you to run with older kernels?
>> > 
>> > I should have noticed when Peter added the dac121c081. If we add a fallback
>> > should do that one as well.
>> 
>> I've indeed noticed that there should have been a fallback for
>> dac121c081, but didn't stop to ponder why that wasn't the case, and just
>> went along with the flow :-) I agree a fallback could be useful, which
>> would then allow dropping patch 2/5 from this series (*). I can do so if
>> you prefer.
>
>And in that case, should I first introduce support in the bindings for
>"ti,dac121c081", "ti,dac7571" and deprecate usage of "ti,dac121c081"
>alone ?

Yes. Not sure if we need an explicit binding entry for deprecated version...

>
>> * This is not entirely true. While the DAC1081C081 is largely compatible
>> with the DAC5573, they have different values for one of the power-down
>> resistors (2.5kΩ instead of 1kΩ if I recall correctly). To be completely
>> accurate, the driver should report that. We could still use the fallback
>> compatible, reporting the wrong power-down resistor value.
>> 
>> > > ---
>> > >  Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
>> > >  1 file changed, 1 insertion(+)
>> > > 
>> > > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
>> > > index 79da0323c327..e59db861e2eb 100644
>> > > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
>> > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
>> > > @@ -21,6 +21,7 @@ properties:
>> > >        - ti,dac5573
>> > >        - ti,dac6573
>> > >        - ti,dac7573
>> > > +      - ti,dac081c081
>> > >        - ti,dac121c081
>> > >  
>> > >    reg:
>

Re: [PATCH 3/5] dt-bindings: vendor-prefix: Add prefix for Au-Zone Technologies

[Krzysztof Kozlowski]

On 25/03/2024 21:32, Laurent Pinchart wrote:
> Au-Zone Technologies is a company that designs and manufactures products
> for AI vision applications. Add a DT vendor prefix for it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 4/5] dt-bindings: arm: Add Au-Zone Maivin AI Vision Starter Kit

[Krzysztof Kozlowski]

On 25/03/2024 21:32, Laurent Pinchart wrote:
> The Maivin board is an AI vision starter kit sold by Au-Zone
> Technologies, developed in collaboration with Toradex and Vision
> Components. It is based on a Toradex Verdin i.MX8MP SoM.
> 
> Add a corresponding compatible string.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 0027201e19f8..d892c4f9fda3 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1064,6 +1064,13 @@ properties:
>                - toradex,verdin-imx8mp-wifi  # Verdin iMX8M Plus Wi-Fi / BT Modules
>            - const: fsl,imx8mp
>  
> +      - description: Au-Zone Technologies i.MX8MP-based boards
> +        items:
> +          - const: au-zone,maivin-starter-kit        # Au-Zone Maivin AI Vision Starter Kit
> +          - const: toradex,verdin-imx8mp-nonwifi     # Verdin iMX8M Plus Module without Wi-Fi / BT
> +          - const: toradex,verdin-imx8mp             # Verdin iMX8M Plus Module

I think this should be part of existing "Toradex Boards with Verdin
iMX8M Plus Modules)", just renamed to "boards using Toradex Verdin ...".

Best regards,
Krzysztof

Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

[Krzysztof Kozlowski]

On 25/03/2024 21:32, Laurent Pinchart wrote:
> The Maivin board is an AI vision starter kit sold by Au-Zone
> Technologies, developed in collaboration with Toradex and Vision
> Components. It is based on a Toradex Verdin i.MX8MP SoM.
> 
> Add a device tree that covers the base set the peripherals found on the
> board:

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
And drop redundant parts.
arm64: dts: imx8mp-maivin: Add Au-Zone Maivin Starter Kit board


Best regards,
Krzysztof

Re: [PATCH 2/5] iio: dac: ti-dac5571: Add DAC081C081 support

[Sean Nyekjaer]

> On 25 Mar 2024, at 21.32, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> 
> The DAC081C081 is a TI DAC whose software interface is compatible with
> the DAC5571. It is the 8-bit version of the DAC121C081, already
> supported by the DAC5571 driver. Extends the driver to support this
> chip.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sean Nyekjaer <sean@geanix.com <mailto:sean@geanix.com>>
> ---
> drivers/iio/dac/ti-dac5571.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
> index efb1269a77c1..c5162b72951a 100644
> --- a/drivers/iio/dac/ti-dac5571.c
> +++ b/drivers/iio/dac/ti-dac5571.c
> @@ -13,6 +13,7 @@
>  * https://www.ti.com/lit/ds/symlink/dac5573.pdf
>  * https://www.ti.com/lit/ds/symlink/dac6573.pdf
>  * https://www.ti.com/lit/ds/symlink/dac7573.pdf
> + * https://www.ti.com/lit/ds/symlink/dac081c081.pdf
>  * https://www.ti.com/lit/ds/symlink/dac121c081.pdf
>  */
> 
> @@ -386,6 +387,7 @@ static void dac5571_remove(struct i2c_client *i2c)
> }
> 
> static const struct of_device_id dac5571_of_id[] = {
> + {.compatible = "ti,dac081c081", .data = &dac5571_spec[single_8bit] },
> {.compatible = "ti,dac121c081", .data = &dac5571_spec[single_12bit] },
> {.compatible = "ti,dac5571", .data = &dac5571_spec[single_8bit] },
> {.compatible = "ti,dac6571", .data = &dac5571_spec[single_10bit] },
> @@ -401,6 +403,7 @@ static const struct of_device_id dac5571_of_id[] = {
> MODULE_DEVICE_TABLE(of, dac5571_of_id);
> 
> static const struct i2c_device_id dac5571_id[] = {
> + {"dac081c081", (kernel_ulong_t)&dac5571_spec[single_8bit] },
> {"dac121c081", (kernel_ulong_t)&dac5571_spec[single_12bit] },
> {"dac5571", (kernel_ulong_t)&dac5571_spec[single_8bit] },
> {"dac6571", (kernel_ulong_t)&dac5571_spec[single_10bit] },
> -- 
> Regards,
> 
> Laurent Pinchart
> 

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Sean Nyekjaer]

> On 25 Mar 2024, at 21.32, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> 
> The DAC081C081 is a TI DAC whose software interface is compatible with
> the DAC5571. It is the 8-bit version of the DAC121C081, already
> supported by the DAC5571 bindings. Extends the bindings to support this
> chip.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sean Nyekjaer <sean@geanix.com>
> ---
> Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> index 79da0323c327..e59db861e2eb 100644
> --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> @@ -21,6 +21,7 @@ properties:
>       - ti,dac5573
>       - ti,dac6573
>       - ti,dac7573
> +      - ti,dac081c081
>       - ti,dac121c081
> 
>   reg:
> -- 
> Regards,
> 
> Laurent Pinchart
> 

Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

[Laurent Pinchart]

Hi Krzysztof,

On Tue, Mar 26, 2024 at 08:12:45AM +0100, Krzysztof Kozlowski wrote:
> On 25/03/2024 21:32, Laurent Pinchart wrote:
> > The Maivin board is an AI vision starter kit sold by Au-Zone
> > Technologies, developed in collaboration with Toradex and Vision
> > Components. It is based on a Toradex Verdin i.MX8MP SoM.
> > 
> > Add a device tree that covers the base set the peripherals found on the
> > board:
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
> And drop redundant parts.
> arm64: dts: imx8mp-maivin: Add Au-Zone Maivin Starter Kit board

Including in the command line the name of the dts that is being added
doesn't seem to be a very common practice. See for instance

6d382d51d979 arm64: dts: freescale: Add SKOV IMX8MP CPU revB board

I can use

arm64: dts: freescale Add Au-Zone Maivin Starter Kit

if you prefer.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

[Krzysztof Kozlowski]

On 26/03/2024 10:11, Laurent Pinchart wrote:
> Hi Krzysztof,
> 
> On Tue, Mar 26, 2024 at 08:12:45AM +0100, Krzysztof Kozlowski wrote:
>> On 25/03/2024 21:32, Laurent Pinchart wrote:
>>> The Maivin board is an AI vision starter kit sold by Au-Zone
>>> Technologies, developed in collaboration with Toradex and Vision
>>> Components. It is based on a Toradex Verdin i.MX8MP SoM.
>>>
>>> Add a device tree that covers the base set the peripherals found on the
>>> board:
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>> your patch is touching.
>> And drop redundant parts.
>> arm64: dts: imx8mp-maivin: Add Au-Zone Maivin Starter Kit board
> 
> Including in the command line the name of the dts that is being added
> doesn't seem to be a very common practice. See for instance
> 
> 6d382d51d979 arm64: dts: freescale: Add SKOV IMX8MP CPU revB board
> 
> I can use
> 
> arm64: dts: freescale Add Au-Zone Maivin Starter Kit
> 
> if you prefer.

It's also fine (plus missing : after freescale).

Best regards,
Krzysztof

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Jonathan Cameron]

On Mon, 25 Mar 2024 22:56:41 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hi Jonathan,
> 
> On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote:
> > On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote:
> >   
> > > The DAC081C081 is a TI DAC whose software interface is compatible with
> > > the DAC5571. It is the 8-bit version of the DAC121C081, already
> > > supported by the DAC5571 bindings. Extends the bindings to support this
> > > chip.
> > > 
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>  
> > 
> > Hi Laurent,
> > 
> > Given it's a part number where no one is going to guess it is compatible
> > with the DAC5571 and that we don't have a history of fallback compatibles
> > I'm fine with this change, but just wanted to ask is a fallback compatible
> > useful to you to run with older kernels?
> > 
> > I should have noticed when Peter added the dac121c081. If we add a fallback
> > should do that one as well.  
> 
> I've indeed noticed that there should have been a fallback for
> dac121c081, but didn't stop to ponder why that wasn't the case, and just
> went along with the flow :-) I agree a fallback could be useful, which
> would then allow dropping patch 2/5 from this series (*). I can do so if
> you prefer.
> 
> * This is not entirely true. While the DAC1081C081 is largely compatible
> with the DAC5573, they have different values for one of the power-down
> resistors (2.5kΩ instead of 1kΩ if I recall correctly). To be completely
> accurate, the driver should report that. We could still use the fallback
> compatible, reporting the wrong power-down resistor value.
> 

Hmm - Would anyone really care about that value being wrong?
I think perhaps that's just about significant enough that maybe a fallback
compatible doesn't make sense here.

Jonathan

> > > ---
> > >  Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > index 79da0323c327..e59db861e2eb 100644
> > > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > @@ -21,6 +21,7 @@ properties:
> > >        - ti,dac5573
> > >        - ti,dac6573
> > >        - ti,dac7573
> > > +      - ti,dac081c081
> > >        - ti,dac121c081
> > >  
> > >    reg:  
> 

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Laurent Pinchart]

On Tue, Mar 26, 2024 at 03:29:27PM +0000, Jonathan Cameron wrote:
> On Mon, 25 Mar 2024 22:56:41 +0200 Laurent Pinchart wrote:
> > On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote:
> > > On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote:
> > >   
> > > > The DAC081C081 is a TI DAC whose software interface is compatible with
> > > > the DAC5571. It is the 8-bit version of the DAC121C081, already
> > > > supported by the DAC5571 bindings. Extends the bindings to support this
> > > > chip.
> > > > 
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>  
> > > 
> > > Hi Laurent,
> > > 
> > > Given it's a part number where no one is going to guess it is compatible
> > > with the DAC5571 and that we don't have a history of fallback compatibles
> > > I'm fine with this change, but just wanted to ask is a fallback compatible
> > > useful to you to run with older kernels?
> > > 
> > > I should have noticed when Peter added the dac121c081. If we add a fallback
> > > should do that one as well.  
> > 
> > I've indeed noticed that there should have been a fallback for
> > dac121c081, but didn't stop to ponder why that wasn't the case, and just
> > went along with the flow :-) I agree a fallback could be useful, which
> > would then allow dropping patch 2/5 from this series (*). I can do so if
> > you prefer.
> > 
> > * This is not entirely true. While the DAC1081C081 is largely compatible
> > with the DAC5573, they have different values for one of the power-down
> > resistors (2.5kΩ instead of 1kΩ if I recall correctly). To be completely
> > accurate, the driver should report that. We could still use the fallback
> > compatible, reporting the wrong power-down resistor value.
> 
> Hmm - Would anyone really care about that value being wrong?

I don't have enough expertise with IIO to be sure, but my guess is that
nobody would.

> I think perhaps that's just about significant enough that maybe a fallback
> compatible doesn't make sense here.

Then let's keep it simple and just merge this patch as-is ? :-)

> > > > ---
> > > >  Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > index 79da0323c327..e59db861e2eb 100644
> > > > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > @@ -21,6 +21,7 @@ properties:
> > > >        - ti,dac5573
> > > >        - ti,dac6573
> > > >        - ti,dac7573
> > > > +      - ti,dac081c081
> > > >        - ti,dac121c081
> > > >  
> > > >    reg:  

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Jonathan Cameron]

On Tue, 26 Mar 2024 18:50:43 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> On Tue, Mar 26, 2024 at 03:29:27PM +0000, Jonathan Cameron wrote:
> > On Mon, 25 Mar 2024 22:56:41 +0200 Laurent Pinchart wrote:  
> > > On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote:  
> > > > On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote:
> > > >     
> > > > > The DAC081C081 is a TI DAC whose software interface is compatible with
> > > > > the DAC5571. It is the 8-bit version of the DAC121C081, already
> > > > > supported by the DAC5571 bindings. Extends the bindings to support this
> > > > > chip.
> > > > > 
> > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>    
> > > > 
> > > > Hi Laurent,
> > > > 
> > > > Given it's a part number where no one is going to guess it is compatible
> > > > with the DAC5571 and that we don't have a history of fallback compatibles
> > > > I'm fine with this change, but just wanted to ask is a fallback compatible
> > > > useful to you to run with older kernels?
> > > > 
> > > > I should have noticed when Peter added the dac121c081. If we add a fallback
> > > > should do that one as well.    
> > > 
> > > I've indeed noticed that there should have been a fallback for
> > > dac121c081, but didn't stop to ponder why that wasn't the case, and just
> > > went along with the flow :-) I agree a fallback could be useful, which
> > > would then allow dropping patch 2/5 from this series (*). I can do so if
> > > you prefer.
> > > 
> > > * This is not entirely true. While the DAC1081C081 is largely compatible
> > > with the DAC5573, they have different values for one of the power-down
> > > resistors (2.5kΩ instead of 1kΩ if I recall correctly). To be completely
> > > accurate, the driver should report that. We could still use the fallback
> > > compatible, reporting the wrong power-down resistor value.  
> > 
> > Hmm - Would anyone really care about that value being wrong?  
> 
> I don't have enough expertise with IIO to be sure, but my guess is that
> nobody would.
> 
> > I think perhaps that's just about significant enough that maybe a fallback
> > compatible doesn't make sense here.  
> 
> Then let's keep it simple and just merge this patch as-is ? :-)
Makes sense. I'm on wrong computer at the moment but will pick it up at
weekend if not before.

Jonathan


> 
> > > > > ---
> > > > >  Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > > 
> > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > index 79da0323c327..e59db861e2eb 100644
> > > > > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > @@ -21,6 +21,7 @@ properties:
> > > > >        - ti,dac5573
> > > > >        - ti,dac6573
> > > > >        - ti,dac7573
> > > > > +      - ti,dac081c081
> > > > >        - ti,dac121c081
> > > > >  
> > > > >    reg:    
> 

Re: [PATCH 1/5] dt-bindings: iio: dac: ti,dac5571: Add DAC081C081 support

[Jonathan Cameron]

On Tue, 26 Mar 2024 17:13:16 +0000
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Tue, 26 Mar 2024 18:50:43 +0200
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> 
> > On Tue, Mar 26, 2024 at 03:29:27PM +0000, Jonathan Cameron wrote:  
> > > On Mon, 25 Mar 2024 22:56:41 +0200 Laurent Pinchart wrote:    
> > > > On Mon, Mar 25, 2024 at 08:48:57PM +0000, Jonathan Cameron wrote:    
> > > > > On Mon, 25 Mar 2024 22:32:41 +0200 Laurent Pinchart wrote:
> > > > >       
> > > > > > The DAC081C081 is a TI DAC whose software interface is compatible with
> > > > > > the DAC5571. It is the 8-bit version of the DAC121C081, already
> > > > > > supported by the DAC5571 bindings. Extends the bindings to support this
> > > > > > chip.
> > > > > > 
> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>      
> > > > > 
> > > > > Hi Laurent,
> > > > > 
> > > > > Given it's a part number where no one is going to guess it is compatible
> > > > > with the DAC5571 and that we don't have a history of fallback compatibles
> > > > > I'm fine with this change, but just wanted to ask is a fallback compatible
> > > > > useful to you to run with older kernels?
> > > > > 
> > > > > I should have noticed when Peter added the dac121c081. If we add a fallback
> > > > > should do that one as well.      
> > > > 
> > > > I've indeed noticed that there should have been a fallback for
> > > > dac121c081, but didn't stop to ponder why that wasn't the case, and just
> > > > went along with the flow :-) I agree a fallback could be useful, which
> > > > would then allow dropping patch 2/5 from this series (*). I can do so if
> > > > you prefer.
> > > > 
> > > > * This is not entirely true. While the DAC1081C081 is largely compatible
> > > > with the DAC5573, they have different values for one of the power-down
> > > > resistors (2.5kΩ instead of 1kΩ if I recall correctly). To be completely
> > > > accurate, the driver should report that. We could still use the fallback
> > > > compatible, reporting the wrong power-down resistor value.    
> > > 
> > > Hmm - Would anyone really care about that value being wrong?    
> > 
> > I don't have enough expertise with IIO to be sure, but my guess is that
> > nobody would.
> >   
> > > I think perhaps that's just about significant enough that maybe a fallback
> > > compatible doesn't make sense here.    
> > 
> > Then let's keep it simple and just merge this patch as-is ? :-)  
> Makes sense. I'm on wrong computer at the moment but will pick it up at
> weekend if not before.
Sooner it is.  Applied 1 and 2 to the togreg branch of iio.git and pushed
out as testing on the extremely unlikely chance that 0-day finds a build
issue...

I grabbed them today because I have a memory like a gold fish and the thread
is deep enough that I might skip over later on basis 'it must have outstanding
questions' :)

Jonathan

> 
> Jonathan
> 
> 
> >   
> > > > > > ---
> > > > > >  Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml | 1 +
> > > > > >  1 file changed, 1 insertion(+)
> > > > > > 
> > > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > > index 79da0323c327..e59db861e2eb 100644
> > > > > > --- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
> > > > > > @@ -21,6 +21,7 @@ properties:
> > > > > >        - ti,dac5573
> > > > > >        - ti,dac6573
> > > > > >        - ti,dac7573
> > > > > > +      - ti,dac081c081
> > > > > >        - ti,dac121c081
> > > > > >  
> > > > > >    reg:      
> >   
> 

Re: [PATCH 4/5] dt-bindings: arm: Add Au-Zone Maivin AI Vision Starter Kit

[Laurent Pinchart]

Hi Krzysztof,

On Tue, Mar 26, 2024 at 08:11:34AM +0100, Krzysztof Kozlowski wrote:
> On 25/03/2024 21:32, Laurent Pinchart wrote:
> > The Maivin board is an AI vision starter kit sold by Au-Zone
> > Technologies, developed in collaboration with Toradex and Vision
> > Components. It is based on a Toradex Verdin i.MX8MP SoM.
> > 
> > Add a corresponding compatible string.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 0027201e19f8..d892c4f9fda3 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1064,6 +1064,13 @@ properties:
> >                - toradex,verdin-imx8mp-wifi  # Verdin iMX8M Plus Wi-Fi / BT Modules
> >            - const: fsl,imx8mp
> >  
> > +      - description: Au-Zone Technologies i.MX8MP-based boards
> > +        items:
> > +          - const: au-zone,maivin-starter-kit        # Au-Zone Maivin AI Vision Starter Kit
> > +          - const: toradex,verdin-imx8mp-nonwifi     # Verdin iMX8M Plus Module without Wi-Fi / BT
> > +          - const: toradex,verdin-imx8mp             # Verdin iMX8M Plus Module
> 
> I think this should be part of existing "Toradex Boards with Verdin
> iMX8M Plus Modules)", just renamed to "boards using Toradex Verdin ...".

Is this what you have in mind ?

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index d892c4f9fda3..df5a04ab83a0 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1106,9 +1106,10 @@ properties:
           - const: polyhex,imx8mp-debix-som-a       # Polyhex Debix SOM A
           - const: fsl,imx8mp

-      - description: Toradex Boards with Verdin iMX8M Plus Modules
+      - description: Boards using Toradex Verdin iMX8M Plus Modules
         items:
           - enum:
+              - au-zone,maivin-starter-kit           # Au-Zone Maivin AI Vision Starter Kit
               - toradex,verdin-imx8mp-nonwifi-dahlia # Verdin iMX8M Plus Module on Dahlia
               - toradex,verdin-imx8mp-nonwifi-dev    # Verdin iMX8M Plus Module on Verdin Development Board
               - toradex,verdin-imx8mp-nonwifi-mallow # Verdin iMX8M Plus Module on Mallow

-- 
Regards,

Laurent Pinchart

Re: [PATCH 4/5] dt-bindings: arm: Add Au-Zone Maivin AI Vision Starter Kit

[Krzysztof Kozlowski]

On 27/03/2024 02:01, Laurent Pinchart wrote:
> Hi Krzysztof,
> 
> On Tue, Mar 26, 2024 at 08:11:34AM +0100, Krzysztof Kozlowski wrote:
>> On 25/03/2024 21:32, Laurent Pinchart wrote:
>>> The Maivin board is an AI vision starter kit sold by Au-Zone
>>> Technologies, developed in collaboration with Toradex and Vision
>>> Components. It is based on a Toradex Verdin i.MX8MP SoM.
>>>
>>> Add a corresponding compatible string.
>>>
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index 0027201e19f8..d892c4f9fda3 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -1064,6 +1064,13 @@ properties:
>>>                - toradex,verdin-imx8mp-wifi  # Verdin iMX8M Plus Wi-Fi / BT Modules
>>>            - const: fsl,imx8mp
>>>  
>>> +      - description: Au-Zone Technologies i.MX8MP-based boards
>>> +        items:
>>> +          - const: au-zone,maivin-starter-kit        # Au-Zone Maivin AI Vision Starter Kit
>>> +          - const: toradex,verdin-imx8mp-nonwifi     # Verdin iMX8M Plus Module without Wi-Fi / BT
>>> +          - const: toradex,verdin-imx8mp             # Verdin iMX8M Plus Module
>>
>> I think this should be part of existing "Toradex Boards with Verdin
>> iMX8M Plus Modules)", just renamed to "boards using Toradex Verdin ...".
> 
> Is this what you have in mind ?
> 

Yes.


Best regards,
Krzysztof

Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

[Shawn Guo]

On Mon, Mar 25, 2024 at 10:32:45PM +0200, Laurent Pinchart wrote:
> The Maivin board is an AI vision starter kit sold by Au-Zone
> Technologies, developed in collaboration with Toradex and Vision
> Components. It is based on a Toradex Verdin i.MX8MP SoM.
> 
> Add a device tree that covers the base set the peripherals found on the
> board:
> 
> - Ethernet
> - USB
> - SD card slot
> - CAN and serial ports (RS232 and RS485)
> - DACs, EEPROMs, temperature sensor
> - PCI M.2 and CSI regulators
> 
> An additional pinctrl group is included for the M.2 modem, but hasn't
> been tested due to lack of compatible hardware.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../boot/dts/freescale/imx8mp-maivin.dts      | 236 ++++++++++++++++++
>  2 files changed, 237 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 045250d0a040..03af8c242649 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -165,6 +165,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb
> +dtb-$(CONFIG_ARCH_MXC) += imx8mp-maivin.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb
>  dtb-$(CONFIG_ARCH_MXC) += imx8mp-skov-revb-hdmi.dtb
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> new file mode 100644
> index 000000000000..2d1c8e782465
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> @@ -0,0 +1,236 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
> +/*
> + * Copyright 2021 Au-Zone Technologies
> + * Copyright 2024 Ideas on Board
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/leds/common.h>
> +
> +#include "imx8mp-verdin.dtsi"
> +#include "imx8mp-verdin-nonwifi.dtsi"
> +
> +/ {
> +	model = "Au-Zone Maivin AI Vision Starter Kit";
> +	compatible = "au-zone,maivin-starter-kit",
> +		     "toradex,verdin-imx8mp-nonwifi",
> +		     "toradex,verdin-imx8mp",
> +		     "fsl,imx8mp";
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&pinctrl_sw1>;
> +
> +		button-0 {
> +			label = "SW1";
> +			linux,code = <BTN_MISC>;
> +			interrupts-extended = <&gpio3 16 IRQ_TYPE_LEVEL_LOW>;
> +		};
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-0 = <&pinctrl_led>;
> +
> +		led-0 {
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_STATUS;
> +			linux,default-trigger = "heartbeat";
> +			gpios = <&gpio3 14 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +
> +	csi_3v3: regulator-csi-3v3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "CSI_3V3";
> +		pinctrl-0 = <&pinctrl_csi_3v3>;
> +		gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +		startup-delay-us = <50000>;	/* TODO: Determine the right value */
> +	};
> +
> +	m2_3v3: regulator-m2-3v3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "M2_3V3";
> +		regulator-max-microvolt = <3300000>;
> +		regulator-min-microvolt = <3300000>;
> +		pinctrl-0 = <&pinctrl_m2_3v3>;
> +		gpio = <&gpio3 1 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
> +
> +	/* Carrier Board Supply 3V3_SW */
> +	reg_3v3: regulator-3v3-sw {
> +		compatible = "regulator-fixed";
> +		regulator-max-microvolt = <3300000>;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-name = "3V3_SW";
> +	};
> +};
> +
> +&eqos {
> +	status = "okay";
> +};
> +
> +/* Verdin CAN_1 */
> +&flexcan1 {
> +	status = "okay";
> +};
> +
> +/* Verdin CAN_2 */
> +&flexcan2 {
> +	status = "okay";
> +};
> +
> +/* Verdin I2C_2_DSI */
> +&i2c2 {
> +	status = "okay";
> +
> +	clock-frequency = <400000>;
> +	scl-gpios = <&gpio5 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +	sda-gpios = <&gpio5 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;

We usually end property list with 'status'.

> +
> +	dac@d {
> +		compatible = "ti,dac081c081";
> +		reg = <0x0d>;
> +		vref-supply = <&csi_3v3>;
> +	};
> +};
> +
> +/* Verdin I2C_4_CSI */
> +&i2c3 {
> +	status = "okay";
> +
> +	dac@d {
> +		compatible = "ti,dac081c081";
> +		reg = <0x0d>;
> +		vref-supply = <&csi_3v3>;
> +	};
> +};
> +
> +/* Verdin I2C_1 */
> +&i2c4 {
> +	status = "okay";
> +
> +	temp-sensor@4b {
> +		compatible = "ti,tmp102";
> +		reg = <0x4b>;
> +	};
> +
> +	/* EEPROM on the rear connector interface */
> +	eeprom@54 {
> +		compatible = "st,24c02", "atmel,24c02";
> +		pagesize = <16>;
> +		reg = <0x54>;
> +	};
> +};
> +
> +/* EEPROM on the carrier board */
> +&eeprom_carrier_board {
> +	status = "okay";
> +};
> +
> +&iomuxc {
> +	pinctrl_csi_3v3: csi-3v3-grp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_NAND_DATA01__GPIO3_IO07		0x184	/* SODIMM 58 */
> +		>;
> +	};
> +
> +	gpio7grp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_SAI1_RXD1__GPIO4_IO03		0x82	/* SODIMM 220 */
> +		>;
> +	};
> +
> +	gpio8grp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_SAI1_RXC__GPIO4_IO01		0x82	/* SODIMM 222 */
> +		>;
> +	};
> +
> +	pinctrl_led: ledgrp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_NAND_DQS__GPIO3_IO14		0x82	/* SODIMM 66 */
> +		>;
> +	};
> +
> +	/* M.2 power off and reset */
> +	pinctrl_m2: m2grp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_NAND_DATA00__GPIO3_IO06		0x82	/* SODIMM 56 */
> +			MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09		0x82	/* SODIMM 62 */
> +		>;
> +	};
> +
> +	pinctrl_m2_3v3: m2-3v3-grp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_NAND_CE0_B__GPIO3_IO01		0x82	/* SODIMM 54 */
> +		>;
> +	};
> +
> +	pinctrl_sw1: sw1grp {
> +		fsl,pins = <
> +			/*
> +			 * SW1 shortens the pin to ground when pressed, enable
> +			 * the internal pull-up.
> +			 */
> +			MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16		0x1c0	/* SODIMM 64 */
> +		>;
> +	};
> +};
> +
> +&reg_usdhc2_vmmc {
> +	vin-supply = <&reg_3v3>;
> +};
> +
> +/* Verdin UART_1 */
> +/* Enabling RS-485 operation */
> +&uart1 {
> +	fsl,uart-has-rtscts;

uart-has-rtscts instead.

Shawn

> +	linux,rs485-enabled-at-boot-time;
> +};
> +
> +/* Verdin UART_2, for M.2 card slot */
> +&uart2 {
> +	status = "okay";
> +};
> +
> +/* Verdin UART_3, used as the Linux Console */
> +&uart3 {
> +	status = "okay";
> +};
> +
> +/* Verdin USB_1, USB recovery */
> +&usb3_phy0 {
> +	status = "okay";
> +};
> +
> +&usb3_0 {
> +	status = "okay";
> +};
> +
> +&usb_dwc3_0 {
> +	status = "okay";
> +};
> +
> +/* Verdin USB_2, for M.2 card slot */
> +&usb3_phy1 {
> +	status = "okay";
> +};
> +
> +&usb3_1 {
> +	status = "okay";
> +};
> +
> +&usb_dwc3_1 {
> +	status = "okay";
> +};
> +
> +/* Verdin SD_1, for SD card slot */
> +&usdhc2 {
> +	status = "okay";
> +};
> -- 
> Regards,
> 
> Laurent Pinchart
> 

Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

[Francesco Dolcini]

Hello Laurent,

On Wed, Apr 03, 2024 at 08:30:11AM +0800, Shawn Guo wrote:
> On Mon, Mar 25, 2024 at 10:32:45PM +0200, Laurent Pinchart wrote:
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> > new file mode 100644
> > index 000000000000..2d1c8e782465
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> > @@ -0,0 +1,236 @@

[...]

> > +/* Verdin I2C_2_DSI */
> > +&i2c2 {
> > +	status = "okay";
> > +
> > +	clock-frequency = <400000>;
> > +	scl-gpios = <&gpio5 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> > +	sda-gpios = <&gpio5 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> 
> We usually end property list with 'status'.

This is now a written and explicit guideline, no longer tribal knowledge,
see https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node

Francesco

Re: [PATCH 5/5] arm64: dts: Add device tree source for the Au-Zone Maivin Starter Kit

[Laurent Pinchart]

On Wed, Apr 03, 2024 at 09:06:51AM +0200, Francesco Dolcini wrote:
> Hello Laurent,
> 
> On Wed, Apr 03, 2024 at 08:30:11AM +0800, Shawn Guo wrote:
> > On Mon, Mar 25, 2024 at 10:32:45PM +0200, Laurent Pinchart wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> > > new file mode 100644
> > > index 000000000000..2d1c8e782465
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-maivin.dts
> > > @@ -0,0 +1,236 @@
> 
> [...]
> 
> > > +/* Verdin I2C_2_DSI */
> > > +&i2c2 {
> > > +	status = "okay";
> > > +
> > > +	clock-frequency = <400000>;
> > > +	scl-gpios = <&gpio5 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> > > +	sda-gpios = <&gpio5 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> > 
> > We usually end property list with 'status'.
> 
> This is now a written and explicit guideline, no longer tribal knowledge,
> see https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node

Thanks.

Any chance to teach checkpatch.pl (and/or the DT checker) about that ? :-)

-- 
Regards,

Laurent Pinchart