devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick DELAUNAY <patrick.delaunay@foss.st.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH v2] dt-bindings: mfd: stm32: Remove unnecessary blank lines
Date: Tue, 18 Apr 2023 15:03:52 +0200	[thread overview]
Message-ID: <f2ad2414-526e-8b9b-aa95-a35953556f36@foss.st.com> (raw)
In-Reply-To: <fde49fb8-c337-3a6b-811e-b9d7c3620393@linaro.org>

Hi,

On 4/18/23 09:22, Krzysztof Kozlowski wrote:
> On 17/04/2023 18:14, Patrick Delaunay wrote:
>> Remove double blank line.
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> ---
>>
>> Changes in v2:
>> - update commit title and commit message to reflect what the change is
>>    V1="dt-bindings: mfd: stm32: Fix STM32F4 DT include fil
> More than one file has the same issue. This is quite a churn to handle
> such patch one by one. Please fix all of them or just skip, as it is
> harmless.


To be crystal clear, it is minor difference between files in U-Boot

and in Linux, just because we correct the check-patch errors

when this file for STM32F4 was up streamed in U-Boot.


I prefer correct this line in the Linux file and no having

this difference for each device tree synchronization with U-Boot.


But if you prefer, you can drop this modification and

I will align U-Boot file with this error.


Alexandre: it could part of patch for STM32 files clean-up ?

scripts/checkpatch.pl -f include/dt-bindings/*/*stm*

scripts/checkpatch.pl -f arch/arm/boot/dts/stm*


>
> Best regards,
> Krzysztof


Regards

Patrick



  reply	other threads:[~2023-04-18 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 16:14 [PATCH v2] dt-bindings: mfd: stm32: Remove unnecessary blank lines Patrick Delaunay
2023-04-18  7:22 ` Krzysztof Kozlowski
2023-04-18 13:03   ` Patrick DELAUNAY [this message]
2023-04-18 13:19     ` Krzysztof Kozlowski
2023-04-20 10:37   ` Lee Jones
2023-04-20 10:36 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2ad2414-526e-8b9b-aa95-a35953556f36@foss.st.com \
    --to=patrick.delaunay@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).