From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="e82s3Tzu"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="HwSdQyAW" Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C22F098; Tue, 5 Dec 2023 05:14:58 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 395F35C013F; Tue, 5 Dec 2023 08:14:58 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 05 Dec 2023 08:14:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701782098; x=1701868498; bh=ei yfcAaW8S/0cnNR5qvKPP9FPzFqObUKOJebJtjaT4g=; b=e82s3TzuEm8iFGHKNS Gcw1xRqRWMIt+B+zrl3U0DcuJVDFwt45xi8LiyrETrtYnQ1wwLupBHoIqQsyddf6 xLgfDKb1dMSQmJoElVvQt15tbGwy7+iNWi3jKg2rDxwVif5N6YS1cuKreesIgPUq zD3DE4jkp+gB/bwz0CQTZYkghmZZNUTR5KlpTidQP9XU7RUUmL+hZipJ2tmXS7hA bZyy5sT9uwijI6dPCHPag6D/oDN/VF3NFZp4mmCIvfl/cPq3WmTafwg/7a3AVA8u IGUyrUlV/e8uCgKAnb/Cvf5cOBPJH88SX3/NTZXJ/FsHE0dClpcWsXkubmTc2Wfv R1Ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701782098; x=1701868498; bh=eiyfcAaW8S/0c nNR5qvKPP9FPzFqObUKOJebJtjaT4g=; b=HwSdQyAWxW10UNefYT+kXCz5FDcjS W3AhGVkVloQUOHSnpjTfkkghKOTbu44s5p8TcKhEl+SnyyLVMc3/Xjpvc2Ek8ySH NuHNha8/kVEiyuotDB7hzu2/jYnZPzJEXWNrwtH4Yg8Fnt/K/VnXGEdS57TabMmN ii8E3FocogroF9nuQ7oJOXEn26CU5wWcNFfzvz6cIAt4arVC5ovnC9okSdw0APMo Nre8n6G9+BX/KZeaMvpa+Jv9S3TDwSLxOff1e/Y0/efyNaYBKuaDxSfhlXmiZrIl CJ70bTRP9NN591XKuEzxPMzeRferbt7Xul1BBNaJWzOhfvLV1higsQPpQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudejkedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7F054B60089; Tue, 5 Dec 2023 08:14:57 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: In-Reply-To: <76bbd45b22ef6cc1fa69369aff908c9c4e366860.1701768028.git.ysato@users.sourceforge.jp> References: <76bbd45b22ef6cc1fa69369aff908c9c4e366860.1701768028.git.ysato@users.sourceforge.jp> Date: Tue, 05 Dec 2023 14:14:37 +0100 From: "Arnd Bergmann" To: "Yoshinori Sato" , linux-sh@vger.kernel.org Cc: "Damien Le Moal" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Geert Uytterhoeven" , "Michael Turquette" , "Stephen Boyd" , "Dave Airlie" , "Daniel Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Thomas Gleixner" , "Lorenzo Pieralisi" , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , "Bjorn Helgaas" , "Greg Kroah-Hartman" , "Jiri Slaby" , "Magnus Damm" , "Daniel Lezcano" , "Rich Felker" , "John Paul Adrian Glaubitz" , "Lee Jones" , "Helge Deller" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , "Jernej Skrabec" , "Chris Morgan" , "Linus Walleij" , "Randy Dunlap" , "Hyeonggon Yoo" <42.hyeyoo@gmail.com>, "David Rientjes" , "Vlastimil Babka" , "Baoquan He" , "Andrew Morton" , "Guenter Roeck" , "Stephen Rothwell" , guoren , "Javier Martinez Canillas" , "Azeem Shaikh" , "Palmer Dabbelt" , "Bin Meng" , "Max Filippov" , "Tom Rix" , "Herve Codina" , "Jacky Huang" , "Lukas Bulwahn" , "Jonathan Corbet" , "Biju Das" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Sam Ravnborg" , "Michael Karcher" , "Sergey Shtylyov" , "Laurent Pinchart" , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux-Renesas , linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [DO NOT MERGE v5 06/37] sh: kernel/setup Update DT support. Content-Type: text/plain On Tue, Dec 5, 2023, at 10:45, Yoshinori Sato wrote: > Fix extrnal fdt initialize and bootargs. > > Signed-off-by: Yoshinori Sato > --- > arch/sh/kernel/setup.c | 51 ++++++++++++++++++++++++++++-------------- > 1 file changed, 34 insertions(+), 17 deletions(-) > > diff --git a/arch/sh/kernel/setup.c b/arch/sh/kernel/setup.c > index 3d80515298d2..b299abff68e0 100644 > --- a/arch/sh/kernel/setup.c > +++ b/arch/sh/kernel/setup.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -74,7 +75,13 @@ extern int root_mountflags; > #define RAMDISK_PROMPT_FLAG 0x8000 > #define RAMDISK_LOAD_FLAG 0x4000 > > +#if defined(CONFIG_OF) && !defined(CONFIG_USE_BUILTIN_DTB) > +#define CHOSEN_BOOTARGS > +#endif > + > +#ifndef CHOSEN_BOOTARGS > static char __initdata command_line[COMMAND_LINE_SIZE] = { 0, }; > +#endif I think an appended DTB is generally better than a built-in one, as that allows you to still have a single kernel image across machines and just pick the dtb when installing it. With everything else being equal, I would suggest not actually making this an option for new platforms. Arnd