From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4870131747 for ; Fri, 2 Feb 2024 10:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706870003; cv=none; b=LhKROBoR78RCc+5TyItC167ysIhFVvJ+TujVoAKjxSzR6Jl93y29Alc2N+QWJx9JBzPXc4TjKrNvAMmBrys7k/6PLCYIdOJXGfANr64IcQF8XHa5VufDPnPduvV2iQDUQgHGSdlpa3zdZpPbvoHN0cCWk0CxnJrZuXkJC7iwqzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706870003; c=relaxed/simple; bh=DMMt/shyGWqcD+ib28kiLpaMXR+euETZG735wBIYD+c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=flSI9D27SN6qlPzxdnGGM2YlJ8ZaTAApeaT8Vln+mTUikN5pkSPdTkc2fAevbUz/hkxSXb5hW1fJqBBmFxjyk/gesT7s0Gwa4y2A1RnefyPDWFpVhG20BqEc1QoG0P9w84wp8fHZB7iDaKis/pO5IRQDc9IJsALRKlk06oVS/FI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=negZTzXR; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="negZTzXR" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d722740622so3449575ad.0 for ; Fri, 02 Feb 2024 02:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706870001; x=1707474801; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T8iHE479YVvdQnvL1fZ7V63tnI2/lAPeZVx8YhIJp00=; b=negZTzXRrjRf79V0Fa9wwXTO+vGf1SvuWwD9EL7YSCEc3Vi7mh40+Vt/R9kmVFnh+O quYQE8upbtGWkVftruWEetnbd9P2I2NmZBPx5MviTLeDVLNzeVoiCvRW5+MqgGLhIYes nnoKS8t+fdAyY4I4rbYfhgUyphZByzl+mob3zoBJDNd57Atl9pK0moK1A3C28nhW//4U CbJPl3mNUsM5MhZq8qfGD2/0dixngpqh0ZDlumdOfaVzWIBZSGtZRwSQVXVdR9heJuYd nL4AckRHPNbhK5eLeFg2qr8hh32MDK9ZijtdlDR5HKjeNgf4RD338n6jgD4WDJBWe3PX oWiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706870001; x=1707474801; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T8iHE479YVvdQnvL1fZ7V63tnI2/lAPeZVx8YhIJp00=; b=bdMr7o6NVKJ9qdPEeAjh2ZTCahy3QzbNoS8pC52b0dyU0QyNuQvYK+0LPJMGwWaKhz +jlVlfxU1jBvZiOa/1fFSXOYyTz32nitXsAtAz6sMqZn3v7kpRBPSrJcVsRP4kt8Y2yw tV93zDQfUW9GaZ0775K1GMxiz0v5nAD5sYaDdGBCxhgwX/GujPiBgwdhm6c8XEY+j3AI sxWvmUmRiTERX3dyv6U4I4eQMq/2xz+WtkxnZ67ywzillVQTGiPxhBh+x+JHlwmU0LsA jmpTVjl9tcH7C3nF70xQagMiTVROhODvJvKejGVN/6BM8mq41BDIhqZ8UhBv0JVMJbPq QBvg== X-Gm-Message-State: AOJu0YxTuRKpmz1H3l0THj9vb/Np2b444CgeHvtLP+do0SUI0wb5UIhb 6jxWf6Qb0ZGPOR3M9kvU7V0Manp/ZzUsO8GKhd558u4In2VXCmJ5DBuYQRPTqhc= X-Google-Smtp-Source: AGHT+IF6Vbai2YBU7cb51y8R4IB03FxPQx+BBkX/tfJTtHIPiA0XBZiwJtgRNHGa4tUQp7qa7GJeHQ== X-Received: by 2002:a05:6a20:7486:b0:19c:9c10:fa27 with SMTP id p6-20020a056a20748600b0019c9c10fa27mr5462240pzd.4.1706870000941; Fri, 02 Feb 2024 02:33:20 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUE4ny+RfqFrQN3ryErdIfcptjtiUDXiAnUOdO8oSK4hhFsFYWe37sJfIbcmbdh+n9iSFjmgJOylcGTuWgAnnJg8Ck/toMJwjx3Ha9RnlqV0ti/2dFnQVZ4XXCGAStK0s2Bkkj1LHDNHM6CSubetnEajPBYkxC9xYe/G2BeVKyhgcaF6HhrN9qRhNvnyt5NjRqcXjz3sZdsydpAemlP78SDJi21qiUfnV29zoyoqabPyCl2nt0H0NYH35uo6WJrrCjbLgTKxjk6x1J6HbmZpTnQEPVhPZmKYb1gqK2wJKCZc4D+XUbi0NdKaStXWC6Vu4NHC+Hz4pUUyObRAR3LxOueT3GnzfZoxQOZZGec1yObxzzYUR8awfMF6wo67wFXPDV6hG5v/4uxm0ip6MUS7ITWAjHGGRMBU2GPGgj2yov3Ln5fyYNe98r7y1G06yaZnA6A0ow5DAu4sxD2sZn2YJVJmrMLRIQCuGgI+YsviiAkLZ4MGpbDyMQZfXjvqhKzSoaG3+OaLdOeywYmOwTtFwAxgHgh8APY6t9bD7HG4EoJLE/rjmHWih00OTsF9hVw6ayr/q6SEo2XzVwHOt20RQ== Received: from ?IPV6:2a01:e0a:999:a3a0:6d51:959f:bb28:92? ([2a01:e0a:999:a3a0:6d51:959f:bb28:92]) by smtp.gmail.com with ESMTPSA id mj10-20020a17090b368a00b002963e682f6fsm1111059pjb.57.2024.02.02.02.33.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Feb 2024 02:33:20 -0800 (PST) Message-ID: Date: Fri, 2 Feb 2024 11:33:05 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 22/25] irqchip: Add RISC-V advanced PLIC driver for direct-mode Content-Language: en-US To: Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , devicetree@vger.kernel.org, Saravana Kannan , Marc Zyngier , Anup Patel , linux-kernel@vger.kernel.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Atish Patra , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Andrew Jones References: <20240127161753.114685-1-apatel@ventanamicro.com> <20240127161753.114685-23-apatel@ventanamicro.com> From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 02/02/2024 11:30, Anup Patel wrote: >>> +int aplic_setup_priv(struct aplic_priv *priv, struct device *dev, >>> + void __iomem *regs) >>> +{ >>> + struct of_phandle_args parent; >>> + int rc; >>> + >>> + /* >>> + * Currently, only OF fwnode is supported so extend this >>> + * function for ACPI support. >>> + */ >>> + if (!is_of_node(dev->fwnode)) >>> + return -EINVAL; >>> + >>> + /* Save device pointer and register base */ >>> + priv->dev = dev; >>> + priv->regs = regs; >>> + >>> + /* Find out number of interrupt sources */ >>> + rc = of_property_read_u32(to_of_node(dev->fwnode), >>> + "riscv,num-sources", >>> + &priv->nr_irqs); >> >> Use device_property_read_u32() which works for both ACPI and OF. > > In the previous versions, we did try to unify property reading for > both ACPI and OF but MarcZ suggested to keep th ACPI and > OF probe paths totally separate hence we use OF APIs over > here because we should reach here only for OF probing. Ok, indeed it makes sense. Discard that comment then ! Thanks, Clément