From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B17D8C6FA8F for ; Thu, 24 Aug 2023 12:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237200AbjHXMl5 (ORCPT ); Thu, 24 Aug 2023 08:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239241AbjHXMlr (ORCPT ); Thu, 24 Aug 2023 08:41:47 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 323AC198B for ; Thu, 24 Aug 2023 05:41:45 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5007616b756so7507075e87.3 for ; Thu, 24 Aug 2023 05:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692880903; x=1693485703; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BAkSr3Gk0g2+5udpa+hB8OshiUKIlJ+N0mzFCMWze0o=; b=IP+FLy7Q0SrCfI2pJZRd+41YwJooNenYVpinCZQmIDhcOVAYhurpTFudt/lCgl6V8c AQZKWMQcke7ZFuakVie0TjNg/wBu/eoIM97Ilypdo0uwzNebev9nUJtyejs/du9F8XB4 HjyT5NRcMyxBK1kWFTkpzZyNd1x/NktQJ9MWcsSTXqh/b7nCx0um+w5xIcYXb266zwKx 56h4zdsXfv4fQlJxaAMYm32mf6eiVrIAgkghoZ/dZaSUmwlaRgARg7DGmHmV2wEwdvBD QGHP90klsohOA3EEjoMGBgc717vV2dsmR0ssDRCdCKnvA4I+k/9+KnTiXa0nVw0yVY5e OPqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692880903; x=1693485703; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BAkSr3Gk0g2+5udpa+hB8OshiUKIlJ+N0mzFCMWze0o=; b=fsHf9on5t0/dr43X4YMNalNIiJDX0SrYKQunGSYKFXjmxqSc0ZdQR2zC+RqH52CLN3 PQyzKHN6FuDPn9HGr6ckgyc7GEjqUDjzSuf07yzRWQ3iHYLZ/zspBc09IZUtfm3NDlbn gEP5SuGpEwxi/s3oCZN+JhnnvDgQJ3xajAOTG1G62tEvRn+yfpl1fwuvs/NXTFDAvYLb zE+d1EPBHXUUwwvvci5U9BD9z/R37teUOVJrT4aTuy7C5junHBneJ4IBd2ItzLyQkjcY leXy3NuPrLLYJP12ofzdPmAItFHxoNzE3gJKQAaNFUwxh9t+bnoOxBYOuiUV0aRpWAAr RByQ== X-Gm-Message-State: AOJu0YzFdbpysqJcym7m5Q8/U8ShLI2p/5hJFRkvI66uVKj+7qxYHz/L XA/1pZgG3RZ5PyJX/mWj7fcwYg== X-Google-Smtp-Source: AGHT+IEOhpCT+JRJbh18sqyr+ORLms1Mm5XeQll9vnvq5Coz0JDnyJlnQU82T0VOl62OFRLGCkFBvA== X-Received: by 2002:ac2:4c82:0:b0:4fd:d92e:31ca with SMTP id d2-20020ac24c82000000b004fdd92e31camr10795414lfl.36.1692880903422; Thu, 24 Aug 2023 05:41:43 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id b4-20020aa7d484000000b0052a1c0c859asm3771727edr.59.2023.08.24.05.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 05:41:42 -0700 (PDT) Message-ID: Date: Thu, 24 Aug 2023 14:41:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/2] power: supply: bq24190_charger: Export current regulator Content-Language: en-US To: Emmanuel Gil Peyrot Cc: Alexandre Courbot , azkali , CTCaer , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230824112741.201353-1-linkmauve@linkmauve.fr> <20230824112741.201353-3-linkmauve@linkmauve.fr> From: Krzysztof Kozlowski In-Reply-To: <20230824112741.201353-3-linkmauve@linkmauve.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/08/2023 13:27, Emmanuel Gil Peyrot wrote: > From: Alexandre Courbot Empty commit msg. Sorry, we cannot take such commits. > > Signed-off-by: Alexandre Courbot Missing SoB. > --- > drivers/power/supply/bq24190_charger.c | 84 ++++++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c > index a56122b39687..8c026e86aeb3 100644 > --- a/drivers/power/supply/bq24190_charger.c > +++ b/drivers/power/supply/bq24190_charger.c > @@ -530,6 +530,81 @@ static int bq24190_set_otg_vbus(struct bq24190_dev_info *bdi, bool enable) > } > > #ifdef CONFIG_REGULATOR > +static int bq24190_set_charging_current(struct regulator_dev *dev, > + int min_uA, int max_uA) > +{ > + struct bq24190_dev_info *bdi = rdev_get_drvdata(dev); > + u8 ss_reg; > + int in_current_limit; > + int ret = 0; > + > + dev_info(bdi->dev, "Setting charging current %d mA\n", max_uA/1000); This is not info. It would pollute log and it is not really necessary, because regulator framework gives such information. You can make it debug if you need for debug purposes. Best regards, Krzysztof