From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 214861426C; Sat, 21 Jun 2025 15:51:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750521100; cv=none; b=udTewYSw9AK+lB1CvnfDioTjWRk94WpWlhmQuxQn0t+MCVxElfAJgmhu6JSy+G1uikReKnEKfrYSRdiNDkZ5NrRmuK7p8cWxkTeLEfG5JABpVR4GCLvr5wYBlTD0fw+M+vHrEdNJSVgSSBRBkHBIhlwVe+qYngV/nDH0ivExc+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750521100; c=relaxed/simple; bh=RwP81emvQorDLrxRkfUbpFTx2KvYq1XkDDhakXZLA38=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=elt1qELhyhj+FnWqUXwqz+VQP5VayAN8bxYY6HuYCQknhfoUInqaS8mMQgXy/6nXOdzseL+z+8atDTybUZiO6NxSFXUFsKR77xbbvodGRj8MI8+Qi68qY+uRrkxfXp4GsNeKc2zDkJuDVmmW6cVJOO9l4qIw83Y+KV/4MTk2z2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aXtULFaV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aXtULFaV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78776C4CEE7; Sat, 21 Jun 2025 15:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750521099; bh=RwP81emvQorDLrxRkfUbpFTx2KvYq1XkDDhakXZLA38=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aXtULFaVgekIStsylN4vdg7HUyzivNz0nR/MJSwVzTkpruzTLf09+mzKvXkhSxwD6 RfdN8Od5f/jxKMfkRbddhs5qxoS+QoS46W+d0+b1qS8+AJxa+pObgodXZycAnqJbL5 gem5fqZiCD+HRYOrXaZXZmKHTNeK1QgLdynUz9VXQ5u4JDhZP5nOO3CQXZfDQZudBp d6cX58KTKDdUT5SRafdvX4onFl9UpYAy5YNgB7V0VjO2pugG98guCnmakD1DhOMOvP IbTJOhfMjLOTL7cCYtNtILPzxbrr9AtexQUIJRZ/m8HT5DhA72WLDVkeB3m3VNKief vEVYcskD2Qe6g== Message-ID: Date: Sat, 21 Jun 2025 17:51:33 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 05/10] mfd: Add Apple Silicon System Management Controller To: Lee Jones , Bartosz Golaszewski , Linus Walleij , Sebastian Reichel Cc: Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Hector Martin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marc Zyngier , "Russell King (Oracle)" , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20250610-smc-6-15-v7-0-556cafd771d3@kernel.org> <20250610-smc-6-15-v7-5-556cafd771d3@kernel.org> <20250619114958.GJ587864@google.com> Content-Language: en-US From: Sven Peter In-Reply-To: <20250619114958.GJ587864@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19.06.25 13:49, Lee Jones wrote: > On Tue, 10 Jun 2025, Sven Peter wrote: > >> The System Management Controller (SMC) on Apple Silicon machines is a >> piece of hardware that exposes various functionalities such as >> temperature sensors, voltage/power meters, shutdown/reboot handling, >> GPIOs and more. >> >> Communication happens via a shared mailbox using the RTKit protocol >> which is also used for other co-processors. The SMC protocol then allows >> reading and writing many different keys which implement the various >> features. The MFD core device handles this protocol and exposes it >> to the sub-devices. >> >> Some of the sub-devices are potentially also useful on pre-M1 Apple >> machines and support for SMCs on these machines can be added at a later >> time. >> >> Co-developed-by: Hector Martin >> Signed-off-by: Hector Martin >> Reviewed-by: Alyssa Rosenzweig >> Reviewed-by: Neal Gompa >> Signed-off-by: Sven Peter >> --- >> MAINTAINERS | 2 + >> drivers/mfd/Kconfig | 18 ++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/macsmc.c | 498 +++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/mfd/macsmc.h | 279 +++++++++++++++++++++++++ >> 5 files changed, 798 insertions(+) > > This is ready. Let me know when you have all of the other driver/* Acks. > They've all been reviewed by the respective maintainers. I assume you want to take this all through the mfd tree and we'll need acks from Sebastian for power/reset and either Linus or Bartosz for gpio then. The one line change inside drivers/soc/apple would usually go through my tree and I'm fine with taking that through mfd instead. Sven