From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Randy Dunlap" <rdunlap@infradead.org>,
linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org,
fbarrat@linux.vnet.ibm.com,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"Lee Jones" <lee.jones@linaro.org>,
"Jason M Biils" <jason.m.bills@linux.intel.com>,
sandeen@redhat.com,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
"Linux Doc Mailing List" <linux-doc@vger.kernel.org>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Joel Stanley" <joel@jms.id.au>,
bryantly@linux.vnet.ibm.com,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
david.kershner@unisys.com, "Guenter Roeck" <linux@roeck-us.net>,
"Wu Hao" <hao.wu@intel.com>,
"Linux HWMON List" <linux-hwmon@vger.kernel.org>,
"Jean Delvare" <jdelvare@suse.com>
Subject: Re: [PATCH v7 11/12] hwmon: Add PECI dimmtemp driver
Date: Mon, 30 Jul 2018 15:45:05 -0700 [thread overview]
Message-ID: <f3056c4d-1cc6-5fcd-f185-f6b0878e6326@linux.intel.com> (raw)
In-Reply-To: <CAL_JsqK4k=c6k-BJT5fWQH_DCqGhr13fq6M_iZZehaveE-z5Hg@mail.gmail.com>
Hi Rob,
On 7/30/2018 3:06 PM, Rob Herring wrote:
> On Mon, Jul 23, 2018 at 3:49 PM Jae Hyun Yoo
> <jae.hyun.yoo@linux.intel.com> wrote:
>>
>> This commit adds PECI dimmtemp hwmon driver.
>>
>
>> +#if IS_ENABLED(CONFIG_OF)
>> +static const struct of_device_id peci_dimmtemp_of_table[] = {
>> + { .compatible = "intel,peci-dimmtemp" },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, peci_dimmtemp_of_table);
>> +#endif
>
> This should be removed. Same for cpu temp driver I'm guessing.
>
Yes, you are right. This isn't needed anymore because MFD driver
loads this module. I'll remove this code from here and from cpu temp
driver. Also, I'll remove 'of_compatible' setting of 'struct mfd_cell
peci_functions' in intel-peci-client.c code.
Thanks a lot for your pointing it out!
Jae
> Rob
>
next prev parent reply other threads:[~2018-07-30 22:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 21:47 [PATCH v7 00/12] PECI device driver introduction Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 01/12] dt-bindings: Add a document of PECI subsystem Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 02/12] Documentation: ioctl: Add ioctl numbers for " Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 03/12] peci: Add support for PECI bus driver core Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 04/12] dt-bindings: Add a document of PECI adapter driver for ASPEED AST24xx/25xx SoCs Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 05/12] ARM: dts: aspeed: peci: Add PECI node Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 07/12] dt-bindings: mfd: Add a document for PECI client MFD Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 08/12] mfd: intel-peci-client: Add PECI client MFD driver Jae Hyun Yoo
2018-07-23 22:21 ` Randy Dunlap
2018-07-23 22:36 ` Jae Hyun Yoo
2018-07-27 8:26 ` Lee Jones
2018-07-27 17:36 ` Jae Hyun Yoo
2018-07-30 22:10 ` Rob Herring
2018-07-30 23:15 ` Jae Hyun Yoo
2018-07-31 7:01 ` Lee Jones
2018-07-31 18:56 ` Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 10/12] hwmon: Add PECI cputemp driver Jae Hyun Yoo
2018-07-23 21:47 ` [PATCH v7 11/12] hwmon: Add PECI dimmtemp driver Jae Hyun Yoo
2018-07-30 22:06 ` Rob Herring
2018-07-30 22:45 ` Jae Hyun Yoo [this message]
2018-07-23 21:47 ` [PATCH v7 12/12] Add maintainers for the PECI subsystem Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3056c4d-1cc6-5fcd-f185-f6b0878e6326@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=bryantly@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=david.kershner@unisys.com \
--cc=devicetree@vger.kernel.org \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=hao.wu@intel.com \
--cc=jason.m.bills@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=kishon@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sandeen@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).