From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Subject: Re: [PATCH v7 11/12] hwmon: Add PECI dimmtemp driver Date: Mon, 30 Jul 2018 15:45:05 -0700 Message-ID: References: <20180723214751.1733-1-jae.hyun.yoo@linux.intel.com> <20180723214751.1733-12-jae.hyun.yoo@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , Andrew Lunn , Randy Dunlap , linux-aspeed@lists.ozlabs.org, devicetree@vger.kernel.org, fbarrat@linux.vnet.ibm.com, Mauro Carvalho Chehab , Lee Jones , Jason M Biils , sandeen@redhat.com, Lorenzo Pieralisi , Jonathan Corbet , OpenBMC Maillist , Linux Doc Mailing List , Kishon Vijay Abraham I , Joel Stanley , bryantly@linux.vnet.ibm.com, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , david.kershner@unisys.com, Guenter Roeck , Wu Hao , Linux HWMON List , Jean Delvare , Arnd Bergmann List-Id: devicetree@vger.kernel.org Hi Rob, On 7/30/2018 3:06 PM, Rob Herring wrote: > On Mon, Jul 23, 2018 at 3:49 PM Jae Hyun Yoo > wrote: >> >> This commit adds PECI dimmtemp hwmon driver. >> > >> +#if IS_ENABLED(CONFIG_OF) >> +static const struct of_device_id peci_dimmtemp_of_table[] = { >> + { .compatible = "intel,peci-dimmtemp" }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, peci_dimmtemp_of_table); >> +#endif > > This should be removed. Same for cpu temp driver I'm guessing. > Yes, you are right. This isn't needed anymore because MFD driver loads this module. I'll remove this code from here and from cpu temp driver. Also, I'll remove 'of_compatible' setting of 'struct mfd_cell peci_functions' in intel-peci-client.c code. Thanks a lot for your pointing it out! Jae > Rob >