From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1121C6FD19 for ; Thu, 16 Mar 2023 19:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbjCPTYk (ORCPT ); Thu, 16 Mar 2023 15:24:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230271AbjCPTYd (ORCPT ); Thu, 16 Mar 2023 15:24:33 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 231CDC5AD2 for ; Thu, 16 Mar 2023 12:24:10 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id cy23so11732275edb.12 for ; Thu, 16 Mar 2023 12:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678994649; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SzpppHgdp3HaoNlsJcnGIedojO2IG2V6oWwyMef5ZzU=; b=SyLW7vL3Tn3yQ2sLcLkqMAbdCOxJhaNmygl1xALrzLufsF5n/p9TAqJoBTPVQEsygS ynAJlWo7kGe3KrLI1oczcsA+fmf+cKrlt3borfuHX2bysAzRuiyN/OB6e+DDUFX5vhmw beqJQi8Q0WR9EYFN5cdNFFL45TNClLYGWPKqBAj8KH87lEft+OAELJCX4wqRCSLCOC0b r+/PNjXn/oAjClPaUW447ppL1Y+P9v+qBaDuogGyboolKcyHpqadYfXRss8GcX7zJWZ4 wR4oAudAEArnf/ehWWUMK8WI5w80iKdPVoCHCh2XtDGcajEvHdsXbeGJ9Qt7tUpvdRkH nwig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678994649; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SzpppHgdp3HaoNlsJcnGIedojO2IG2V6oWwyMef5ZzU=; b=FipYfTH5x57fh+3J9SAk1iucjX2JDETBPKysyatb2FAgiHzbCvFdG6UYEMQ35FPIlZ kCxyhl4Ie5iri+ddvCHRmSLfte/IcDMXIKXBDLCU9VXJAunYBxh8oGTRzjrtOcNS8G0J vaH3i1zdKTXr27cEKtqHsEwsmJ+FmCEJWS0qk5h7sn0WDFT2MwPnCbATvfa7YGLUAT9/ lSuxqRkuskG20dPpfIRm1bIpo1iCofxZIyG8J/4jBZF+CduL5cvjbL0oux11w4k8qNyY cmAwTIAPir6H2S5/wCSxOAYswYVNiSk1mZgRunChzvI4JI/fh8lE4N0woTuMlFjee4vG BtFg== X-Gm-Message-State: AO0yUKU5LuCazV+aydZhlzGQC1aakX8vnRXXPSjeIQGSdoivaIgJhJU0 oJb4IYxAv3D8g+zeh3/P2VvfXQ== X-Google-Smtp-Source: AK7set8gHfAjemPrL6RUamqLp74FM/6pqGNqaxHeGFQnw8reoXzMaHfjYhzOaALtINM5R6UDMskg0g== X-Received: by 2002:a17:906:9f26:b0:92e:c4c9:7a43 with SMTP id fy38-20020a1709069f2600b0092ec4c97a43mr6844035ejc.25.1678994649358; Thu, 16 Mar 2023 12:24:09 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9827:5f65:8269:a95f? ([2a02:810d:15c0:828:9827:5f65:8269:a95f]) by smtp.gmail.com with ESMTPSA id v19-20020a17090651d300b0092b86d41dbasm10006ejk.114.2023.03.16.12.24.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 12:24:08 -0700 (PDT) Message-ID: Date: Thu, 16 Mar 2023 20:24:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: Add 'hold-in-reset-in-suspend' property to goodix Content-Language: en-US To: Jan Jasper de Kroon Cc: devicetree@vger.kernel.org, dmitry.torokhov@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org, alexandre.belloni@bootlin.com, kernel@undef.tools, linux-input@vger.kernel.org References: <20230311134655.486973-1-jajadekroon@gmail.com> <20230312183106.551840-1-jajadekroon@gmail.com> <4cdefb22-52ea-8f8f-12d2-7a07478f167c@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/03/2023 16:41, Jan Jasper de Kroon wrote: >> Anyway, the property does not look suitable for Devicetree. You describe >> system policy - trade off between energy saving and responsivness to the >> user. DT is not for policies. Use other interfaces for configuring it, >> e.g. some user-space, existing PM interfaces or /sysfs (which is ABI and >> needs its Documentation). >> >> >>> + >>> additionalProperties: false >>> >>> required: >>> @@ -75,6 +84,7 @@ examples: >>> interrupts = <0 0>; >>> irq-gpios = <&gpio1 0 0>; >>> reset-gpios = <&gpio1 1 0>; >>> + hold-in-reset-in-suspend; >>> }; >>> }; >>> >> Best regards, >> Krzysztof >> > I think the latest patch covers most of the feedback you provided. > Regarding the addition of this feature to the DeviceTree. Currently this > is only used on the Linux powered PinePhone Original and PinePhone Pro. It > also isn't really a policy change, What is "policy change"? I said it is system policy. > but rather an attempt to minimize > battery consumption on these power hungry devices. We do not talk about the goal, but whether this is property of Devicetree or not. > Developers made a lot > of tweaks here and there, to make the PinePhone get through a day of light > use. This is one of these tweaks. Awesome, how is this related to my concerns that it is not suitable for Devicetree? Developers can invent thousands of things, shall we put them all to Devicetree? Bring specific arguments to my questions. Arguing that it is not a "policy change" is not related to my question. Just like calling something tweaks. Best regards, Krzysztof