From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE670C4332F for ; Thu, 10 Nov 2022 14:06:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229537AbiKJOGD (ORCPT ); Thu, 10 Nov 2022 09:06:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbiKJOGB (ORCPT ); Thu, 10 Nov 2022 09:06:01 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5E377238 for ; Thu, 10 Nov 2022 06:05:57 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id j4so3519442lfk.0 for ; Thu, 10 Nov 2022 06:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mU1T17TmUMKJ1FQ3DqAQW105Hs0gFl2y7tVhnhRI/Pc=; b=TB/vlAiX1GaWtQtKZx92rFo7cAYyi7aiddPgCvt8+fucqf+/SW3ZmGdWeNWdfad+kY +ZPQT12nxPZrd/UJrsgOSzEKNWgsHWYZfs1ynhOkN2a1xER4lSEeuwU1V5ZWP3JRq0zJ hTphh2uY4UQT4ihCMuRPzvE7JY9w6yGEx7vVBTU4F3Q3S1/REOL8szTSk/7YaDu+OfxZ t7oPmrtLCOIjG59YpyjWMB2IHddqtpqXByi+/zMY2cRkDRmUKzVCcV9Xp2GTlqt+W1aR V03dtiOcFoxLSYxjrDOL6jRL/CL8hR51BW/m9JRFWuasiJLE7Z5Mew5D50RGu1+eCJbW C6ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mU1T17TmUMKJ1FQ3DqAQW105Hs0gFl2y7tVhnhRI/Pc=; b=nlLnSvNpJKXh3IWwXvfmvxub03v3HFwS8/BAMi32gGFavf6zXeQNY16BndJvens7pp wu9WKPlxkXYas/s9dlzapenbQ9t2SMR9/JUOL/xSWoaSO3CsM+9VQ+tfZrliUYYMfo5P xjE8Dqg5O0pE/feObxNwZtVf+vSZ4NXRUo1d4Wq/IYsdyzVxUBiS4h02EYmBQJLYSQax GvqPuaaqr/x2AVPKhMS7DScCalgbhDhbHDA/W3lZq/UC9GIaSxO2L9zU+o/w7W2bDgOb 98KFPEvakHk+ULVlv5eRFKnHA2AQawTCXIDLEaTsQYfvBmelnyaxj577lV98tcWw7XyG jTuA== X-Gm-Message-State: ACrzQf1kIadYqUskTcky3VmWHq/HcJVe7a8lvqIdrZZkTT5YKCj9JbT9 ruLM/EEnVVPpSqSAPy4Yymbs8g== X-Google-Smtp-Source: AMsMyM5s03xz7K8V7wRjPw62PqrykcpGllOh53A5mlcV8u+2k6r4RX8HHjGD+srWOSlqw51wIIai/g== X-Received: by 2002:a05:6512:1303:b0:4ab:4bef:b3db with SMTP id x3-20020a056512130300b004ab4befb3dbmr24104861lfu.592.1668089156138; Thu, 10 Nov 2022 06:05:56 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id bp9-20020a056512158900b004b19f766b07sm2776842lfb.91.2022.11.10.06.05.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 06:05:55 -0800 (PST) Message-ID: Date: Thu, 10 Nov 2022 15:05:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH net-next V2] dt-bindings: net: ethernet-controller: Add ptp-hardware-clock Content-Language: en-US To: "Gaddam, Sarath Babu Naidu" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "richardcochran@gmail.com" Cc: "krzysztof.kozlowski+dt@linaro.org" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "yangbo.lu@nxp.com" , "Pandey, Radhey Shyam" , "Sarangi, Anirudha" , "Katakam, Harini" , "git (AMD-Xilinx)" References: <20221021054111.25852-1-sarath.babu.naidu.gaddam@amd.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/11/2022 10:57, Gaddam, Sarath Babu Naidu wrote: >>> >>> + ptp-hardware-clock: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: >>> + Specifies a reference to a node representing a IEEE1588 timer. >> >> Drop "Specifies a reference to". It's obvious from the schema. >> >> Aren't you expecting here some specific Devicetree node of IEEE1588 timer? >> IOW, you expect to point to timer, but what this timer must provide? How is >> this generic? > > Thanks for review comments. > Format can be as documented by users Documentation/devicetree/bindings/ptp/ members. The node should be accessible to derive the index but the format of the PTP clock node is upto the vendor. I am not sure what do you mean here. Anyway description might need something more specific. > > >> >> In your commit msg you use multiple times "driver", so are you adding it only >> to satisfy Linux driver requirements? What about other drivers, e.g. on BSD >> or U-Boot? > > AFAIK this is for Linux. It is not relevant to uboot as there's no PTP support there. And BSD? Bindings are not for Linux only. Please abstract from any OS specifics. Also your messages needs wrapping. Use mailing list reply style. Best regards, Krzysztof