From: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Eduardo Valentin
<edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Vincent Guittot
<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Punit.Agrawal-5wv7dgnIgG8@public.gmane.org,
ionela.voinescu-5wv7dgnIgG8@public.gmane.org
Subject: Re: [Query] thermal: Who is using "cooling-{min|max}-level}" properties ?
Date: Mon, 12 Feb 2018 10:52:13 +0100 [thread overview]
Message-ID: <f361b9a0-08ac-9d19-76b2-83e67a6a2406@linaro.org> (raw)
In-Reply-To: <20180212085242.GQ28462@vireshk-i7>
On 12/02/2018 09:52, Viresh Kumar wrote:
> On 12-02-18, 09:39, Daniel Lezcano wrote:
>> On 12/02/2018 07:10, Viresh Kumar wrote:
>>> On 09-02-18, 13:14, Daniel Lezcano wrote:
>>>> Putting apart the device binding changes discussion for the moment. Why
>>>> not register the cpufreq driver in all the cases and then drop
>>>
>>> s/cpufreq driver/cpufreq cooling driver/ ??
>>
>> yes.
>>
>>>> cooling-cells ? So when the opps are present, its registers in the
>>>> cpufreq->ready callback.
>>>
>>> How will someone tell if they don't need the cooling infrastructure ?
>>> Specially for multiplatform thing.
>>
>> They don't define a cooling device in the DT ?
>
> Sorry but I am getting a bit confused on what you are suggesting.
> Maybe you need to rephrase it once more for me, from the very
> beginning :)
Not sure it is worth to go further in the discussion. I realize the
*-cells is widely used everywhere. I was wondering if cooling-cells
still have a meaning if we remove the min|max-levels as it is always
two. But so far it is used as a cooling property for the device in any
case and removing it *is* inconsistent with the rest of the code.
Just to clarify my comment above, I understood you were asking how to
not use the cpu as a cooling device. As the binding between the cooling
device and the thermal zone happens when the DT nodes are the same, when
registering the cpufreq driver as a cooling device and when the
cooling-device registers itself at the cooling-map parsing time, if we
remove the cooling-device in the cooling-map, the binding never happens
thus the cpu is never used as a cooling device. However, these are all
required fields, so the only way to do that is to remove the entire
thermal zone node, not sure it is what we want :)
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-12 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 6:59 [Query] thermal: Who is using "cooling-{min|max}-level}" properties ? Viresh Kumar
2018-02-07 10:04 ` Daniel Lezcano
[not found] ` <c7bd6ed5-b93e-3a07-b4a2-4c3b1eef5fac-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-07 10:24 ` Viresh Kumar
2018-02-07 10:45 ` Daniel Lezcano
2018-02-09 6:42 ` Viresh Kumar
2018-02-09 9:15 ` Daniel Lezcano
[not found] ` <539699c7-9509-dea2-2b31-c5f6749c99c4-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-09 9:24 ` Viresh Kumar
2018-02-09 12:14 ` Daniel Lezcano
[not found] ` <5722441d-c8be-4d29-fab7-28b4e5716961-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-12 6:10 ` Viresh Kumar
2018-02-12 8:39 ` Daniel Lezcano
2018-02-12 8:52 ` Viresh Kumar
2018-02-12 9:52 ` Daniel Lezcano [this message]
2018-02-12 10:17 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f361b9a0-08ac-9d19-76b2-83e67a6a2406@linaro.org \
--to=daniel.lezcano-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=Punit.Agrawal-5wv7dgnIgG8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ionela.voinescu-5wv7dgnIgG8@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).