From: Artur Weber <aweber.kernel@gmail.com>
To: Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Stanislav Jakubek <stano.jakubek@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing function
Date: Thu, 13 Mar 2025 21:39:05 +0100 [thread overview]
Message-ID: <f363c1ce-8612-476e-a5d5-c3cb358bf50a@gmail.com> (raw)
In-Reply-To: <ef190ba8-a5c7-4a1a-90e6-2610de00e4ed@sirena.org.uk>
On 13.03.2025 14:25, Mark Brown wrote:
> On Thu, Mar 13, 2025 at 01:20:36PM +0000, Lee Jones wrote:
>> On Tue, 04 Mar 2025, Artur Weber wrote:
>
>>> + if (id != bcm590xx->pmu_id) {
>>> + dev_err(bcm590xx->dev,
>>> + "Incorrect ID for %s: expected %x, got %x. Check your DT compatible.\n",
>>
>> Isn't it more likely that the H/W this is being executed on is
>> unsupported? If so, say that instead.
>
> Given that the compatibles are device specific the driver shouldn't be
> binding if the device is unsupported.
Yes, the intention here is just to make sure that the DT compatible and
hardware ID match. Unsupported hardware would not have a DT compatible.
Best regards
Artur
next prev parent reply other threads:[~2025-03-13 20:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 6:20 [PATCH v6 00/10] mfd: bcm590xx: Add support for BCM59054 Artur Weber
2025-03-04 6:20 ` [PATCH v6 01/10] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2025-03-04 14:16 ` Rob Herring (Arm)
2025-03-04 6:20 ` [PATCH v6 02/10] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2025-03-04 14:19 ` Rob Herring
2025-03-05 16:52 ` Artur Weber
2025-03-05 17:02 ` Rob Herring
2025-03-04 6:20 ` [PATCH v6 03/10] ARM: dts: Drop DTS for BCM59056 PMU Artur Weber
2025-03-17 13:29 ` Florian Fainelli
2025-03-04 6:20 ` [PATCH v6 04/10] mfd: bcm590xx: Drop unused "id" member of bcm590xx MFD struct Artur Weber
2025-03-04 6:20 ` [PATCH v6 05/10] mfd: bcm590xx: Add support for multiple device types + BCM59054 compatible Artur Weber
2025-03-04 6:20 ` [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing function Artur Weber
2025-03-13 13:20 ` Lee Jones
2025-03-13 13:25 ` Mark Brown
2025-03-13 20:39 ` Artur Weber [this message]
2025-03-14 8:00 ` Lee Jones
2025-03-14 8:42 ` Lee Jones
2025-03-04 6:20 ` [PATCH v6 07/10] regulator: bcm590xx: Use dev_err_probe for regulator register error Artur Weber
2025-03-04 6:20 ` [PATCH v6 08/10] regulator: bcm590xx: Store regulator descriptions in table Artur Weber
2025-03-04 6:20 ` [PATCH v6 09/10] regulator: bcm590xx: Rename BCM59056-specific data as such Artur Weber
2025-03-04 6:20 ` [PATCH v6 10/10] regulator: bcm590xx: Add support for BCM59054 regulators Artur Weber
2025-03-13 13:21 ` [PATCH v6 00/10] mfd: bcm590xx: Add support for BCM59054 Lee Jones
2025-03-13 20:49 ` Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f363c1ce-8612-476e-a5d5-c3cb358bf50a@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).