From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: pd.pstoykov@gmail.com, linux-iio@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] iio: pressure: Add driver for Sensirion SDP500
Date: Sun, 28 Jul 2024 11:12:45 +0200 [thread overview]
Message-ID: <f3772311-baf6-4d45-8678-83ff248dcbf0@linaro.org> (raw)
In-Reply-To: <20240725-mainline_sdp500-v4-2-ea2f5b189958@gmail.com>
On 25/07/2024 17:37, Petar Stoykov via B4 Relay wrote:
> From: Petar Stoykov <pd.pstoykov@gmail.com>
>
> Sensirion SDP500 is a digital differential pressure sensor. The sensor is
> accessed over I2C.
>
> Signed-off-by: Petar Stoykov <pd.pstoykov@gmail.com>
> ---
> +
> +static const struct i2c_device_id sdp500_id[] = {
> + { "sdp500" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, sdp500_id);
> +
> +static const struct of_device_id sdp500_of_match[] = {
> + { .compatible = "sensirion,sdp500" },
> + { .compatible = "sensirion,sdp510" },
Drop, why do you need it? I asked about this last time. Also, your OF
table is not in sync with I2C table, so this should raise questions.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-28 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 15:37 [PATCH v4 0/3] Add support for Sensirion SDP500 Petar Stoykov via B4 Relay
2024-07-25 15:37 ` [PATCH v4 1/3] dt-bindings: iio: pressure: Add " Petar Stoykov via B4 Relay
2024-07-28 9:13 ` Krzysztof Kozlowski
2024-07-25 15:37 ` [PATCH v4 2/3] iio: pressure: Add driver for " Petar Stoykov via B4 Relay
2024-07-28 9:12 ` Krzysztof Kozlowski [this message]
2024-07-28 15:29 ` Jonathan Cameron
2024-07-28 15:28 ` Jonathan Cameron
2024-07-25 15:37 ` [PATCH v4 3/3] MAINTAINERS: Add " Petar Stoykov via B4 Relay
2024-07-28 15:30 ` [PATCH v4 0/3] Add support for " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3772311-baf6-4d45-8678-83ff248dcbf0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pd.pstoykov@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox