From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB6CC76196 for ; Mon, 10 Apr 2023 15:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbjDJPV2 (ORCPT ); Mon, 10 Apr 2023 11:21:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbjDJPV1 (ORCPT ); Mon, 10 Apr 2023 11:21:27 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9C3859F6 for ; Mon, 10 Apr 2023 08:21:25 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id xi5so13239972ejb.13 for ; Mon, 10 Apr 2023 08:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681140084; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bKtT8o0nbJmVFZqD5xdbccYQdI3DXqK9lUo8ZKY2dTM=; b=slRgyI+52iHvXahH4qL+XTlfEV2EYvwSLocgDrob8uaIhQZ3yakolVzAMrfa/SVTr5 zw6N5MS3nEXHySmGbN8az93HXCIcM847M0OeJhKETsfurQfLrNjTE8N8EnW4371zjGlg GJVq2n0bi+ECEXB+yycG1nvKDHQ8Vvcq3CIx06lfAMuypio7bmFfEjsBI1De4alSCTyo R6wsBrFSro1UVghATZTWEumTkEy7hmL1riDtURZBUQQZNHtOJGGDoCYM459p2uSZfr9o T9XhhkBJYEj/ke5x/eSG9pp59xwTVmG2meoAfyri3bvyuD5wQlyxiC6zy0hV2HltnP7j yR/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681140084; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bKtT8o0nbJmVFZqD5xdbccYQdI3DXqK9lUo8ZKY2dTM=; b=1ey1wGAQZO6ljOHhSwCwM24BZ4ftV/of7ehccfVtli9RU7E+K8XMp8iZwRMKHnZyAq /4+TuwVLUa+DjI7f+qlWNy39J/N/z3ivD+i//vsIqKL4i6lwtUOx4ttFyHUoX24fY0pX wyAF3EfxTr3FnRIJveWArY4nQNzlZEvGBBTCuqLjNRwm6euUOsRaXHtYlu87fdhakPtj 48N2tlhtIgw7Q1ikfyMvHhoGvCZJaHBTJ9B5NIs5lQ962j4wg5Y9gAHMw7hK/YEzwQ1T qJsjQG06jDGaIHGXgR0Vc699YUop9PElcSRSfh0NbaFQEMk69GaPxKRAWxaUDvpyHmFm S34A== X-Gm-Message-State: AAQBX9d2U+GP4wa2V0jqB8xABdTkLwOGKob82BIvcHUTAlFW/5c/beit 7UQn9l8YfNPo36XAqhk0LsIm7A== X-Google-Smtp-Source: AKy350abdMkfY6LcbSY98RHE9h5BYQT2H/JkkaLfVPvhxnTdQpqI7LYU2qzjeoqCvj/JaN79xyfXJg== X-Received: by 2002:a17:906:f0da:b0:94a:9ae2:1642 with SMTP id dk26-20020a170906f0da00b0094a9ae21642mr2200834ejb.46.1681140084267; Mon, 10 Apr 2023 08:21:24 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:eacd:ffa4:1df7:3870? ([2a02:810d:15c0:828:eacd:ffa4:1df7:3870]) by smtp.gmail.com with ESMTPSA id wv1-20020a170907080100b0094c4dd34a0asm412826ejb.114.2023.04.10.08.21.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 08:21:23 -0700 (PDT) Message-ID: Date: Mon, 10 Apr 2023 17:21:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 1/3] dt-binding: pci: add JH7110 PCIe dt-binding documents. To: Minda Chen , Emil Renner Berthing , Conor Dooley , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Mason Huo , Leyfoon Tan , Kevin Xie References: <20230406111142.74410-1-minda.chen@starfivetech.com> <20230406111142.74410-2-minda.chen@starfivetech.com> <38bc48bf-7d8c-8ddd-861f-3b7f3d2edce6@linaro.org> <430f1eb0-e348-8a4e-b501-16b8c3b2494f@starfivetech.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <430f1eb0-e348-8a4e-b501-16b8c3b2494f@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/04/2023 11:05, Minda Chen wrote: >>> + >>> + starfive,stg-syscon: >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + items: >>> + items: >>> + - description: phandle to System Register Controller stg_syscon node. >>> + - description: register0 offset of STG_SYSCONSAIF__SYSCFG register for PCIe. >>> + - description: register1 offset of STG_SYSCONSAIF__SYSCFG register for PCIe. >>> + - description: register2 offset of STG_SYSCONSAIF__SYSCFG register for PCIe. >>> + - description: register3 offset of STG_SYSCONSAIF__SYSCFG register for PCIe. >>> + description: >>> + The phandle to System Register Controller syscon node and the offset >>> + of STG_SYSCONSAIF__SYSCFG register for PCIe. Total 4 regsisters offset >>> + for PCIe. >>> + >>> + pwren-gpios: >>> + description: Should specify the GPIO for controlling the PCI bus device power on. >> >> What are these? Different than defined in gpio-consumer-common? >> > power gpio board level configuration. It it not a requried property What is "board level configuration"? Again - is it different than powerdown-gpios from gpio-consumer-common.yaml? Best regards, Krzysztof